diff mbox series

[FFmpeg-devel] doc: use HOSTEXESUF when calling binary

Message ID 20240423215713.407217-1-timo@rothenpieler.org
State Accepted
Commit 61f27e5f71f8a972410daf241a9de067d9915ce1
Headers show
Series [FFmpeg-devel] doc: use HOSTEXESUF when calling binary | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Timo Rothenpieler April 23, 2024, 9:57 p.m. UTC
This is neccesary on WSL, and has no averse effects in normal
environments.
---
 doc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer April 23, 2024, 10:01 p.m. UTC | #1
On 4/23/2024 6:57 PM, Timo Rothenpieler wrote:
> This is neccesary on WSL, and has no averse effects in normal
> environments.
> ---
>   doc/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/Makefile b/doc/Makefile
> index 67586e4b74..98d29f1c66 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -60,7 +60,7 @@ GENTEXI := $(GENTEXI:%=doc/avoptions_%.texi)
>   
>   $(GENTEXI): TAG = GENTEXI
>   $(GENTEXI): doc/avoptions_%.texi: doc/print_options$(HOSTEXESUF)
> -	$(M)doc/print_options $* > $@
> +	$(M)doc/print_options$(HOSTEXESUF) $* > $@
>   
>   doc/%.html: TAG = HTML
>   doc/%-all.html: TAG = HTML

LGTM. It's even how it's named in the dependency on the line above.
Timo Rothenpieler April 23, 2024, 10:14 p.m. UTC | #2
On 24.04.2024 00:01, James Almer wrote:
> On 4/23/2024 6:57 PM, Timo Rothenpieler wrote:
>> This is neccesary on WSL, and has no averse effects in normal
>> environments.
>> ---
>>   doc/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/Makefile b/doc/Makefile
>> index 67586e4b74..98d29f1c66 100644
>> --- a/doc/Makefile
>> +++ b/doc/Makefile
>> @@ -60,7 +60,7 @@ GENTEXI := $(GENTEXI:%=doc/avoptions_%.texi)
>>   $(GENTEXI): TAG = GENTEXI
>>   $(GENTEXI): doc/avoptions_%.texi: doc/print_options$(HOSTEXESUF)
>> -    $(M)doc/print_options $* > $@
>> +    $(M)doc/print_options$(HOSTEXESUF) $* > $@
>>   doc/%.html: TAG = HTML
>>   doc/%-all.html: TAG = HTML
> 
> LGTM. It's even how it's named in the dependency on the line above.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

applied, thanks
diff mbox series

Patch

diff --git a/doc/Makefile b/doc/Makefile
index 67586e4b74..98d29f1c66 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -60,7 +60,7 @@  GENTEXI := $(GENTEXI:%=doc/avoptions_%.texi)
 
 $(GENTEXI): TAG = GENTEXI
 $(GENTEXI): doc/avoptions_%.texi: doc/print_options$(HOSTEXESUF)
-	$(M)doc/print_options $* > $@
+	$(M)doc/print_options$(HOSTEXESUF) $* > $@
 
 doc/%.html: TAG = HTML
 doc/%-all.html: TAG = HTML