From patchwork Fri Apr 26 03:08:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48266 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1509:b0:1a9:af23:56c1 with SMTP id nq9csp112431pzb; Thu, 25 Apr 2024 20:09:34 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU0lYcIDy1o1qUScPdC1sZdsxQLzPrE0w9We9+8HzrHoWe3xO1PEyRHq6nnol+6uUkU+Acb2K4LKtwe/iZ5pkbKBopFXwDjR97n6g== X-Google-Smtp-Source: AGHT+IFOgRUjZ7OCWirghHE7NvBNvPmLo7JDUoW6q8Y0qkRLPtIRBVdO+OhmwLRzV3QqipBWbNZE X-Received: by 2002:a19:5508:0:b0:51a:dcf4:5b2a with SMTP id n8-20020a195508000000b0051adcf45b2amr750122lfe.56.1714100974638; Thu, 25 Apr 2024 20:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714100974; cv=none; d=google.com; s=arc-20160816; b=DOSr2ZOnNUCq+2x+8ojLz9S6tsZFeTIs/BxsgM+f6mTnGdVUm3l5h0K2JQCafYiGhB pp2Epu2Ts/BdvS15qj5J/Pa6peW0/621lSgCWKuIvwIdmTzh9K53tOThxhG2Twz1PfDf +rgZ+Ac9nDfZPdpEypmdIKSd62/Zh3eUOj6kJzGNDX2bwYvA7r1XsYjd7gIsN32yPDgp QyuA4hOPOhQ1ALvIXnGHrvdphJayJjhwXqFRRjys8bY+jLmT6QFRgFJqZkcqtvxBPsg5 KQuPLYZwCcls9TxUbjin6RpP5m+WfMvDjKxfDP3/U1mLf6rWJrOOT60PFQ30VLXjOK8B bWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=w8uUaG9N9Bi7PG4DxnYUnj7hkHTtXN2iEmIP9H1iJA8=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=EZnuVeSFEInMdUoOtbxt2eqijoaDNv4RANa3ck7uFpqAwoTPNrZ60qwMk+Fcg/oJAh bmiBvBfpP5L9m5PD6eXc6QiJ/FwrM2lF5y2WUWd5vvBP8lH48dTeZDF2fbXplzJ4hX85 BW4FHLbI/HvwKhVkV9M8T6Dp3IBhk5ddwzqTGwECtvsR+KhSdb8LSOIwuivDMFbInXF8 S2MuQolj2awpJtBWFFcoJb23bMq4TjwOylb/L1sp4mtOeL3FzKc2IHozZkxgDPbRA1dL IusYM8dOZYxnn7uuS5LOw0hNslTVOhxmHFXIIHfSTHVaJmzQV9LCLXVOfqsiDVbU5Rhh OYnw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="i/AIc+AH"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ne14-20020a1709077b8e00b00a55a5f4d6a1si7459746ejc.590.2024.04.25.20.09.34; Thu, 25 Apr 2024 20:09:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="i/AIc+AH"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17A7C68D446; Fri, 26 Apr 2024 06:08:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4DE4768D425 for ; Fri, 26 Apr 2024 06:08:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 87809C0005 for ; Fri, 26 Apr 2024 03:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714100924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFMSYExuMgFhFqNCtzf24V7bgIn8G/bisKIf5uzkOAQ=; b=i/AIc+AHZ+M+ySSROmJtTbzBJgjNryWAurnpzXbNuYsZ9DiY8lktBOC1RXOqtWcRIU7e8k f36goXPoei1Q4zWKBfACGIiaJwLTPPbP2n6JqoKAytjJDexvpdqUyxMmtBWAZly2aWZv4H S8Gn9fRtXFzBpJG1nQ0R/pamv8pbQUaF9sTXPhqdcmqVAsBjQdFpB674XkJYXz+9Lof+Ft 3o6nOVL8mYYx8KUCF+/X+QQ9f+hhV9j61DlMq5hdc6FQk4shKc0olm//h5RfmM/jzuQ7L2 Bl5o++AX2jcsws618ldcJn5kY63iePVXqzT+qjaKNbtRCf+phWSqT4v4J5rn2A== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 26 Apr 2024 05:08:38 +0200 Message-ID: <20240426030839.3001504-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240426030839.3001504-1-michael@niedermayer.cc> References: <20240426030839.3001504-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 5/6] avcodec/wavarc: fix integer overflow in decode_5elp() block type 2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: mSqKE+n7om3h Fixes: signed integer overflow: 2097152000 + 107142979 cannot be represented in type 'int' Fixes: 67919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-5955101769400320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavarc.c b/libavcodec/wavarc.c index b4b26958e6f..93b76c43e8a 100644 --- a/libavcodec/wavarc.c +++ b/libavcodec/wavarc.c @@ -689,7 +689,7 @@ static int decode_5elp(AVCodecContext *avctx, for (int o = 0; o < order; o++) sum += s->filter[ch][o] * (unsigned)samples[n + 70 - o - 1]; - samples[n + 70] += ac_out[n] + (sum >> 4); + samples[n + 70] += ac_out[n] + (unsigned)(sum >> 4); } for (int n = 0; n < 70; n++)