From patchwork Fri Jul 7 13:45:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timo Rothenpieler X-Patchwork-Id: 42503 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1e:b0:12b:9ae3:586d with SMTP id c30csp7304017pzh; Fri, 7 Jul 2023 06:46:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlFpSapN3aDnWduGvs+I8cn+aIaj/E+dRCFndBAJgXodxCdJgdfNEusjv4YGnZ1GHq8QAISN X-Received: by 2002:aa7:d286:0:b0:51d:9232:2b5b with SMTP id w6-20020aa7d286000000b0051d92322b5bmr3770563edq.4.1688737576923; Fri, 07 Jul 2023 06:46:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688737576; cv=none; d=google.com; s=arc-20160816; b=YwHBywj/mIVHvmoZJKNWyx90kazNHoa44pGo0ZFfBA/SjgRKiFHmxpcnY5AU4aeewp nNbJfv7pqxeLm62eCRSOR2XiwrYB1yvHlxS2OYB5AaiE+AACOCBQysAV6MEzASXChvFt kxkwWZYqbqKQzzrbwLdG+3FSVTrLMn0rLyYtN2xEX3YAFJi3TrXK571sS494FmuKDnML ml7Xduk+Q7XNgbwTGyWBrBlyxe99eb+g9vzrcZ4PRWjFs5tBUg0gH7tXBlRGW2CUCMoX xWLB8QFG+raA0XMeK37uX0GEsIZDHQ4ksnPeTmsd0yzAT7HJCmcnHvpriFo2L5u5EqEL OJFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=PX+2d9vPZKeFP0e3AySOkaalGzzZW8jjpvSB7gPI1Ps=; fh=THn8xhm7nbInKfZrsdxNoU1y4WW1Zw1l5a5AomvlR2A=; b=mDArSQmD9E5lJcZGodQ0G5HN/yPbeZUVT+eJYQ008JVewKLmMT/ia/k1eqsufZmtC/ zNbLyrKJsonqs1UI5X1bwksYaLEADsefG70VFLf3fRIsjUf/tT51DHekYeK+qcvDXyv2 Bf35CF5xXK/DbsFEYe+8o2eVIIqtAJlSvL57jSWG1kwaKF7NYl+s/We+mFAP/FE6K7jf gqTj2i4fY5ccg0nAd/cOdLg9Jj9D8uVL1SavlA2e94AL4bK66mt56Ks43z9u5C6X/vdv NKCSyiszDVnJuOas3BaVEZefIsvZocI3ZQROq6Rh3DaTZ0i5Ch42gx5IX58zGXmJncQq q8VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@rothenpieler.org header.s=mail header.b=bbSssR7p; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rothenpieler.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u14-20020aa7d88e000000b0051e04e7b2fbsi2369699edq.531.2023.07.07.06.46.15; Fri, 07 Jul 2023 06:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@rothenpieler.org header.s=mail header.b=bbSssR7p; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rothenpieler.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6217468C72B; Fri, 7 Jul 2023 16:46:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6318A68C3EF for ; Fri, 7 Jul 2023 16:46:05 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id B518A4BA42; Fri, 7 Jul 2023 15:46:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1688737562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6fbTNGfJAex4kc5SP7Y0ONF2TAq3m4WEEiyWck54des=; b=bbSssR7puZIunf+fn25Ni1TwykurgZJRglwec4gzrDk/4TUSEOufXOoEbbmtZsKjs2v/Mn dvXeUVROlyw41bA1j/s7fdEP897Xpkly8NIGSzBk3qxqlryhKYdry3cKlqf8PVaZHMGBnx 0Sjg1MaACD15JhO13Ovu5viZ6ZJOqqVXVHXzHB8UVt1mwlePQ75IN6vpUXody/t2tsZ0hA PTAfWkJoOb00DDKMlX8dg/bfmjCzNWCey6T2H7wgRX5MZaXxbtgv6VyMiypmEcHYUhONgl jaA2p5MuHNb89IOKlaJ/6ZwgFBHnkTW0u88AufmfwgFb3gJJledTi3OtpSrmww== From: Timo Rothenpieler To: ffmpeg-devel@ffmpeg.org Date: Fri, 7 Jul 2023 15:45:53 +0200 Message-Id: <20230707134553.13643-1-timo@rothenpieler.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timo Rothenpieler Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Eld3G8bahR9Z Newer versions of the library added a new binary output format, and prefer using it by default. Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read back the trf file it has just written itself. My guess is that this might be because of the fopen-mode of "w" below, where "wb" would be needed. But since we can't really know what format the library is about to write, it's better to force it into ASCII mode when possible. --- libavfilter/vf_vidstabdetect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c index b27b1e40a6..7170f56f81 100644 --- a/libavfilter/vf_vidstabdetect.c +++ b/libavfilter/vf_vidstabdetect.c @@ -110,6 +110,10 @@ static int config_input(AVFilterLink *inlink) return AVERROR(EINVAL); } +#ifdef ASCII_SERIALIZATION_MODE + md->serializationMode = ASCII_SERIALIZATION_MODE; +#endif + // set values that are not initialized by the options s->conf.algo = 1; s->conf.modName = "vidstabdetect";