diff mbox

[FFmpeg-devel] fate: add owdenoise test

Message ID 1491172077-15371-1-git-send-email-thomastdt@googlemail.com
State Accepted
Commit dc1a1b8bd795f5fa6ec3b8f38eb97b8d98ed73fc
Headers show

Commit Message

Thomas Turner April 2, 2017, 10:27 p.m. UTC
Reference found at: http://bit.ly/2ogQygb

Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
---
 tests/fate/filter-video.mak | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Michael Niedermayer April 3, 2017, 12:20 a.m. UTC | #1
On Sun, Apr 02, 2017 at 03:27:57PM -0700, Thomas Turner wrote:
> Reference found at: http://bit.ly/2ogQygb
> 
> Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
> ---
>  tests/fate/filter-video.mak | 7 +++++++
>  1 file changed, 7 insertions(+)

reference file uploaded
test passes on linux 32/64 x86, mingw 32/64, mips&arm qemu

will apply patch in a day (please remind me) so the reference file
has been synced between fate clients

[...]
Thomas Turner April 3, 2017, 9:32 p.m. UTC | #2
On Apr 2, 2017 5:21 PM, "Michael Niedermayer" <michael@niedermayer.cc>
wrote:

On Sun, Apr 02, 2017 at 03:27:57PM -0700, Thomas Turner wrote:
> Reference found at: http://bit.ly/2ogQygb
>
> Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
> ---
>  tests/fate/filter-video.mak | 7 +++++++
>  1 file changed, 7 insertions(+)

reference file uploaded
test passes on linux 32/64 x86, mingw 32/64, mips&arm qemu

will apply patch in a day (please remind me) so the reference file
has been synced between fate clients

reminder


[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
Michael Niedermayer April 3, 2017, 10:39 p.m. UTC | #3
On Mon, Apr 03, 2017 at 02:32:15PM -0700, Thomas Turner wrote:
> On Apr 2, 2017 5:21 PM, "Michael Niedermayer" <michael@niedermayer.cc>
> wrote:
> 
> On Sun, Apr 02, 2017 at 03:27:57PM -0700, Thomas Turner wrote:
> > Reference found at: http://bit.ly/2ogQygb
> >
> > Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
> > ---
> >  tests/fate/filter-video.mak | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> reference file uploaded
> test passes on linux 32/64 x86, mingw 32/64, mips&arm qemu
> 
> will apply patch in a day (please remind me) so the reference file
> has been synced between fate clients
> 
> reminder

applied

thx

[...]
diff mbox

Patch

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index b067cc1..b40422a 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -1,3 +1,10 @@ 
+FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample
+fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=0.5,perms=random,owdenoise=10:20:20:enable=not(between(t\,0.2\,1.2))" -an -f rawvideo -
+fate-filter-owdenoise-sample: REF = $(TARGET_SAMPLES)/filter-reference/owdenoise-scenwin.raw
+fate-filter-owdenoise-sample: CMP_TARGET = 1
+fate-filter-owdenoise-sample: FUZZ = 3539
+fate-filter-owdenoise-sample: CMP = oneoff
+
 FATE_FILTER_SAMPLES-$(call ALLYES, PERMS_FILTER DELOGO_FILTER RM_DEMUXER RV30_DECODER) += fate-filter-delogo
 fate-filter-delogo: CMD = framecrc -i $(TARGET_SAMPLES)/real/rv30.rm -vf perms=random,delogo=show=0:x=290:y=25:w=26:h=16 -an