diff mbox

[FFmpeg-devel] fate: Add a test for ticket #5805.

Message ID 20160904013650.GL4692@nb4
State Not Applicable
Headers show

Commit Message

Michael Niedermayer Sept. 4, 2016, 1:36 a.m. UTC 
On Sun, Sep 04, 2016 at 12:36:46AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached is a patch to test ticket #5805.
> Unrelated: There is an unused (never used) sample in fate/jpg, see 
> https://ffmpeg.org/pipermail/ffmpeg-devel/2015-October/181127.html
> 
> Please comment, Carl Eugen

>  fate/image.mak    |    7 +++++++
>  ref/fate/jpg-jfif |    6 ++++++
>  2 files changed, 13 insertions(+)
> 893010ecbe7b0e0c1654f81d1c9156c21f9cab10  0001-fate-Add-test-for-ticket-5805.patch
> From 7fa7dd607866ba8106e1964e794228c900847c8a Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>
> Date: Sun, 4 Sep 2016 00:33:50 +0200
> Subject: [PATCH] fate: Add test for ticket #5805.

fails on mips

Test jpg-jfif failed. Look at tests/data/fate/jpg-jfif.err for details.
make: *** [fate-jpg-jfif] Error 1

Stream #0:0: Video: rawvideo ([16][0]1Y / 0x59310010), gray16be(12 bpc), 999x749 [SAR 300:300 DAR 999:749], q=2-31, 200 kb/s, 25 fps, 25 tbn, 25 tbc
                                                             ^^

[...]

Comments

Carl Eugen Hoyos Sept. 4, 2016, 10:39 a.m. UTC | #1 
2016-09-04 3:36 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> On Sun, Sep 04, 2016 at 12:36:46AM +0200, Carl Eugen Hoyos wrote:

>> Subject: [PATCH] fate: Add test for ticket #5805.
>
> fails on mips

How can I fix this?

Carl Eugen
Michael Niedermayer Sept. 4, 2016, 10:55 a.m. UTC | #2 
On Sun, Sep 04, 2016 at 12:39:38PM +0200, Carl Eugen Hoyos wrote:
> 2016-09-04 3:36 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> > On Sun, Sep 04, 2016 at 12:36:46AM +0200, Carl Eugen Hoyos wrote:
> 
> >> Subject: [PATCH] fate: Add test for ticket #5805.
> >
> > fails on mips
> 
> How can I fix this?

see b6e8efb082c284091e267a29b6060b97692d1740
that _should_ work

[...]
Carl Eugen Hoyos Sept. 4, 2016, 11:04 a.m. UTC | #3 
2016-09-04 12:55 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
>> >> Subject: [PATCH] fate: Add test for ticket #5805.
>> >
>> > fails on mips
>>
>> How can I fix this?
>
> see b6e8efb082c284091e267a29b6060b97692d1740
> that _should_ work

You mean "setsar=sar=sar" makes the difference?

Carl Eugen
Michael Niedermayer Sept. 4, 2016, 11:20 a.m. UTC | #4 
On Sun, Sep 04, 2016 at 01:04:30PM +0200, Carl Eugen Hoyos wrote:
> 2016-09-04 12:55 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> >> >> Subject: [PATCH] fate: Add test for ticket #5805.
> >> >
> >> > fails on mips
> >>
> >> How can I fix this?
> >
> > see b6e8efb082c284091e267a29b6060b97692d1740
> > that _should_ work
> 
> You mean "setsar=sar=sar" makes the difference?

likely that too (and pixfmt)

sar gets simplified if pixel fmt is converted but not if its not
so there was a 300/300 vs 1/1 difference
we could always simplify it of course somewhere but that would make
the information a little less rich. 300 probably meant dpi or something

[...]
Carl Eugen Hoyos Sept. 4, 2016, 11:24 a.m. UTC | #5 
Hi!

2016-09-04 13:20 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
>> >> >> Subject: [PATCH] fate: Add test for ticket #5805.
>> >> >
>> >> > fails on mips
>> >>
>> >> How can I fix this?
>> >
>> > see b6e8efb082c284091e267a29b6060b97692d1740
>> > that _should_ work
>>
>> You mean "setsar=sar=sar" makes the difference?
>
> likely that too (and pixfmt)
>
> sar gets simplified if pixel fmt is converted but not if its
> not so there was a 300/300 vs 1/1 difference

Yes, and I believe this makes sense (for ticket #4683).

But in the case of ticket #5805, there is no pix_fmt
conversion.

Carl Eugen
Michael Niedermayer Sept. 4, 2016, 11:27 a.m. UTC | #6 
On Sun, Sep 04, 2016 at 01:24:13PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> 2016-09-04 13:20 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> >> >> >> Subject: [PATCH] fate: Add test for ticket #5805.
> >> >> >
> >> >> > fails on mips
> >> >>
> >> >> How can I fix this?
> >> >
> >> > see b6e8efb082c284091e267a29b6060b97692d1740
> >> > that _should_ work
> >>
> >> You mean "setsar=sar=sar" makes the difference?
> >
> > likely that too (and pixfmt)
> >
> > sar gets simplified if pixel fmt is converted but not if its
> > not so there was a 300/300 vs 1/1 difference
> 
> Yes, and I believe this makes sense (for ticket #4683).
> 
> But in the case of ticket #5805, there is no pix_fmt
> conversion.

mips returns the big endian one, x86 the little endian ond
convert is needed on one side so the framecrc / md5 of the byte
values match
or iam missing something

[...]
Carl Eugen Hoyos Sept. 4, 2016, 11:33 a.m. UTC | #7 
2016-09-04 13:27 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
>> >> >> >> Subject: [PATCH] fate: Add test for ticket #5805.
>> >> >> >
>> >> >> > fails on mips
>> >> >>
>> >> >> How can I fix this?
>> >> >
>> >> > see b6e8efb082c284091e267a29b6060b97692d1740
>> >> > that _should_ work
>> >>
>> >> You mean "setsar=sar=sar" makes the difference?
>> >
>> > likely that too (and pixfmt)
>> >
>> > sar gets simplified if pixel fmt is converted but not if its
>> > not so there was a 300/300 vs 1/1 difference
>>
>> Yes, and I believe this makes sense (for ticket #4683).
>>
>> But in the case of ticket #5805, there is no pix_fmt
>> conversion.
>
> mips returns the big endian one, x86 the little endian ond
> convert is needed on one side so the framecrc / md5 of the byte
> values match

> or iam missing something

The sample in question - ticket #5805 - is eight bit and
knows nothing about endianness:
Stream #0:0: Video: mjpeg, yuvj420p

Carl Eugen
Michael Niedermayer Sept. 4, 2016, 11:44 a.m. UTC | #8 
On Sun, Sep 04, 2016 at 01:33:01PM +0200, Carl Eugen Hoyos wrote:
> 2016-09-04 13:27 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> >> >> >> >> Subject: [PATCH] fate: Add test for ticket #5805.
> >> >> >> >
> >> >> >> > fails on mips
> >> >> >>
> >> >> >> How can I fix this?
> >> >> >
> >> >> > see b6e8efb082c284091e267a29b6060b97692d1740
> >> >> > that _should_ work
> >> >>
> >> >> You mean "setsar=sar=sar" makes the difference?
> >> >
> >> > likely that too (and pixfmt)
> >> >
> >> > sar gets simplified if pixel fmt is converted but not if its
> >> > not so there was a 300/300 vs 1/1 difference
> >>
> >> Yes, and I believe this makes sense (for ticket #4683).
> >>
> >> But in the case of ticket #5805, there is no pix_fmt
> >> conversion.
> >
> > mips returns the big endian one, x86 the little endian ond
> > convert is needed on one side so the framecrc / md5 of the byte
> > values match
> 
> > or iam missing something
> 
> The sample in question - ticket #5805 - is eight bit and
> knows nothing about endianness:
> Stream #0:0: Video: mjpeg, yuvj420p

the test you submitted adds:
+fate-jpg-jfif: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/12bpp.jpg

that 12bpp sample is not eight bit

[...]
diff mbox

Patch

--- tests/ref/fate/jpg-jfif     2016-09-04 00:52:48.498542838 +0200
+++ tests/data/fate/jpg-jfif    2016-09-04 02:32:17.618668591 +0200
@@ -3,4 +3,4 @@ 
 #codec_id 0: rawvideo
 #dimensions 0: 999x749
 #sar 0: 300/300
-0,          0,          0,        1,  1496502, 0xd91deb4b
+0,          0,          0,        1,  1496502, 0x7593eb4b