diff mbox

[FFmpeg-devel,2/2] lavc/ffjni: add missing '\n'

Message ID 20170521161728.31197-2-matthieu.bouron@gmail.com
State Accepted
Commit 37de7f71758bd0ce2e3912bd70b223a718602e09
Headers show

Commit Message

Matthieu Bouron May 21, 2017, 4:17 p.m. UTC 
---
 libavcodec/ffjni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carl Eugen Hoyos May 21, 2017, 4:36 p.m. UTC | #1 
2017-05-21 18:17 GMT+02:00 Matthieu Bouron <matthieu.bouron@gmail.com>:

> -        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> attached to this thread");
> +        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> attached to this thread\n");

Please commit such fixes without sending them to -devel.

Thank you, Carl Eugen
Matthieu Bouron May 21, 2017, 4:56 p.m. UTC | #2 
On Sun, May 21, 2017 at 06:36:10PM +0200, Carl Eugen Hoyos wrote:
> 2017-05-21 18:17 GMT+02:00 Matthieu Bouron <matthieu.bouron@gmail.com>:
> 
> > -        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > attached to this thread");
> > +        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > attached to this thread\n");
> 
> Please commit such fixes without sending them to -devel.

Does that include the 3 patches ?

Thanks.
Matthieu Bouron May 22, 2017, 4:20 p.m. UTC | #3 
On Sun, May 21, 2017 at 06:56:42PM +0200, Matthieu Bouron wrote:
> On Sun, May 21, 2017 at 06:36:10PM +0200, Carl Eugen Hoyos wrote:
> > 2017-05-21 18:17 GMT+02:00 Matthieu Bouron <matthieu.bouron@gmail.com>:
> > 
> > > -        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > > attached to this thread");
> > > +        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > > attached to this thread\n");
> > 
> > Please commit such fixes without sending them to -devel.
> 
> Does that include the 3 patches ?
> 

I will push the patchset tomorrow if there is no objection (and backport
it to the 3.3 release).

[...]
Matthieu Bouron May 23, 2017, 11:31 a.m. UTC | #4 
On Mon, May 22, 2017 at 06:20:07PM +0200, Matthieu Bouron wrote:
> On Sun, May 21, 2017 at 06:56:42PM +0200, Matthieu Bouron wrote:
> > On Sun, May 21, 2017 at 06:36:10PM +0200, Carl Eugen Hoyos wrote:
> > > 2017-05-21 18:17 GMT+02:00 Matthieu Bouron <matthieu.bouron@gmail.com>:
> > > 
> > > > -        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > > > attached to this thread");
> > > > +        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment
> > > > attached to this thread\n");
> > > 
> > > Please commit such fixes without sending them to -devel.
> > 
> > Does that include the 3 patches ?
> > 
> 
> I will push the patchset tomorrow if there is no objection (and backport
> it to the 3.3 release).

Patchset applied.
diff mbox

Patch

diff --git a/libavcodec/ffjni.c b/libavcodec/ffjni.c
index b2bcae9602..f5b581f0f6 100644
--- a/libavcodec/ffjni.c
+++ b/libavcodec/ffjni.c
@@ -85,7 +85,7 @@  JNIEnv *ff_jni_get_env(void *log_ctx)
         av_log(log_ctx, AV_LOG_ERROR, "The specified JNI version is not supported\n");
         break;
     default:
-        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment attached to this thread");
+        av_log(log_ctx, AV_LOG_ERROR, "Failed to get the JNI environment attached to this thread\n");
         break;
     }