diff mbox

[FFmpeg-devel] fate: Add a test for ticket #5805.

Message ID CAB0OVGr0VT_WfU3Z-6LG7HXog=RFKzup05KTWQnuZvb1kkysTA@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Sept. 4, 2016, 11:52 a.m. UTC
Hi!

2016-09-04 13:44 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> the test you submitted adds:
> +fate-jpg-jfif: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/12bpp.jpg
>
> that 12bpp sample is not eight bit

Lol, thanks for noticing!

New patch attached, is "-idct simple" necessary?

Carl Eugen

Comments

Michael Niedermayer Sept. 4, 2016, 6:18 p.m. UTC | #1
On Sun, Sep 04, 2016 at 01:52:47PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> 2016-09-04 13:44 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> > the test you submitted adds:
> > +fate-jpg-jfif: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/12bpp.jpg
> >
> > that 12bpp sample is not eight bit
> 
> Lol, thanks for noticing!
> 
> New patch attached, is "-idct simple" necessary?
> 
> Carl Eugen

>  fate/image.mak    |    4 ++++
>  ref/fate/jpg-jfif |    6 ++++++
>  2 files changed, 10 insertions(+)
> 7877ac40860f578a8c95353de19dba0c5ad1e27f  0001-fate-Add-test-for-ticket-5805.patch
> From 79ca5df18623475572c1eaaea1c1047b27295dee Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>
> Date: Sun, 4 Sep 2016 13:50:44 +0200
> Subject: [PATCH] fate: Add test for ticket #5805.

LGTM

thx

[...]
Carl Eugen Hoyos Sept. 4, 2016, 6:30 p.m. UTC | #2
2016-09-04 20:18 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> On Sun, Sep 04, 2016 at 01:52:47PM +0200, Carl Eugen Hoyos wrote:

>> New patch attached, is "-idct simple" necessary?

>> Subject: [PATCH] fate: Add test for ticket #5805.
>
> LGTM

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

From 79ca5df18623475572c1eaaea1c1047b27295dee Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos@ag.or.at>
Date: Sun, 4 Sep 2016 13:50:44 +0200
Subject: [PATCH] fate: Add test for ticket #5805.

---
 tests/fate/image.mak    |    4 ++++
 tests/ref/fate/jpg-jfif |    6 ++++++
 2 files changed, 10 insertions(+)
 create mode 100644 tests/ref/fate/jpg-jfif

diff --git a/tests/fate/image.mak b/tests/fate/image.mak
index c1a7e48..c19312a 100644
--- a/tests/fate/image.mak
+++ b/tests/fate/image.mak
@@ -251,6 +251,10 @@  fate-exr: $(FATE_EXR-yes)
 
 FATE_JPG += fate-jpg-12bpp
 fate-jpg-12bpp: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/12bpp.jpg -f rawvideo -pix_fmt gray16le -vf setsar=sar=sar
+
+FATE_JPG += fate-jpg-jfif
+fate-jpg-jfif: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/jpg/20242.jpg
+
 FATE_JPG-$(call DEMDEC, IMAGE2, MJPEG) += $(FATE_JPG)
 FATE_IMAGE += $(FATE_JPG-yes)
 fate-jpg: $(FATE_JPG-yes)
diff --git a/tests/ref/fate/jpg-jfif b/tests/ref/fate/jpg-jfif
new file mode 100644
index 0000000..39413e7
--- /dev/null
+++ b/tests/ref/fate/jpg-jfif
@@ -0,0 +1,6 @@ 
+#tb 0: 1/25
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 807x538
+#sar 0: 72/72
+0,          0,          0,        1,   651518, 0x50faa5ad
-- 
1.7.10.4