| Message ID | CAHUoETJN69THPb5W2-vf2oKT931Zi-UHeZ-J1tqX8uwZR5qSPg@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On 6/12/17, Michael Bradshaw <mjbshaw-at-google.com@ffmpeg.org> wrote: > commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs > tool, which breaks fate: > $ make fate V=1 > TEST source > ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg" > 'runlocal fate/source-check.sh' '' '' '' '1' '' '' '' '' '' '' '' '' > '' > ./tests/fate/source-check.sh ./tests > --- ./tests/ref/fate/source 2017-06-12 10:34:46.000000000 -0700 > +++ tests/data/fate/source 2017-06-12 10:48:27.000000000 -0700 > @@ -12,6 +12,7 @@ > libavformat/log2_tab.c > libswresample/log2_tab.c > libswscale/log2_tab.c > +tools/sofa2wavs.c > tools/uncoded_frame.c > tools/yuvcmp.c > Headers without standard inclusion guards: > Test source failed. Look at tests/data/fate/source.err for details. > make: *** [fate-source] Error 1 > > Attached patch updates fate to include the sofa2wavs tool. Please review. OK, please apply.
On 6/12/2017 3:07 PM, Paul B Mahol wrote: > On 6/12/17, Michael Bradshaw <mjbshaw-at-google.com@ffmpeg.org> wrote: >> commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs >> tool, which breaks fate: >> $ make fate V=1 >> TEST source >> ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg" >> 'runlocal fate/source-check.sh' '' '' '' '1' '' '' '' '' '' '' '' '' >> '' >> ./tests/fate/source-check.sh ./tests >> --- ./tests/ref/fate/source 2017-06-12 10:34:46.000000000 -0700 >> +++ tests/data/fate/source 2017-06-12 10:48:27.000000000 -0700 >> @@ -12,6 +12,7 @@ >> libavformat/log2_tab.c >> libswresample/log2_tab.c >> libswscale/log2_tab.c >> +tools/sofa2wavs.c >> tools/uncoded_frame.c >> tools/yuvcmp.c >> Headers without standard inclusion guards: >> Test source failed. Look at tests/data/fate/source.err for details. >> make: *** [fate-source] Error 1 >> >> Attached patch updates fate to include the sofa2wavs tool. Please review. > > OK, please apply. Wouldn't it be better/proper to add the license header to the file instead?
On Mon, Jun 12, 2017 at 11:14 AM, James Almer <jamrial@gmail.com> wrote: > On 6/12/2017 3:07 PM, Paul B Mahol wrote: >> OK, please apply. > > Wouldn't it be better/proper to add the license header to the file instead? Yeah. Paul, as the proper copyright holder of the sofa2wavs.c file, could you add the license header?
On 6/12/17, Michael Bradshaw <mjbshaw-at-google.com@ffmpeg.org> wrote: > On Mon, Jun 12, 2017 at 11:14 AM, James Almer <jamrial@gmail.com> wrote: >> On 6/12/2017 3:07 PM, Paul B Mahol wrote: >>> OK, please apply. >> >> Wouldn't it be better/proper to add the license header to the file >> instead? > > Yeah. Paul, as the proper copyright holder of the sofa2wavs.c file, > could you add the license header? > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Done.
--- ./tests/ref/fate/source 2017-06-12 10:34:46.000000000 -0700 +++ tests/data/fate/source 2017-06-12 10:48:27.000000000 -0700 @@ -12,6 +12,7 @@ libavformat/log2_tab.c libswresample/log2_tab.c libswscale/log2_tab.c +tools/sofa2wavs.c tools/uncoded_frame.c tools/yuvcmp.c Headers without standard inclusion guards: