Message ID | 20170623145652.27774-1-matthieu.bouron@gmail.com |
---|---|
State | New |
Headers | show |
On 6/23/2017 11:56 AM, Matthieu Bouron wrote: > Suggested-by: James Almer <jamrial@gmail.com> > --- > libavcodec/x86/sbrdsp.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm > index 07a412b2ae..02b52ee300 100644 > --- a/libavcodec/x86/sbrdsp.asm > +++ b/libavcodec/x86/sbrdsp.asm > @@ -38,7 +38,7 @@ SECTION .text > > INIT_XMM sse > cglobal sbr_sum_square, 2, 3, 6 > - mov r2, r1 > + mov r2d, r1d nit: remove one space after mov to get vertical alignment. LGTM either way, of course. > xorps m0, m0 > xorps m1, m1 > sar r2, 3 >
On Sat, Jun 24, 2017 at 02:01:27AM -0300, James Almer wrote: > On 6/23/2017 11:56 AM, Matthieu Bouron wrote: > > Suggested-by: James Almer <jamrial@gmail.com> > > --- > > libavcodec/x86/sbrdsp.asm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm > > index 07a412b2ae..02b52ee300 100644 > > --- a/libavcodec/x86/sbrdsp.asm > > +++ b/libavcodec/x86/sbrdsp.asm > > @@ -38,7 +38,7 @@ SECTION .text > > > > INIT_XMM sse > > cglobal sbr_sum_square, 2, 3, 6 > > - mov r2, r1 > > + mov r2d, r1d > > nit: remove one space after mov to get vertical alignment. > > LGTM either way, of course. Applied with fixed alignment. Thanks. [...]
diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm index 07a412b2ae..02b52ee300 100644 --- a/libavcodec/x86/sbrdsp.asm +++ b/libavcodec/x86/sbrdsp.asm @@ -38,7 +38,7 @@ SECTION .text INIT_XMM sse cglobal sbr_sum_square, 2, 3, 6 - mov r2, r1 + mov r2d, r1d xorps m0, m0 xorps m1, m1 sar r2, 3