diff mbox

[FFmpeg-devel] avformat/mov: Enable stream parsing for VP9.

Message ID 20160907023952.GG29077@brak.lan
State Accepted
Headers show

Commit Message

Matthew Gregan Sept. 7, 2016, 2:39 a.m. UTC 
At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote:
> I think the patch is fine, but I wonder if it should set it to _FULL (the
> parser ignores the option, but it is semantically more correct).

Good point, thanks for the feedback.  Updated (simpler!) patch attached.

Cheers,

Comments

Ronald S. Bultje Sept. 7, 2016, 11:37 a.m. UTC | #1 
Hi,

On Tue, Sep 6, 2016 at 10:39 PM, Matthew Gregan <kinetik@flim.org> wrote:

> At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote:
> > I think the patch is fine, but I wonder if it should set it to _FULL (the
> > parser ignores the option, but it is semantically more correct).
>
> Good point, thanks for the feedback.  Updated (simpler!) patch attached.


LGTM.

Ronald
Ronald S. Bultje Sept. 9, 2016, 2:24 a.m. UTC | #2 
Hi,

On Wed, Sep 7, 2016 at 7:37 AM, Ronald S. Bultje <rsbultje@gmail.com> wrote:

> Hi,
>
> On Tue, Sep 6, 2016 at 10:39 PM, Matthew Gregan <kinetik@flim.org> wrote:
>
>> At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote:
>> > I think the patch is fine, but I wonder if it should set it to _FULL
>> (the
>> > parser ignores the option, but it is semantically more correct).
>>
>> Good point, thanks for the feedback.  Updated (simpler!) patch attached.
>
>
> LGTM.
>

Sorry about delay - pushed.

Ronald
diff mbox

Patch

From a9d69f145bb92939c1ffce11a0522dffff76857f Mon Sep 17 00:00:00 2001
From: Matthew Gregan <kinetik@flim.org>
Date: Wed, 7 Sep 2016 13:58:30 +1200
Subject: avformat/mov: Enable stream parsing for VP9.

MP4 media containing VP9 using superframes (such as
https://github.com/Netflix/vp9-dash/raw/master/DASH-Samples/Fountain_2997_0560kbps_640x480_4x3PAR.ivf_DashUnencrypted.ismv)
does not decode correctly with the built-in VP9 decoder because
superframes are passed to the decoder whole rather than split into
individual frames.

Signed-off-by: Matthew Gregan <kinetik@flim.org>

diff --git a/libavformat/mov.c b/libavformat/mov.c
index f499906..fa4e016 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2161,6 +2161,7 @@  static int mov_finalize_stsd_codec(MOVContext *c, AVIOContext *pb,
     case AV_CODEC_ID_EAC3:
     case AV_CODEC_ID_MPEG1VIDEO:
     case AV_CODEC_ID_VC1:
+    case AV_CODEC_ID_VP9:
         st->need_parsing = AVSTREAM_PARSE_FULL;
         break;
     default:
-- 
2.9.3