diff mbox

[FFmpeg-devel] avfilter: remove duplicate and disabled trace log function

Message ID 20170830044159.208-1-jamrial@gmail.com
State Accepted
Commit 3ec6d9c6b2975c993d772936cb37fa075292cd92
Headers show

Commit Message

James Almer Aug. 30, 2017, 4:41 a.m. UTC 
It's already defined and actually enabled depending on configure options
elsewhere.
---
 libavfilter/internal.h | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

James Almer Sept. 1, 2017, 5:08 p.m. UTC | #1 
On 8/30/2017 1:41 AM, James Almer wrote:
> It's already defined and actually enabled depending on configure options
> elsewhere.
> ---
>  libavfilter/internal.h | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/libavfilter/internal.h b/libavfilter/internal.h
> index 2ff75aa778..f9679ed1d7 100644
> --- a/libavfilter/internal.h
> +++ b/libavfilter/internal.h
> @@ -33,6 +33,7 @@
>  #include "version.h"
>  #include "video.h"
>  #include "libavcodec/avcodec.h"
> +#include "libavcodec/internal.h"
>  
>  typedef struct AVFilterCommand {
>      double time;                ///< time expressed in seconds
> @@ -246,14 +247,6 @@ void ff_command_queue_pop(AVFilterContext *filter);
>  
>  /* misc trace functions */
>  
> -/* #define FF_AVFILTER_TRACE */
> -
> -#ifdef FF_AVFILTER_TRACE
> -#    define ff_tlog(pctx, ...) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__)
> -#else
> -#    define ff_tlog(pctx, ...) do { if (0) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__); } while (0)
> -#endif
> -
>  #define FF_TPRINTF_START(ctx, func) ff_tlog(NULL, "%-16s: ", #func)
>  
>  char *ff_get_ref_perms_string(char *buf, size_t buf_size, int perms);
> 

Pushed.
diff mbox

Patch

diff --git a/libavfilter/internal.h b/libavfilter/internal.h
index 2ff75aa778..f9679ed1d7 100644
--- a/libavfilter/internal.h
+++ b/libavfilter/internal.h
@@ -33,6 +33,7 @@ 
 #include "version.h"
 #include "video.h"
 #include "libavcodec/avcodec.h"
+#include "libavcodec/internal.h"
 
 typedef struct AVFilterCommand {
     double time;                ///< time expressed in seconds
@@ -246,14 +247,6 @@  void ff_command_queue_pop(AVFilterContext *filter);
 
 /* misc trace functions */
 
-/* #define FF_AVFILTER_TRACE */
-
-#ifdef FF_AVFILTER_TRACE
-#    define ff_tlog(pctx, ...) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__)
-#else
-#    define ff_tlog(pctx, ...) do { if (0) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__); } while (0)
-#endif
-
 #define FF_TPRINTF_START(ctx, func) ff_tlog(NULL, "%-16s: ", #func)
 
 char *ff_get_ref_perms_string(char *buf, size_t buf_size, int perms);