diff mbox

[FFmpeg-devel,1/3] avcodec/diracdec: Fix integer overflow in INTRA_DC_PRED()

Message ID 20170901175612.18603-1-michael@niedermayer.cc
State Accepted
Commit 2a0823ae966be3ad40e5dba6ec4c4dc1e8c6bcad
Headers show

Commit Message

Michael Niedermayer Sept. 1, 2017, 5:56 p.m. UTC
Fixes: runtime error: signed integer overflow: 1168175789 + 1168178473 cannot be represented in type 'int'
Fixes: 3081/clusterfuzz-testcase-minimized-4807564879462400
Fixes: 2844/clusterfuzz-testcase-minimized-5561715838156800

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/diracdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Sept. 2, 2017, 8:31 p.m. UTC | #1
On Fri, Sep 01, 2017 at 07:56:10PM +0200, Michael Niedermayer wrote:
> Fixes: runtime error: signed integer overflow: 1168175789 + 1168178473 cannot be represented in type 'int'
> Fixes: 3081/clusterfuzz-testcase-minimized-4807564879462400
> Fixes: 2844/clusterfuzz-testcase-minimized-5561715838156800
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/diracdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

patchset applied

[...]
diff mbox

Patch

diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
index 0aee08f9e1..f2aed6057d 100644
--- a/libavcodec/diracdec.c
+++ b/libavcodec/diracdec.c
@@ -586,7 +586,7 @@  static inline void codeblock(DiracContext *s, SubBand *b,
     } \
 
 INTRA_DC_PRED(8, int16_t)
-INTRA_DC_PRED(10, int32_t)
+INTRA_DC_PRED(10, uint32_t)
 
 /**
  * Dirac Specification ->