diff mbox

[FFmpeg-devel] lavf/sdp: Fix MIME-type for big-endian G.726 audio.

Message ID CAB0OVGocQLXbT+jHeegKP4wQ6FrJpRuEVPwrvvKOwMer6PQKnQ@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Aug. 26, 2017, 9:53 a.m. UTC 
Hi!

Attached patch follows RFC 3551, a followup patch adds little-endian
G.726 with the old MIME-type.

Please comment, Carl Eugen

Comments

Carl Eugen Hoyos Oct. 7, 2017, 1:48 a.m. UTC | #1 
2017-08-26 11:53 GMT+02:00 Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> Hi!
>
> Attached patch follows RFC 3551, a followup patch adds little-endian
> G.726 with the old MIME-type.

Same here:
Please comment, Carl Eugen
Michael Niedermayer Oct. 7, 2017, 3:19 p.m. UTC | #2 
On Sat, Aug 26, 2017 at 11:53:46AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch follows RFC 3551, a followup patch adds little-endian
> G.726 with the old MIME-type.
> 
> Please comment, Carl Eugen

>  sdp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 764023f2cf781b005fba6baf777543fe298eca9f  0001-lavf-sdp-Fix-MIME-type-for-big-endian-G.726.patch
> From 6ee9178dfad75c4fdb1556e929a59c9d80f0976d Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Date: Sat, 26 Aug 2017 11:46:18 +0200
> Subject: [PATCH 1/2] lavf/sdp: Fix MIME-type for big-endian G.726.
> 
> RFC 3551 defines "AAL2-G726" for big-endian ("left-justified") G.726
> and "G726" for little-endian ("right-justified") G.726.

if thats what the rfc says then its obviously ok

the micro version should be bumped for every muxer fix

thx

    [...]
Carl Eugen Hoyos Oct. 7, 2017, 6:51 p.m. UTC | #3 
2017-10-07 17:19 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
> On Sat, Aug 26, 2017 at 11:53:46AM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch follows RFC 3551, a followup patch adds little-endian
>> G.726 with the old MIME-type.
>>
>> Please comment, Carl Eugen
>
>>  sdp.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 764023f2cf781b005fba6baf777543fe298eca9f  0001-lavf-sdp-Fix-MIME-type-for-big-endian-G.726.patch
>> From 6ee9178dfad75c4fdb1556e929a59c9d80f0976d Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Date: Sat, 26 Aug 2017 11:46:18 +0200
>> Subject: [PATCH 1/2] lavf/sdp: Fix MIME-type for big-endian G.726.
>>
>> RFC 3551 defines "AAL2-G726" for big-endian ("left-justified") G.726
>> and "G726" for little-endian ("right-justified") G.726.
>
> if thats what the rfc says then its obviously ok
>
> the micro version should be bumped for every muxer fix

Done and pushed with slightly changed commit message.

Thank you, Carl Eugen
diff mbox

Patch

From 6ee9178dfad75c4fdb1556e929a59c9d80f0976d Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Sat, 26 Aug 2017 11:46:18 +0200
Subject: [PATCH 1/2] lavf/sdp: Fix MIME-type for big-endian G.726.

RFC 3551 defines "AAL2-G726" for big-endian ("left-justified") G.726
and "G726" for little-endian ("right-justified") G.726.
---
 libavformat/sdp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 4e37f65..7751e67 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -674,7 +674,7 @@  static char *sdp_write_media_attributes(char *buff, int size, AVStream *st, int
             break;
         case AV_CODEC_ID_ADPCM_G726: {
             if (payload_type >= RTP_PT_PRIVATE)
-                av_strlcatf(buff, size, "a=rtpmap:%d G726-%d/%d\r\n",
+                av_strlcatf(buff, size, "a=rtpmap:%d AAL2-G726-%d/%d\r\n",
                                          payload_type,
                                          p->bits_per_coded_sample*8,
                                          p->sample_rate);
-- 
1.7.10.4