Message ID | CAGD_KHd-Wb6iVC=QTgXsFmZ=g2ddD18MDJvprFN_4D1mhLzOng@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva <isasi@google.com> wrote: > Thanks for the patch. The bug is because mov_fix_index updates > skip_samples correctly, but not start_pad. Can you instead of taking the > max, just update the mov_fix_index function so that start_pad = > skip_samples always. Something like this > Thanks this works. Patch attached.
Patch LGTM. Thanks. On Wed, Oct 18, 2017 at 4:14 PM, Dale Curtis <dalecurtis@chromium.org> wrote: > On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva <isasi@google.com> wrote: > >> Thanks for the patch. The bug is because mov_fix_index updates >> skip_samples correctly, but not start_pad. Can you instead of taking the >> max, just update the mov_fix_index function so that start_pad = >> skip_samples always. Something like this >> > > Thanks this works. Patch attached. > > >
On Wed, Oct 18, 2017 at 04:23:04PM -0700, Sasi Inguva wrote:
> Patch LGTM. Thanks.
will apply
thanks
[...]
diff --git a/libavformat/mov.c b/libavformat/mov.c index 899690d920..355e1d09fd 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3249,7 +3249,6 @@ static void mov_fix_index(MOVContext *mov, AVStream *st) // Increment skip_samples for the first non-zero audio edit list if (first_non_zero_audio_edit > 0 && st->codecpar->codec_id != AV_CODEC_ID_VORBIS) { st->skip_samples += frame_duration; - msc->start_pad = st->skip_samples;