[FFmpeg-devel,v3,1/2] avcodec/bsf: Set EOF flag only in pkt == NULL

Message ID 1469529608-1845-1-git-send-email-sebechlebskyjan@gmail.com
State Accepted
Commit 7d5501be1e429f77aca26327fbc1ec623e6e21af
Headers show

Commit Message

sebechlebskyjan@gmail.com July 26, 2016, 10:40 a.m. UTC
From: Jan Sebechlebsky <sebechlebskyjan@gmail.com>

Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().

Signed-off-by: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
---
 libavcodec/bsf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

sebechlebskyjan@gmail.com Aug. 4, 2016, 10:29 a.m. UTC | #1
On 07/26/2016 12:40 PM, sebechlebskyjan@gmail.com wrote:

> From: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
>
> Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().
>
> Signed-off-by: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
> ---
>   libavcodec/bsf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
> index 88b7f29..9b9ada7 100644
> --- a/libavcodec/bsf.c
> +++ b/libavcodec/bsf.c
> @@ -172,7 +172,7 @@ int av_bsf_init(AVBSFContext *ctx)
>   
>   int av_bsf_send_packet(AVBSFContext *ctx, AVPacket *pkt)
>   {
> -    if (!pkt || !pkt->data) {
> +    if (!pkt) {
>           ctx->internal->eof = 1;
>           return 0;
>       }
Ping for this and the next patch :)
Michael Niedermayer Aug. 13, 2016, 9:03 a.m. UTC | #2
On Tue, Jul 26, 2016 at 12:40:07PM +0200, sebechlebskyjan@gmail.com wrote:
> From: Jan Sebechlebsky <sebechlebskyjan@gmail.com>
> 
> Set BSF EOF flag only if pkt == NULL in av_bsf_send_packet().
> 
> Signed-off-by: Jan Sebechlebsky <sebechlebskyjan@gmail.com>

applied

thanks

[...]

Patch

diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
index 88b7f29..9b9ada7 100644
--- a/libavcodec/bsf.c
+++ b/libavcodec/bsf.c
@@ -172,7 +172,7 @@  int av_bsf_init(AVBSFContext *ctx)
 
 int av_bsf_send_packet(AVBSFContext *ctx, AVPacket *pkt)
 {
-    if (!pkt || !pkt->data) {
+    if (!pkt) {
         ctx->internal->eof = 1;
         return 0;
     }