diff mbox

[FFmpeg-devel,08/27] avcodec/svq3: replace YUVJ pixel format

Message ID 20171209153819.19007-8-onemda@gmail.com
State Superseded
Headers show

Commit Message

Paul B Mahol Dec. 9, 2017, 3:38 p.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavcodec/svq3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer Dec. 10, 2017, 8:53 a.m. UTC | #1 
On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/svq3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Changes:
./ffmpeg -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 2 out.mp4

change happens with any svq3 i think

[...]
Paul B Mahol Dec. 10, 2017, 10:23 a.m. UTC | #2 
On 12/10/17, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavcodec/svq3.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Changes:
> ./ffmpeg -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 2 out.mp4
>
> change happens with any svq3 i think

Is that with mpeg4 encoder?
Michael Niedermayer Dec. 10, 2017, 10:46 a.m. UTC | #3 
On Sun, Dec 10, 2017 at 11:23:10AM +0100, Paul B Mahol wrote:
> On 12/10/17, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote:
> >> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> >> ---
> >>  libavcodec/svq3.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Changes:
> > ./ffmpeg -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 2 out.mp4
> >
> > change happens with any svq3 i think
> 
> Is that with mpeg4 encoder?

its with the default as no encoder is specified  in the command like.
This should have been x264


[...]
diff mbox

Patch

diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index a937b2f951..4c6d838a15 100644
--- a/libavcodec/svq3.c
+++ b/libavcodec/svq3.c
@@ -1158,7 +1158,7 @@  static av_cold int svq3_decode_init(AVCodecContext *avctx)
     ff_hpeldsp_init(&s->hdsp, avctx->flags);
     ff_tpeldsp_init(&s->tdsp);
 
-    avctx->pix_fmt     = AV_PIX_FMT_YUVJ420P;
+    avctx->pix_fmt     = AV_PIX_FMT_YUV420P;
     avctx->color_range = AVCOL_RANGE_JPEG;
 
     s->avctx         = avctx;
@@ -1652,6 +1652,6 @@  AVCodec ff_svq3_decoder = {
     .capabilities   = AV_CODEC_CAP_DRAW_HORIZ_BAND |
                       AV_CODEC_CAP_DR1             |
                       AV_CODEC_CAP_DELAY,
-    .pix_fmts       = (const enum AVPixelFormat[]) { AV_PIX_FMT_YUVJ420P,
+    .pix_fmts       = (const enum AVPixelFormat[]) { AV_PIX_FMT_YUV420P,
                                                      AV_PIX_FMT_NONE},
 };