| Message ID | 20171210205209.9456-2-onemda@gmail.com |
|---|---|
| State | Accepted |
| Commit | f6608f47255306c92c5be324c46af3ba0c45cbd8 |
| Headers | show |
On 12/10/17, Paul B Mahol <onemda@gmail.com> wrote: > Signed-off-by: Paul B Mahol <onemda@gmail.com> > --- > libavfilter/vf_aspect.c | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-) > More than 4 days passed. I assume this one is OK?
Paul B Mahol (2017-12-15): > More than 4 days passed. > > I assume this one is OK? Wrong assumption. If you assume instead that I had very little time during the last five days, you are right. Regards,
On 12/16/17, Nicolas George <george@nsup.org> wrote: > Paul B Mahol (2017-12-15): >> More than 4 days passed. >> >> I assume this one is OK? > > Wrong assumption. If you assume instead that I had very little time > during the last five days, you are right. > What's wrong then your highness?
Paul B Mahol (2017-12-16):
> What's wrong then your highness?
What makes you think it is acceptable to talk to people that way?
I would not tolerate that kind of address from my students, I would not
tolerate it from my kids either if I had any, I do not see why I should
tolerate it from a person I work with on my spare time.
You should be glad and thankful when people are willing to review your
patches, because it reduces the odds that you will cause a regression or
light up Coverity all over the place. Otherwise, the blame and
responsibility are all yours.
As it is, I will not review this patch. Push it, do not push it, I do
not care. Your responsibility, your blame.
And stop behaving like a kid making a tantrum.
On Sun, 17 Dec 2017 13:02:14 +0100 Nicolas George <george@nsup.org> wrote: > Paul B Mahol (2017-12-16): > > What's wrong then your highness? > > What makes you think it is acceptable to talk to people that way? Oh boy this sure is a civil and friendly project. What makes _you_ think it's acceptable to treat people this way? Have you even seen how long Paul has been trying to get this in? Certainly he doesn't deserve such a reaction. It isn't the first time you act this way either. It's hard to work with you at all. I believe you claim that you have me in your kill file too. Regarding Paul's "your highness" - well you seem certainly like some sort of all knowing benevolent (academic?) leader, who has little time and for who lesser minions like Paul should be thankful to receive any audience at all, even if they have to wait a week. > I would not tolerate that kind of address from my students, I would not > tolerate it from my kids either if I had any, I do not see why I should > tolerate it from a person I work with on my spare time. This is a project of volunteers. If you don't want to commit to the rules and responsibilities of the project, you can just remove yourself from the maintainers file and stop reading/posting here. This will probably be less stressy for you too. It's not good to be stuck between two time demanding jobs. > You should be glad and thankful when people are willing to review your > patches, because it reduces the odds that you will cause a regression or > light up Coverity all over the place. Otherwise, the blame and > responsibility are all yours. Oh, now Paul should be thankful too for receiving a cranky reply after 4 days of waiting, with no time frame given for when you can grace us with your genius. Nope, it doesn't work this way. > As it is, I will not review this patch. Push it, do not push it, I do > not care. Your responsibility, your blame. I think he's totally fine with that. Better than some unfriendly person blocking a patch. > And stop behaving like a kid making a tantrum. Applies to you too. He was just being slightly cheeky (in reply to a cranky post), and then you freaked out and accused him that he'd certainly set FFmpeg on fire if he were too impatient to wait for your sage advice. (Wait how long? More than 4 days... a week? Weeks? Moths?) Anyway, I think your reply means Paul is allowed to push his patch.
2017-12-17 13:53 GMT+01:00 wm4 <nfxjfg@googlemail.com>: > This is a project of volunteers. If you don't want to commit to the > rules and responsibilities of the project, you can just remove yourself > from the maintainers file and stop reading/posting here. Both in this email and the one before you suggest to ignore our rules: Does this mean you will now stop posting here or is this just another empty promise? Carl Eugen
On Sun, 17 Dec 2017 14:03:49 +0100 Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > 2017-12-17 13:53 GMT+01:00 wm4 <nfxjfg@googlemail.com>: > > > This is a project of volunteers. If you don't want to commit to the > > rules and responsibilities of the project, you can just remove yourself > > from the maintainers file and stop reading/posting here. > > Both in this email and the one before you suggest to ignore our rules: I do not. What a weak attempt at trying to troll me. > Does this mean you will now stop posting here or is this just another > empty promise? I do not make empty promises, stop slandering me on a public mailing list.
diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspect.c index 4c93639554..c042698ef7 100644 --- a/libavfilter/vf_aspect.c +++ b/libavfilter/vf_aspect.c @@ -125,9 +125,11 @@ static int get_aspect_ratio(AVFilterLink *inlink, AVRational *aspect_ratio) #if CONFIG_SETDAR_FILTER -static int setdar_config_props(AVFilterLink *inlink) +static int setdar_config_props(AVFilterLink *outlink) { - AspectContext *s = inlink->dst->priv; + AVFilterContext *ctx = outlink->src; + AVFilterLink *inlink = ctx->inputs[0]; + AspectContext *s = ctx->priv; AVRational dar; AVRational old_dar; AVRational old_sar = inlink->sample_aspect_ratio; @@ -140,17 +142,17 @@ static int setdar_config_props(AVFilterLink *inlink) av_reduce(&s->sar.num, &s->sar.den, s->dar.num * inlink->h, s->dar.den * inlink->w, INT_MAX); - inlink->sample_aspect_ratio = s->sar; + outlink->sample_aspect_ratio = s->sar; dar = s->dar; } else { - inlink->sample_aspect_ratio = (AVRational){ 1, 1 }; + outlink->sample_aspect_ratio = (AVRational){ 1, 1 }; dar = (AVRational){ inlink->w, inlink->h }; } compute_dar(&old_dar, old_sar, inlink->w, inlink->h); - av_log(inlink->dst, AV_LOG_VERBOSE, "w:%d h:%d dar:%d/%d sar:%d/%d -> dar:%d/%d sar:%d/%d\n", + av_log(ctx, AV_LOG_VERBOSE, "w:%d h:%d dar:%d/%d sar:%d/%d -> dar:%d/%d sar:%d/%d\n", inlink->w, inlink->h, old_dar.num, old_dar.den, old_sar.num, old_sar.den, - dar.num, dar.den, inlink->sample_aspect_ratio.num, inlink->sample_aspect_ratio.den); + dar.num, dar.den, outlink->sample_aspect_ratio.num, outlink->sample_aspect_ratio.den); return 0; } @@ -169,7 +171,6 @@ static const AVFilterPad avfilter_vf_setdar_inputs[] = { { .name = "default", .type = AVMEDIA_TYPE_VIDEO, - .config_props = setdar_config_props, .filter_frame = filter_frame, }, { NULL } @@ -179,6 +180,7 @@ static const AVFilterPad avfilter_vf_setdar_outputs[] = { { .name = "default", .type = AVMEDIA_TYPE_VIDEO, + .config_props = setdar_config_props, }, { NULL } }; @@ -196,9 +198,11 @@ AVFilter ff_vf_setdar = { #if CONFIG_SETSAR_FILTER -static int setsar_config_props(AVFilterLink *inlink) +static int setsar_config_props(AVFilterLink *outlink) { - AspectContext *s = inlink->dst->priv; + AVFilterContext *ctx = outlink->src; + AVFilterLink *inlink = ctx->inputs[0]; + AspectContext *s = ctx->priv; AVRational old_sar = inlink->sample_aspect_ratio; AVRational old_dar, dar; int ret; @@ -206,13 +210,13 @@ static int setsar_config_props(AVFilterLink *inlink) if ((ret = get_aspect_ratio(inlink, &s->sar))) return ret; - inlink->sample_aspect_ratio = s->sar; + outlink->sample_aspect_ratio = s->sar; compute_dar(&old_dar, old_sar, inlink->w, inlink->h); compute_dar(&dar, s->sar, inlink->w, inlink->h); - av_log(inlink->dst, AV_LOG_VERBOSE, "w:%d h:%d sar:%d/%d dar:%d/%d -> sar:%d/%d dar:%d/%d\n", + av_log(ctx, AV_LOG_VERBOSE, "w:%d h:%d sar:%d/%d dar:%d/%d -> sar:%d/%d dar:%d/%d\n", inlink->w, inlink->h, old_sar.num, old_sar.den, old_dar.num, old_dar.den, - inlink->sample_aspect_ratio.num, inlink->sample_aspect_ratio.den, dar.num, dar.den); + outlink->sample_aspect_ratio.num, outlink->sample_aspect_ratio.den, dar.num, dar.den); return 0; } @@ -231,7 +235,6 @@ static const AVFilterPad avfilter_vf_setsar_inputs[] = { { .name = "default", .type = AVMEDIA_TYPE_VIDEO, - .config_props = setsar_config_props, .filter_frame = filter_frame, }, { NULL } @@ -241,6 +244,7 @@ static const AVFilterPad avfilter_vf_setsar_outputs[] = { { .name = "default", .type = AVMEDIA_TYPE_VIDEO, + .config_props = setsar_config_props, }, { NULL } };
Signed-off-by: Paul B Mahol <onemda@gmail.com> --- libavfilter/vf_aspect.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-)