| Message ID | fbc0e5b8-753c-7012-f6cc-5624eccad8a3@mediaarea.net |
|---|---|
| State | Accepted |
| Commit | 58e16a4f4b70b00e1ae14c8a52aea49000fa34a3 |
| Headers | show |
On 05.01.2018 11:18, Jerome Martinez wrote: > 0001-FFV1-make-RGB48-support-as-non-experimental.patch > > From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome@mediaarea.net> > Date: Fri, 5 Jan 2018 11:09:01 +0100 > Subject: [PATCH] FFV1: make RGB48 support as non-experimental make => mark BTW: common subject line format would be something like "avcodec/ffv1enc: mark RGB48 support as non-experimental" > Resulting bitstream was tested with a conformance checker > using the last draft of FFV1 specifications. > --- > libavcodec/ffv1enc.c | 4 ---- > 1 file changed, 4 deletions(-) Otherwise LGTM. Regards, Tobias
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 09df4c0c57..c0c1558ffe 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -630,10 +630,6 @@ FF_ENABLE_DEPRECATION_WARNINGS s->bits_per_raw_sample = 16; s->use32bit = 1; s->version = FFMAX(s->version, 1); - if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) { - av_log(avctx, AV_LOG_ERROR, "16bit RGB is experimental and under development, only use it for experiments\n"); - return AVERROR_INVALIDDATA; - } break; case AV_PIX_FMT_0RGB32: s->colorspace = 1;
1 year without RGB48 related patches, tested by a couple of users, tested with a FFV1 conformance checker, I suggest that FFV1 RGB48 support in FFmpeg does not mandate anymore the user to add " -strict experimental" on the command line during encoding. From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome@mediaarea.net> Date: Fri, 5 Jan 2018 11:09:01 +0100 Subject: [PATCH] FFV1: make RGB48 support as non-experimental Resulting bitstream was tested with a conformance checker using the last draft of FFV1 specifications. --- libavcodec/ffv1enc.c | 4 ---- 1 file changed, 4 deletions(-)