| Message ID | 520b41b7-a520-8b1d-bc33-c89f27ba138f@mail.de |
|---|---|
| State | New |
| Headers | show |
On 1/21/2018 6:01 PM, Thilo Borgmann wrote: > Hi, > > fixes rejection of non-free libraries if "--enable-nonfree" is omitted for me. > > Git blame says this line is older than 10 months... is it for some reason the expected behaviour? > > -Thilo > LICENSE.md says "The Fraunhofer FDK AAC and OpenSSL libraries are under licenses which are incompatible with the GPLv2 and v3. To the best of our knowledge, they are compatible with the LGPL." Both those libraries are in EXTERNAL_LIBRARY_NONFREE_LIST but at present, when configuring with license LPGL, they can be included (I've only checked configure with FDK AAC enabled). With this patch, looks like that won't be possible. Maybe these two libs can be moved to a separate list, say, "EXTERNAL_LIBRARY_LGPL_ONLY_LIST" and /configure adapted. Regards, Gyan
2018-01-21 13:31 GMT+01:00 Thilo Borgmann <thilo.borgmann@mail.de>:
> fixes rejection of non-free libraries if "--enable-nonfree" is omitted for me.
The LGPL allows you to link against a non-compatible library and
distribute the resulting binary.
Carl Eugen
Am 21.01.18 um 13:43 schrieb Carl Eugen Hoyos: > 2018-01-21 13:31 GMT+01:00 Thilo Borgmann <thilo.borgmann@mail.de>: > >> fixes rejection of non-free libraries if "--enable-nonfree" is omitted for me. > > The LGPL allows you to link against a non-compatible library and > distribute the resulting binary. So if the current behavior is indeed intended, please ignore that patch. -Thilo
diff --git a/configure b/configure index 5d53362..8532c25 100755 --- a/configure +++ b/configure @@ -3773,7 +3773,7 @@ map "die_license_disabled gpl" $EXTERNAL_LIBRARY_GPL_LIST $EXTERNAL_LIBRARY map "die_license_disabled version3" $EXTERNAL_LIBRARY_VERSION3_LIST $EXTERNAL_LIBRARY_GPLV3_LIST enabled gpl && map "die_license_disabled_gpl nonfree" $EXTERNAL_LIBRARY_NONFREE_LIST -map "die_license_disabled nonfree" $HWACCEL_LIBRARY_NONFREE_LIST +map "die_license_disabled nonfree" $HWACCEL_LIBRARY_NONFREE_LIST $EXTERNAL_LIBRARY_NONFREE_LIST enabled version3 && { enabled gpl && enable gplv3 || enable lgplv3; }
Hi, fixes rejection of non-free libraries if "--enable-nonfree" is omitted for me. Git blame says this line is older than 10 months... is it for some reason the expected behaviour? -Thilo From 6fcb95d0094341149e865982b00cb763f99a92a3 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann <thilo.borgmann@mail.de> Date: Sun, 21 Jan 2018 13:22:53 +0100 Subject: [PATCH] configure: Fix checking external non-free libraries --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)