| Message ID | CAB0OVGpxCPOOxAeXCBLe5yw8kVViXZ+JjognvMOGtcW2XUTvdg@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Mar 07, 2018 at 12:41:13AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes fate on big-endian, I failed to fix drawutils for P016. > > Please comment (or fix the underlying issue), Carl Eugen > libavfilter/drawutils.c | 2 +- > tests/ref/fate/filter-pixfmts-pad | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > cd8e8de7521d6f2913de7368ba028308f1070e0a 0001-lavfi-drawutils-Do-not-claim-to-support-P016.patch > From 5254acb48a67adc10e2651c6be449e11ecd8cb74 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos <ceffmpeg@gmail.com> > Date: Wed, 7 Mar 2018 00:36:21 +0100 > Subject: [PATCH] lavfi/drawutils: Do not claim to support P016. > > Fixes fate on big-endian. > --- > libavfilter/drawutils.c | 2 +- > tests/ref/fate/filter-pixfmts-pad | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) LGTM unless someone is activly working on adding support for this thx [...]
2018-03-07 16:55 GMT+01:00, Michael Niedermayer <michael@niedermayer.cc>: > On Wed, Mar 07, 2018 at 12:41:13AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes fate on big-endian, I failed to fix drawutils for >> P016. >> >> Please comment (or fix the underlying issue), Carl Eugen > >> libavfilter/drawutils.c | 2 +- >> tests/ref/fate/filter-pixfmts-pad | 1 - >> 2 files changed, 1 insertion(+), 2 deletions(-) >> cd8e8de7521d6f2913de7368ba028308f1070e0a >> 0001-lavfi-drawutils-Do-not-claim-to-support-P016.patch >> From 5254acb48a67adc10e2651c6be449e11ecd8cb74 Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos <ceffmpeg@gmail.com> >> Date: Wed, 7 Mar 2018 00:36:21 +0100 >> Subject: [PATCH] lavfi/drawutils: Do not claim to support P016. >> >> Fixes fate on big-endian. >> --- >> libavfilter/drawutils.c | 2 +- >> tests/ref/fate/filter-pixfmts-pad | 1 - >> 2 files changed, 1 insertion(+), 2 deletions(-) > > LGTM unless someone is activly working on adding support for this Patch applied. Thank you, Carl Eugen
From 5254acb48a67adc10e2651c6be449e11ecd8cb74 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <ceffmpeg@gmail.com> Date: Wed, 7 Mar 2018 00:36:21 +0100 Subject: [PATCH] lavfi/drawutils: Do not claim to support P016. Fixes fate on big-endian. --- libavfilter/drawutils.c | 2 +- tests/ref/fate/filter-pixfmts-pad | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index 77ab86b..17e26c7 100644 --- a/libavfilter/drawutils.c +++ b/libavfilter/drawutils.c @@ -186,7 +186,7 @@ int ff_draw_init(FFDrawContext *draw, enum AVPixelFormat format, unsigned flags) return AVERROR(EINVAL); if (desc->flags & ~(AV_PIX_FMT_FLAG_PLANAR | AV_PIX_FMT_FLAG_RGB | AV_PIX_FMT_FLAG_PSEUDOPAL | AV_PIX_FMT_FLAG_ALPHA)) return AVERROR(ENOSYS); - if (format == AV_PIX_FMT_P010LE || format == AV_PIX_FMT_P010BE) + if (format == AV_PIX_FMT_P010LE || format == AV_PIX_FMT_P010BE || format == AV_PIX_FMT_P016LE || format == AV_PIX_FMT_P016BE) return AVERROR(ENOSYS); for (i = 0; i < desc->nb_components; i++) { c = &desc->comp[i]; diff --git a/tests/ref/fate/filter-pixfmts-pad b/tests/ref/fate/filter-pixfmts-pad index 097bd58..e777211 100644 --- a/tests/ref/fate/filter-pixfmts-pad +++ b/tests/ref/fate/filter-pixfmts-pad @@ -22,7 +22,6 @@ gray16le 468bda6155bdc7a7a20c34d6e599fd16 gray9le f8f3dfe31ca5fcba828285bceefdab9a nv12 381574979cb04be10c9168540310afad nv21 0fdeb2cdd56cf5a7147dc273456fa217 -p016le 536a3b4c3b47d005f9ab033370cc1c3b rgb0 78d500c8361ab6423a4826a00268c908 rgb24 17f9e2e0c609009acaf2175c42d4a2a5 rgba b157c90191463d34fb3ce77b36c96386 -- 1.7.10.4