diff mbox

[FFmpeg-devel,V3,04/11] lavc/dump_extradata_bsf: support dump options.

Message ID aaa63f31-17fa-61a7-ffde-856ac4112ca2@gmail.com
State New
Headers show

Commit Message

Jun Zhao March 14, 2018, 5:42 a.m. UTC 
From fed84536f3c3c0fc11c63104fb6d8d93faf2000f Mon Sep 17 00:00:00 2001
From: Jun Zhao <mypopydev@gmail.com>
Date: Thu, 8 Mar 2018 14:01:48 +0800
Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.

support dump bit stream filter options

Signed-off-by: Jun Zhao <mypopydev@gmail.com>
---
 libavcodec/dump_extradata_bsf.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

Jun Zhao March 20, 2018, 5:59 a.m. UTC | #1 
Ping? 

Anybody will help to review or apply:

Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.
Subject: [PATCH V3 09/11] lavc/noise_bsf: support dump options.
Subject: [PATCH V3 10/11] lavc/remove_extradata_bsf: support dump options.
Subject: [PATCH V3 11/11] doc/fftools-common-opts: allow printing bsf details. 

patches 1-3, 5-8 have been pushed, Tks.

On 2018/3/14 13:42, Jun Zhao wrote:
James Almer March 22, 2018, 1:05 a.m. UTC | #2 
On 3/20/2018 2:59 AM, Jun Zhao wrote:
> Ping? 
> 
> Anybody will help to review or apply:
> 
> Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.
> Subject: [PATCH V3 09/11] lavc/noise_bsf: support dump options.
> Subject: [PATCH V3 10/11] lavc/remove_extradata_bsf: support dump options.
> Subject: [PATCH V3 11/11] doc/fftools-common-opts: allow printing bsf details. 
> 
> patches 1-3, 5-8 have been pushed, Tks.

Pushed the three bsf changes. I'll leave the doc change to someone else.
Jun Zhao March 22, 2018, 1:21 a.m. UTC | #3 
On 2018/3/22 9:05, James Almer wrote:
> On 3/20/2018 2:59 AM, Jun Zhao wrote:
>> Ping? 
>>
>> Anybody will help to review or apply:
>>
>> Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.
>> Subject: [PATCH V3 09/11] lavc/noise_bsf: support dump options.
>> Subject: [PATCH V3 10/11] lavc/remove_extradata_bsf: support dump options.
>> Subject: [PATCH V3 11/11] doc/fftools-common-opts: allow printing bsf details. 
>>
>> patches 1-3, 5-8 have been pushed, Tks.
> Pushed the three bsf changes. I'll leave the doc change to someone else.
Thanks, james.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
diff mbox

Patch

diff --git a/libavcodec/dump_extradata_bsf.c b/libavcodec/dump_extradata_bsf.c
index fa7bc86e19..081ae5aa08 100644
--- a/libavcodec/dump_extradata_bsf.c
+++ b/libavcodec/dump_extradata_bsf.c
@@ -78,13 +78,14 @@  fail:
 }
 
 #define OFFSET(x) offsetof(DumpExtradataContext, x)
+#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_BSF_PARAM)
 static const AVOption options[] = {
     { "freq", "When do dump extradata", OFFSET(freq), AV_OPT_TYPE_INT,
-        { .i64 = DUMP_FREQ_KEYFRAME }, DUMP_FREQ_KEYFRAME, DUMP_FREQ_ALL, 0, "freq" },
-        { "k",        NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .unit = "freq" },
-        { "keyframe", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .unit = "freq" },
-        { "e",        NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_ALL      }, .unit = "freq" },
-        { "all",      NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_ALL      }, .unit = "freq" },
+        { .i64 = DUMP_FREQ_KEYFRAME }, DUMP_FREQ_KEYFRAME, DUMP_FREQ_ALL, FLAGS, "freq" },
+        { "k",        NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" },
+        { "keyframe", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" },
+        { "e",        NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_ALL      }, .flags = FLAGS, .unit = "freq" },
+        { "all",      NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_ALL      }, .flags = FLAGS, .unit = "freq" },
     { NULL },
 };