diff mbox

[FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

Message ID CAB0OVGqj1i8gmyZdYs5ENpaV=B2u_zdM42hHxqKV4s-fOM0-sw@mail.gmail.com
State Rejected
Headers show

Commit Message

Carl Eugen Hoyos April 2, 2018, 4:59 p.m. UTC 
Hi!

One of our few sstp samples triggers a repeated request for samples.
ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf

Please comment, Carl Eugen

Comments

Kieran Kunhya April 2, 2018, 5:49 p.m. UTC | #1 
On Mon, 2 Apr 2018 at 18:04 Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:

> Hi!
>
> One of our few sstp samples triggers a repeated request for samples.
> ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf
>

Hi,

I left the message there because I actually want more DPCM samples.
That one only has a small number of DPCM blocks which I can't even see when
playing them back.

Regards,
Kieran Kunhya
Carl Eugen Hoyos April 2, 2018, 5:59 p.m. UTC | #2 
2018-04-02 19:49 GMT+02:00, Kieran Kunhya <kieran618@googlemail.com>:
> On Mon, 2 Apr 2018 at 18:04 Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
>> Hi!
>>
>> One of our few sstp samples triggers a repeated request for samples.
>> ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf

> I left the message there because I actually want more DPCM samples.

Thank you!

Carl Eugen
diff mbox

Patch

From ab69d77146af4f9eaa12debf185d588b8db80c44 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Mon, 2 Apr 2018 18:56:37 +0200
Subject: [PATCH] lavc/mpeg4videodec: Do not ask for samples we already have.

---
 libavcodec/mpeg4videodec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index f53bd03..22b73ce 100644
--- a/libavcodec/mpeg4videodec.c
+++ b/libavcodec/mpeg4videodec.c
@@ -1943,7 +1943,7 @@  static int mpeg4_decode_studio_mb(MpegEncContext *s, int16_t block_[12][64])
     } else {
         /* DPCM */
         check_marker(s->avctx, &s->gb, "DPCM block start");
-        avpriv_request_sample(s->avctx, "DPCM encoded block");
+        avpriv_report_missing_feature(s->avctx, "DPCM encoded block");
         next_start_code_studio(&s->gb);
         return SLICE_ERROR;
     }
-- 
1.7.10.4