| Message ID | 20180405181730.27043-1-lou@lrcd.com |
|---|---|
| State | Accepted |
| Commit | 2f1963eedc0c59413a03bffd45492741020a1666 |
| Headers | show |
On Thu, 5 Apr 2018 10:17:30 -0800 Lou Logan <lou@lrcd.com> wrote: > This seems to confuse Github users into thinking that we may accept pull > requests. We do not accept pull requests. > > Sending patches to the ffmpeg-devel mailing list is our preferred method > for users to contribute code. > > Signed-off-by: Lou Logan <lou@lrcd.com> > --- > doc/developer.texi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0fc9c3f21c..a0eeefe242 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -30,13 +30,11 @@ consult @url{https://ffmpeg.org/legal.html}. > > @chapter Contributing > > -There are 3 ways by which code gets into FFmpeg. > +There are 2 ways by which code gets into FFmpeg: > @itemize @bullet > -@item Submitting patches to the main developer mailing list. > +@item Submitting patches to the ffmpeg-devel mailing list. > See @ref{Submitting patches} for details. > @item Directly committing changes to the main tree. > -@item Committing changes to a git clone, for example on github.com or > - gitorious.org. And asking us to merge these changes. > @end itemize > > Whichever way, changes should be reviewed by the maintainer of the code +1
On 2018/04/05 19:17, Lou Logan wrote: > This seems to confuse Github users into thinking that we may accept pull > requests. We do not accept pull requests. > > Sending patches to the ffmpeg-devel mailing list is our preferred method > for users to contribute code. > > Signed-off-by: Lou Logan <lou@lrcd.com> > --- > doc/developer.texi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0fc9c3f21c..a0eeefe242 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -30,13 +30,11 @@ consult @url{https://ffmpeg.org/legal.html}. > > @chapter Contributing > > -There are 3 ways by which code gets into FFmpeg. > +There are 2 ways by which code gets into FFmpeg: > @itemize @bullet > -@item Submitting patches to the main developer mailing list. > +@item Submitting patches to the ffmpeg-devel mailing list. > See @ref{Submitting patches} for details. > @item Directly committing changes to the main tree. > -@item Committing changes to a git clone, for example on github.com or > - gitorious.org. And asking us to merge these changes. > @end itemize > > Whichever way, changes should be reviewed by the maintainer of the code > Consider removing 'Directly committing changes to the main tree.' as well. I'm not sure how often this is done, but certainly new contributors shouldn't be doing this.
On 6 April 2018 at 12:22, Josh de Kock <josh@itanimul.li> wrote: > On 2018/04/05 19:17, Lou Logan wrote: > >> This seems to confuse Github users into thinking that we may accept pull >> requests. We do not accept pull requests. >> >> Sending patches to the ffmpeg-devel mailing list is our preferred method >> for users to contribute code. >> >> Signed-off-by: Lou Logan <lou@lrcd.com> >> --- >> doc/developer.texi | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/doc/developer.texi b/doc/developer.texi >> index 0fc9c3f21c..a0eeefe242 100644 >> --- a/doc/developer.texi >> +++ b/doc/developer.texi >> @@ -30,13 +30,11 @@ consult @url{https://ffmpeg.org/legal.html}. >> @chapter Contributing >> -There are 3 ways by which code gets into FFmpeg. >> +There are 2 ways by which code gets into FFmpeg: >> @itemize @bullet >> -@item Submitting patches to the main developer mailing list. >> +@item Submitting patches to the ffmpeg-devel mailing list. >> See @ref{Submitting patches} for details. >> @item Directly committing changes to the main tree. >> -@item Committing changes to a git clone, for example on github.com or >> - gitorious.org. And asking us to merge these changes. >> @end itemize >> Whichever way, changes should be reviewed by the maintainer of the >> code >> >> > Consider removing 'Directly committing changes to the main tree.' as well. > I'm not sure how often this is done, but certainly new contributors > shouldn't be doing this. > > -- > Josh > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > New contributors don't have git access.
On Thu, Apr 5, 2018, at 10:17 AM, Lou Logan wrote: > This seems to confuse Github users into thinking that we may accept pull > requests. We do not accept pull requests. > > Sending patches to the ffmpeg-devel mailing list is our preferred method > for users to contribute code. > > Signed-off-by: Lou Logan <lou@lrcd.com> > --- > doc/developer.texi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Pushed, thanks.
diff --git a/doc/developer.texi b/doc/developer.texi index 0fc9c3f21c..a0eeefe242 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -30,13 +30,11 @@ consult @url{https://ffmpeg.org/legal.html}. @chapter Contributing -There are 3 ways by which code gets into FFmpeg. +There are 2 ways by which code gets into FFmpeg: @itemize @bullet -@item Submitting patches to the main developer mailing list. +@item Submitting patches to the ffmpeg-devel mailing list. See @ref{Submitting patches} for details. @item Directly committing changes to the main tree. -@item Committing changes to a git clone, for example on github.com or - gitorious.org. And asking us to merge these changes. @end itemize Whichever way, changes should be reviewed by the maintainer of the code
This seems to confuse Github users into thinking that we may accept pull requests. We do not accept pull requests. Sending patches to the ffmpeg-devel mailing list is our preferred method for users to contribute code. Signed-off-by: Lou Logan <lou@lrcd.com> --- doc/developer.texi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)