| Message ID | 20161011010548.5004-1-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 51f3278089bb5d65d4a1c47cd037d9d706a254f0 |
| Headers | show |
2016-10-11 9:05 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>: > Suggested-by: ronald > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/developer.texi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index cf809b9..dbe1f54 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -464,7 +464,11 @@ Patches should be posted to the > mailing list. Use @code{git send-email} when possible since it will > properly > send patches without requiring extra care. If you cannot, then send > patches > as base64-encoded attachments, so your patch is not trashed during > -transmission. > +transmission. Also ensure the correct mime type is used > +(text/x-diff or text/x-patch or at least text/plain) and that only one > +patch is inline or attached per mail. > +You can check @url{https://patchwork.ffmpeg.org}, if your patch does not > show up, its mime type > +likely was wrong. > > Your patch will be reviewed on the mailing list. You will likely be asked > to make some changes and are expected to send in an improved version that > -- > 2.10.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel LGTM
On Tue, Oct 11, 2016 at 09:16:14AM +0800, Steven Liu wrote: > 2016-10-11 9:05 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>: > > > Suggested-by: ronald > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > doc/developer.texi | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/doc/developer.texi b/doc/developer.texi > > index cf809b9..dbe1f54 100644 > > --- a/doc/developer.texi > > +++ b/doc/developer.texi > > @@ -464,7 +464,11 @@ Patches should be posted to the > > mailing list. Use @code{git send-email} when possible since it will > > properly > > send patches without requiring extra care. If you cannot, then send > > patches > > as base64-encoded attachments, so your patch is not trashed during > > -transmission. > > +transmission. Also ensure the correct mime type is used > > +(text/x-diff or text/x-patch or at least text/plain) and that only one > > +patch is inline or attached per mail. > > +You can check @url{https://patchwork.ffmpeg.org}, if your patch does not > > show up, its mime type > > +likely was wrong. > > > > Your patch will be reviewed on the mailing list. You will likely be asked > > to make some changes and are expected to send in an improved version that > > -- > > 2.10.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > LGTM applied thx [...]
diff --git a/doc/developer.texi b/doc/developer.texi index cf809b9..dbe1f54 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -464,7 +464,11 @@ Patches should be posted to the mailing list. Use @code{git send-email} when possible since it will properly send patches without requiring extra care. If you cannot, then send patches as base64-encoded attachments, so your patch is not trashed during -transmission. +transmission. Also ensure the correct mime type is used +(text/x-diff or text/x-patch or at least text/plain) and that only one +patch is inline or attached per mail. +You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type +likely was wrong. Your patch will be reviewed on the mailing list. You will likely be asked to make some changes and are expected to send in an improved version that
Suggested-by: ronald Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- doc/developer.texi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)