| Message ID | 20180630074452.21927-1-atomnuker@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Sat, Jun 30, 2018 at 08:44:50AM +0100, Rostislav Pehlivanov wrote: > --- > libavcodec/avcodec.h | 1 + > libavcodec/codec_desc.c | 7 +++++++ > libavcodec/version.h | 2 +- > 3 files changed, 9 insertions(+), 1 deletion(-) LGTM thx [...]
On Sat, Jun 30, 2018 at 08:44:50 +0100, Rostislav Pehlivanov wrote: > --- > libavcodec/avcodec.h | 1 + > libavcodec/codec_desc.c | 7 +++++++ > libavcodec/version.h | 2 +- > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index c90166deb6..f85af3f15d 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -637,6 +637,7 @@ enum AVCodecID { > AV_CODEC_ID_APTX, > AV_CODEC_ID_APTX_HD, > AV_CODEC_ID_SBC, > + AV_CODEC_ID_ATRAC9, > [...] Do you need to add a note to doc/APIchanges? Cheers, Moritz
On 2 July 2018 at 14:21, Moritz Barsnick <barsnick@gmx.net> wrote: > On Sat, Jun 30, 2018 at 08:44:50 +0100, Rostislav Pehlivanov wrote: > > --- > > libavcodec/avcodec.h | 1 + > > libavcodec/codec_desc.c | 7 +++++++ > > libavcodec/version.h | 2 +- > > 3 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index c90166deb6..f85af3f15d 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -637,6 +637,7 @@ enum AVCodecID { > > AV_CODEC_ID_APTX, > > AV_CODEC_ID_APTX_HD, > > AV_CODEC_ID_SBC, > > + AV_CODEC_ID_ATRAC9, > > > [...] > > Do you need to add a note to doc/APIchanges? > > Cheers, > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > No, in case you haven't noticed we don't advertise new flags there, that would just spam the list with unimportant for API users entries.
On Tue, Jul 03, 2018 at 11:45:20 +0100, Rostislav Pehlivanov wrote: > On 2 July 2018 at 14:21, Moritz Barsnick <barsnick@gmx.net> wrote: > > Do you need to add a note to doc/APIchanges? > No, in case you haven't noticed we don't advertise new flags there, that > would just spam the list with unimportant for API users entries. Indeed, I had been looking at other proposed patches, such as hwren's patch in <1530591729-7202-1-git-send-email-hwrenx@126.com>. Looking at Git, you're totally right. Thanks, Moritz
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c90166deb6..f85af3f15d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -637,6 +637,7 @@ enum AVCodecID { AV_CODEC_ID_APTX, AV_CODEC_ID_APTX_HD, AV_CODEC_ID_SBC, + AV_CODEC_ID_ATRAC9, /* subtitle codecs */ AV_CODEC_ID_FIRST_SUBTITLE = 0x17000, ///< A dummy ID pointing at the start of subtitle codecs. diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 36e9a9bbc7..a126c974e1 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -2878,6 +2878,13 @@ static const AVCodecDescriptor codec_descriptors[] = { .long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband codec)"), .props = AV_CODEC_PROP_LOSSY, }, + { + .id = AV_CODEC_ID_ATRAC9, + .type = AVMEDIA_TYPE_AUDIO, + .name = "atrac9", + .long_name = NULL_IF_CONFIG_SMALL("ATRAC9 (Adaptive TRansform Acoustic Coding 9)"), + .props = AV_CODEC_PROP_LOSSY, + }, /* subtitle codecs */ { diff --git a/libavcodec/version.h b/libavcodec/version.h index 39be9d530e..9f6b0dfe24 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -29,7 +29,7 @@ #define LIBAVCODEC_VERSION_MAJOR 58 #define LIBAVCODEC_VERSION_MINOR 20 -#define LIBAVCODEC_VERSION_MICRO 104 +#define LIBAVCODEC_VERSION_MICRO 105 #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ LIBAVCODEC_VERSION_MINOR, \