diff mbox

[FFmpeg-devel] configure: Use LDEXEFLAGS in check_ld().

Message ID 201610051512.31625.cehoyos@ag.or.at
State Accepted
Commit 932bbfc5d8ae43e73bf432cd1f7e28ccf16d14d0
Headers show

Commit Message

Carl Eugen Hoyos Oct. 5, 2016, 1:12 p.m. UTC
Hi!

Attached patch makes sure that libraries are tested with actual ldexeflags.

Please comment, Carl Eugen
From 5e26339b041f5e35112ed7f479ade6e57c3b5248 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos@ag.or.at>
Date: Wed, 5 Oct 2016 15:10:23 +0200
Subject: [PATCH] configure: Use LDEXEFLAGS in check_ld().

Avoids detecting libraries that are not compatible with ldexeflags.
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Cadhalpun Oct. 12, 2016, 5:10 p.m. UTC | #1
On 05.10.2016 15:12, Carl Eugen Hoyos wrote:
> From 5e26339b041f5e35112ed7f479ade6e57c3b5248 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>
> Date: Wed, 5 Oct 2016 15:10:23 +0200
> Subject: [PATCH] configure: Use LDEXEFLAGS in check_ld().
> 
> Avoids detecting libraries that are not compatible with ldexeflags.
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index f593191..9297321 100755
> --- a/configure
> +++ b/configure
> @@ -985,7 +985,7 @@ check_ld(){
>      check_$type $($cflags_filter $flags) || return
>      flags=$($ldflags_filter $flags)
>      libs=$($ldflags_filter $libs)
> -    check_cmd $ld $LDFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
> +    check_cmd $ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
>  }
>  
>  print_include(){
> -- 1.7.10.4

LGTM.

Best regards,
Andreas
Carl Eugen Hoyos Oct. 12, 2016, 9:01 p.m. UTC | #2
2016-10-12 19:10 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
> On 05.10.2016 15:12, Carl Eugen Hoyos wrote:

>> -    check_cmd $ld $LDFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
>> +    check_cmd $ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
>>  }
>>
>>  print_include(){
>> -- 1.7.10.4
>
> LGTM.

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

diff --git a/configure b/configure
index f593191..9297321 100755
--- a/configure
+++ b/configure
@@ -985,7 +985,7 @@  check_ld(){
     check_$type $($cflags_filter $flags) || return
     flags=$($ldflags_filter $flags)
     libs=$($ldflags_filter $libs)
-    check_cmd $ld $LDFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
+    check_cmd $ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs
 }
 
 print_include(){