diff mbox

[FFmpeg-devel,v8,2/3] lavf/riff: add avs2 fourcc

Message ID 1530788417-3067-2-git-send-email-hwrenx@126.com
State New
Headers show

Commit Message

hwren July 5, 2018, 11 a.m. UTC 
Signed-off-by: hwren <hwrenx@126.com>
---
 libavformat/riff.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Carl Eugen Hoyos July 10, 2018, 12:50 p.m. UTC | #1 
2018-07-05 13:00 GMT+02:00, hwren <hwrenx@126.com>:
> Signed-off-by: hwren <hwrenx@126.com>
> ---
>  libavformat/riff.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/riff.c b/libavformat/riff.c
> index 8911725..4153372 100644
> --- a/libavformat/riff.c
> +++ b/libavformat/riff.c
> @@ -369,6 +369,7 @@ const AVCodecTag ff_codec_bmp_tags[] = {
>      { AV_CODEC_ID_ZMBV,         MKTAG('Z', 'M', 'B', 'V') },
>      { AV_CODEC_ID_KMVC,         MKTAG('K', 'M', 'V', 'C') },
>      { AV_CODEC_ID_CAVS,         MKTAG('C', 'A', 'V', 'S') },
> +    { AV_CODEC_ID_AVS2,         MKTAG('A', 'V', 'S', '2') },

Why is this needed?

Please point us to a sample, Carl Eugen
Carl Eugen Hoyos July 10, 2018, 12:54 p.m. UTC | #2 
2018-07-10 14:50 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> 2018-07-05 13:00 GMT+02:00, hwren <hwrenx@126.com>:
>> Signed-off-by: hwren <hwrenx@126.com>
>> ---
>>  libavformat/riff.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavformat/riff.c b/libavformat/riff.c
>> index 8911725..4153372 100644
>> --- a/libavformat/riff.c
>> +++ b/libavformat/riff.c
>> @@ -369,6 +369,7 @@ const AVCodecTag ff_codec_bmp_tags[] = {
>>      { AV_CODEC_ID_ZMBV,         MKTAG('Z', 'M', 'B', 'V') },
>>      { AV_CODEC_ID_KMVC,         MKTAG('K', 'M', 'V', 'C') },
>>      { AV_CODEC_ID_CAVS,         MKTAG('C', 'A', 'V', 'S') },
>> +    { AV_CODEC_ID_AVS2,         MKTAG('A', 'V', 'S', '2') },
>
> Why is this needed?

Please ignore this.

A sample would still be nice, Carl Eugen
hwren July 14, 2018, 2:29 p.m. UTC | #3 
AVS2 stream samples could be found in avs2_samples(https://gitee.com/hwren/avs2_samples). Fate test would be added if necessary.


hwren








At 2018-07-10 20:54:49, "Carl Eugen Hoyos" <ceffmpeg@gmail.com> wrote:
>2018-07-10 14:50 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>> 2018-07-05 13:00 GMT+02:00, hwren <hwrenx@126.com>:
>>> Signed-off-by: hwren <hwrenx@126.com>
>>> ---
>>>  libavformat/riff.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavformat/riff.c b/libavformat/riff.c
>>> index 8911725..4153372 100644
>>> --- a/libavformat/riff.c
>>> +++ b/libavformat/riff.c
>>> @@ -369,6 +369,7 @@ const AVCodecTag ff_codec_bmp_tags[] = {
>>>      { AV_CODEC_ID_ZMBV,         MKTAG('Z', 'M', 'B', 'V') },
>>>      { AV_CODEC_ID_KMVC,         MKTAG('K', 'M', 'V', 'C') },
>>>      { AV_CODEC_ID_CAVS,         MKTAG('C', 'A', 'V', 'S') },
>>> +    { AV_CODEC_ID_AVS2,         MKTAG('A', 'V', 'S', '2') },
>>
>> Why is this needed?
>
>Please ignore this.
>
>A sample would still be nice, Carl Eugen
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
diff mbox

Patch

diff --git a/libavformat/riff.c b/libavformat/riff.c
index 8911725..4153372 100644
--- a/libavformat/riff.c
+++ b/libavformat/riff.c
@@ -369,6 +369,7 @@  const AVCodecTag ff_codec_bmp_tags[] = {
     { AV_CODEC_ID_ZMBV,         MKTAG('Z', 'M', 'B', 'V') },
     { AV_CODEC_ID_KMVC,         MKTAG('K', 'M', 'V', 'C') },
     { AV_CODEC_ID_CAVS,         MKTAG('C', 'A', 'V', 'S') },
+    { AV_CODEC_ID_AVS2,         MKTAG('A', 'V', 'S', '2') },
     { AV_CODEC_ID_JPEG2000,     MKTAG('m', 'j', 'p', '2') },
     { AV_CODEC_ID_JPEG2000,     MKTAG('M', 'J', '2', 'C') },
     { AV_CODEC_ID_JPEG2000,     MKTAG('L', 'J', '2', 'C') },