| Message ID | CAJsO9v7NA3YAWKQFM6Bi41bCr1bW6jLH_bCNN8HcEyu2CYVgtg@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Oct 13, 2016 at 08:53:30AM +0700, Muhammad Faiz wrote: > On Thu, Oct 13, 2016 at 8:19 AM, Michael Niedermayer > <michael@niedermayer.cc> wrote: > > On Thu, Oct 13, 2016 at 05:14:38AM +0700, Muhammad Faiz wrote: > >> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com> > >> --- > >> tests/fate/filter-audio.mak | 10 ++++++++++ > >> tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ > >> 2 files changed, 37 insertions(+) > >> create mode 100644 tests/filtergraphs/firequalizer > > > > works on mingw liunx x86 32/64 > > but fails on qemu arm > > TEST filter-firequalizer > > stddev: 0.68 PSNR: 99.68 MAXDIFF: 1 bytes: 1058400/ 1097208 > > stddev: |0.68 - 0| >= 0.01 > > Test filter-firequalizer failed. Look at tests/data/fate/filter-firequalizer.err for details. > > make: *** [fate-filter-firequalizer] Error 1 > > > > new patch with oneoff test > patch attached > > thx > fate/filter-audio.mak | 9 +++++++++ > filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) > c7cf3aec0f190b2c5e3eed28d9f5ce22cbbebcfa 0001-fate-add-test-for-firequalizer-filter.patch > From e25da07363c2126ac4642794f905678e95bf14a4 Mon Sep 17 00:00:00 2001 > From: Muhammad Faiz <mfcc64@gmail.com> > Date: Thu, 13 Oct 2016 08:43:50 +0700 > Subject: [PATCH] fate: add test for firequalizer filter works fine here LGTM please check fate.ffmpeg.org though a day or 2 after its pushed some clients might still have larger rounding differences thx [...]
On Thu, Oct 13, 2016 at 9:18 PM, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Thu, Oct 13, 2016 at 08:53:30AM +0700, Muhammad Faiz wrote: >> On Thu, Oct 13, 2016 at 8:19 AM, Michael Niedermayer >> <michael@niedermayer.cc> wrote: >> > On Thu, Oct 13, 2016 at 05:14:38AM +0700, Muhammad Faiz wrote: >> >> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com> >> >> --- >> >> tests/fate/filter-audio.mak | 10 ++++++++++ >> >> tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ >> >> 2 files changed, 37 insertions(+) >> >> create mode 100644 tests/filtergraphs/firequalizer >> > >> > works on mingw liunx x86 32/64 >> > but fails on qemu arm >> > TEST filter-firequalizer >> > stddev: 0.68 PSNR: 99.68 MAXDIFF: 1 bytes: 1058400/ 1097208 >> > stddev: |0.68 - 0| >= 0.01 >> > Test filter-firequalizer failed. Look at tests/data/fate/filter-firequalizer.err for details. >> > make: *** [fate-filter-firequalizer] Error 1 >> > >> >> new patch with oneoff test >> patch attached >> >> thx > >> fate/filter-audio.mak | 9 +++++++++ >> filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ >> 2 files changed, 36 insertions(+) >> c7cf3aec0f190b2c5e3eed28d9f5ce22cbbebcfa 0001-fate-add-test-for-firequalizer-filter.patch >> From e25da07363c2126ac4642794f905678e95bf14a4 Mon Sep 17 00:00:00 2001 >> From: Muhammad Faiz <mfcc64@gmail.com> >> Date: Thu, 13 Oct 2016 08:43:50 +0700 >> Subject: [PATCH] fate: add test for firequalizer filter > > works fine here > > LGTM > > please check fate.ffmpeg.org though a day or 2 after its pushed > some clients might still have larger rounding differences > > thx pushed thanks
From e25da07363c2126ac4642794f905678e95bf14a4 Mon Sep 17 00:00:00 2001 From: Muhammad Faiz <mfcc64@gmail.com> Date: Thu, 13 Oct 2016 08:43:50 +0700 Subject: [PATCH] fate: add test for firequalizer filter Signed-off-by: Muhammad Faiz <mfcc64@gmail.com> --- tests/fate/filter-audio.mak | 9 +++++++++ tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 tests/filtergraphs/firequalizer diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 809bf4e..9c6f7cd 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -114,6 +114,15 @@ fate-filter-extrastereo: tests/data/asynth-44100-2.wav fate-filter-extrastereo: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav fate-filter-extrastereo: CMD = framecrc -i $(SRC) -aframes 20 -af extrastereo=m=2 +FATE_AFILTER-$(call FILTERDEMDECENCMUX, FIREQUALIZER ATRIM VOLUME, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-firequalizer +fate-filter-firequalizer: tests/data/asynth-44100-2.wav +fate-filter-firequalizer: tests/data/filtergraphs/firequalizer +fate-filter-firequalizer: REF = tests/data/asynth-44100-2.wav +fate-filter-firequalizer: CMD = ffmpeg -i $(TARGET_PATH)/tests/data/asynth-44100-2.wav -filter_script $(TARGET_PATH)/tests/data/filtergraphs/firequalizer -f wav -acodec pcm_s16le - +fate-filter-firequalizer: CMP = oneoff +fate-filter-firequalizer: CMP_UNIT = s16 +fate-filter-firequalizer: SIZE_TOLERANCE = 1058400 - 1097208 + FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, SILENCEREMOVE, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-silenceremove fate-filter-silenceremove: SRC = $(TARGET_SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav fate-filter-silenceremove: CMD = framecrc -i $(SRC) -aframes 30 -af silenceremove=0:0:0:-1:0:-90dB diff --git a/tests/filtergraphs/firequalizer b/tests/filtergraphs/firequalizer new file mode 100644 index 0000000..ee432e2 --- /dev/null +++ b/tests/filtergraphs/firequalizer @@ -0,0 +1,27 @@ +firequalizer = + gain = 'sin(0.001*f) - 1': + delay = 0.05, + +firequalizer = + gain = 'if (ch, -0.7 * sin(0.001*f), -0.2 * sin(0.001*f)) - 1': + delay = 0.1: + fixed = on: + multi = on: + zero_phase = on: + wfunc = nuttall, + +firequalizer = + gain = 'if (ch, -0.3 * sin(0.001*f), -0.8 * sin(0.001*f)) - 1': + delay = 0.05: + multi = on, + +firequalizer = + gain_entry = 'entry(1000, 0); entry(5000, 0.1); entry(10000, 0.2)', + +firequalizer = + gain_entry = 'entry(1000, 0.2); entry(5000, 0.1); entry(10000, 0)', + +volume = 2.8dB, + +atrim = + start = 0.12 -- 2.5.0