diff mbox

[FFmpeg-devel,2/2] Add FATE test for QT format audio descriptors in MP4

Message ID 20180906153544.138864-3-derek.buitenhuis@gmail.com
State Accepted
Commit f55d987bad40cf1982a0a51b2ee145678ff473c1
Headers show

Commit Message

Derek Buitenhuis Sept. 6, 2018, 3:35 p.m. UTC
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 tests/fate/mov.mak                       | 3 +++
 tests/ref/fate/mov-mp4-with-mov-in24-ver | 3 +++
 2 files changed, 6 insertions(+)
 create mode 100644 tests/ref/fate/mov-mp4-with-mov-in24-ver

Comments

Derek Buitenhuis Sept. 7, 2018, 3:25 p.m. UTC | #1
On 06/09/2018 16:35, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis<derek.buitenhuis@gmail.com>
> ---
>   tests/fate/mov.mak                       | 3 +++
>   tests/ref/fate/mov-mp4-with-mov-in24-ver | 3 +++
>   2 files changed, 6 insertions(+)
>   create mode 100644 tests/ref/fate/mov-mp4-with-mov-in24-ver

Presuming nobody has an issue with the patch above from Justin, can
someone sync the sample for this to FATE?

- Derek
Michael Niedermayer Sept. 7, 2018, 4:09 p.m. UTC | #2
On Thu, Sep 06, 2018 at 04:35:44PM +0100, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  tests/fate/mov.mak                       | 3 +++
>  tests/ref/fate/mov-mp4-with-mov-in24-ver | 3 +++
>  2 files changed, 6 insertions(+)
>  create mode 100644 tests/ref/fate/mov-mp4-with-mov-in24-ver

tested on linux x86-32/64, mingw32/64, and qemu arm/mips
all work fine

thanks

[...]
Derek Buitenhuis Sept. 9, 2018, 6:58 p.m. UTC | #3
On 07/09/2018 17:09, Michael Niedermayer wrote:
> tested on linux x86-32/64, mingw32/64, and qemu arm/mips
> all work fine

Pushed, thanks.

- Derek
diff mbox

Patch

diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak
index 3d9e4280bb..ecdd7f92b4 100644
--- a/tests/fate/mov.mak
+++ b/tests/fate/mov.mak
@@ -28,6 +28,7 @@  FATE_MOV_FFPROBE = fate-mov-neg-firstpts-discard \
                    fate-mov-guess-delay-1 \
                    fate-mov-guess-delay-2 \
                    fate-mov-guess-delay-3 \
+                   fate-mov-mp4-with-mov-in24-ver \
 
 FATE_MOV_FASTSTART = fate-mov-faststart-4gb-overflow \
 
@@ -121,3 +122,5 @@  fate-mov-guess-delay-3: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stre
 fate-mov-faststart-4gb-overflow: CMD = run tools/qt-faststart$(EXESUF) $(TARGET_SAMPLES)/mov/faststart-4gb-overflow.mov faststart-4gb-overflow-output.mov > /dev/null ; md5sum faststart-4gb-overflow-output.mov | cut -d " " -f1 ; rm faststart-4gb-overflow-output.mov
 fate-mov-faststart-4gb-overflow: CMP = oneline
 fate-mov-faststart-4gb-overflow: REF = bc875921f151871e787c4b4023269b29
+
+fate-mov-mp4-with-mov-in24-ver: CMD = run ffprobe -show_entries stream=codec_name -select_streams 1 $(TARGET_SAMPLES)/mov/mp4-with-mov-in24-ver.mp4
diff --git a/tests/ref/fate/mov-mp4-with-mov-in24-ver b/tests/ref/fate/mov-mp4-with-mov-in24-ver
new file mode 100644
index 0000000000..b5522454df
--- /dev/null
+++ b/tests/ref/fate/mov-mp4-with-mov-in24-ver
@@ -0,0 +1,3 @@ 
+[STREAM]
+codec_name=pcm_s24le
+[/STREAM]