diff mbox

[FFmpeg-devel] doc/examples/demuxing_decoding: Drop AVFrame->pts use

Message ID 20161018025852.30032-1-michael@niedermayer.cc
State Accepted
Commit 2bd99564540a365d5b80d9aad6c19264b15955af
Headers show

Commit Message

Michael Niedermayer Oct. 18, 2016, 2:58 a.m. UTC
This code is not correct for git master

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 doc/examples/demuxing_decoding.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Stefano Sabatini Oct. 18, 2016, 11:53 a.m. UTC | #1
On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded:
> This code is not correct for git master
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/examples/demuxing_decoding.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c
> index 49fb6af..b1a216a 100644
> --- a/doc/examples/demuxing_decoding.c
> +++ b/doc/examples/demuxing_decoding.c
> @@ -93,10 +93,9 @@ static int decode_packet(int *got_frame, int cached)
>                  return -1;
>              }
>  
> -            printf("video_frame%s n:%d coded_n:%d pts:%s\n",
> +            printf("video_frame%s n:%d coded_n:%d\n",
>                     cached ? "(cached)" : "",
> -                   video_frame_count++, frame->coded_picture_number,
> -                   av_ts2timestr(frame->pts, &video_dec_ctx->time_base));
> +                   video_frame_count++, frame->coded_picture_number);
>  
>              /* copy decoded frame to destination buffer:
>               * this is required since rawvideo expects non aligned data */

Considering it was never so useful (it was mostly set to NOPTS), LGTM.
Michael Niedermayer Oct. 18, 2016, 1:16 p.m. UTC | #2
On Tue, Oct 18, 2016 at 01:53:58PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded:
> > This code is not correct for git master
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  doc/examples/demuxing_decoding.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c
> > index 49fb6af..b1a216a 100644
> > --- a/doc/examples/demuxing_decoding.c
> > +++ b/doc/examples/demuxing_decoding.c
> > @@ -93,10 +93,9 @@ static int decode_packet(int *got_frame, int cached)
> >                  return -1;
> >              }
> >  
> > -            printf("video_frame%s n:%d coded_n:%d pts:%s\n",
> > +            printf("video_frame%s n:%d coded_n:%d\n",
> >                     cached ? "(cached)" : "",
> > -                   video_frame_count++, frame->coded_picture_number,
> > -                   av_ts2timestr(frame->pts, &video_dec_ctx->time_base));
> > +                   video_frame_count++, frame->coded_picture_number);
> >  
> >              /* copy decoded frame to destination buffer:
> >               * this is required since rawvideo expects non aligned data */
> 
> Considering it was never so useful (it was mostly set to NOPTS), LGTM.

applied

thx

[...]
diff mbox

Patch

diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c
index 49fb6af..b1a216a 100644
--- a/doc/examples/demuxing_decoding.c
+++ b/doc/examples/demuxing_decoding.c
@@ -93,10 +93,9 @@  static int decode_packet(int *got_frame, int cached)
                 return -1;
             }
 
-            printf("video_frame%s n:%d coded_n:%d pts:%s\n",
+            printf("video_frame%s n:%d coded_n:%d\n",
                    cached ? "(cached)" : "",
-                   video_frame_count++, frame->coded_picture_number,
-                   av_ts2timestr(frame->pts, &video_dec_ctx->time_base));
+                   video_frame_count++, frame->coded_picture_number);
 
             /* copy decoded frame to destination buffer:
              * this is required since rawvideo expects non aligned data */