diff mbox

[FFmpeg-devel] swresample/resample: fix return value of build_filter

Message ID 1476775069-6722-1-git-send-email-mfcc64@gmail.com
State Accepted
Commit acd74f92009df648a6bf4eb9513b38c20d422aeb
Headers show

Commit Message

Muhammad Faiz Oct. 18, 2016, 7:17 a.m. UTC 
return AVERROR code on error

Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
---
 libswresample/resample.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer Oct. 18, 2016, 2:14 p.m. UTC | #1 
On Tue, Oct 18, 2016 at 02:17:49PM +0700, Muhammad Faiz wrote:
> return AVERROR code on error
> 
> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
> ---
>  libswresample/resample.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

LGTM

thx

[...]
Muhammad Faiz Oct. 18, 2016, 3:39 p.m. UTC | #2 
On 10/18/16, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Tue, Oct 18, 2016 at 02:17:49PM +0700, Muhammad Faiz wrote:
>> return AVERROR code on error
>>
>> Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
>> ---
>>  libswresample/resample.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> LGTM
>
> thx
>

applied

thanks
diff mbox

Patch

diff --git a/libswresample/resample.c b/libswresample/resample.c
index b834248..8635bf1 100644
--- a/libswresample/resample.c
+++ b/libswresample/resample.c
@@ -149,6 +149,7 @@  static int build_filter(ResampleContext *c, void *filter, double factor, int tap
     double *tab = av_malloc_array(tap_count+1,  sizeof(*tab));
     double *sin_lut = av_malloc_array(ph_nb, sizeof(*sin_lut));
     const int center= (tap_count-1)/2;
+    int ret = AVERROR(ENOMEM);
 
     if (!tab || !sin_lut)
         goto fail;
@@ -292,10 +293,11 @@  static int build_filter(ResampleContext *c, void *filter, double factor, int tap
     }
 #endif
 
+    ret = 0;
 fail:
     av_free(tab);
     av_free(sin_lut);
-    return 0;
+    return ret;
 }
 
 static ResampleContext *resample_init(ResampleContext *c, int out_rate, int in_rate, int filter_size, int phase_shift, int linear,