diff mbox

[FFmpeg-devel] configure: Default to clang for Android

Message ID CAB0OVGrcrU4nme+rvUaER3z_wxknAse+H14TZm7W6SqZ_VrpQQ@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Dec. 7, 2018, 2:06 a.m. UTC 
Hi!

I believe the Android documentation indicates that gcc will be removed
from ndk. Attached patch changes the default to "clang" for
--target-os=android.

Now with patch.

Please comment, Carl Eugen

Comments

Carl Eugen Hoyos Dec. 10, 2018, 2:13 a.m. UTC | #1 
2018-12-07 3:06 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:

> I believe the Android documentation indicates that gcc will be
> removed from ndk. Attached patch changes the default to
> "clang" for --target-os=android.
>
> Now with patch.

Any comments?

Carl Eugen
Carl Eugen Hoyos Dec. 10, 2018, 11:53 p.m. UTC | #2 
2018-12-10 3:13 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> 2018-12-07 3:06 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>
>> I believe the Android documentation indicates that gcc will be
>> removed from ndk. Attached patch changes the default to
>> "clang" for --target-os=android.
>>
>> Now with patch.
>
> Any comments?

I'll push this if there are no objections.

Carl Eugen
Carl Eugen Hoyos Dec. 17, 2018, 12:49 a.m. UTC | #3 
2018-12-07 3:06 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:

> I believe the Android documentation indicates that gcc will be removed
> from ndk. Attached patch changes the default to "clang" for
> --target-os=android.
>
> Now with patch.

Patch applied.

Carl Eugen
diff mbox

Patch

From 9c63579a1c0538f3c5f3dd8189eaedf28e87ce49 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Fri, 7 Dec 2018 00:11:17 +0100
Subject: [PATCH] configure: Use "clang" as cc_default for Android.

---
 configure |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 642c13d..6488c63 100755
--- a/configure
+++ b/configure
@@ -4129,6 +4129,11 @@  if test -n "$cross_prefix"; then
     enable cross_compile
 fi
 
+set_default target_os
+if test "$target_os" = android; then
+    cc_default="clang"
+fi
+
 ar_default="${cross_prefix}${ar_default}"
 cc_default="${cross_prefix}${cc_default}"
 cxx_default="${cross_prefix}${cxx_default}"
@@ -4145,7 +4150,7 @@  windres_default="${cross_prefix}${windres_default}"
 sysinclude_default="${sysroot}/usr/include"
 
 set_default arch cc cxx doxygen pkg_config ranlib strip sysinclude \
-    target_exec target_os x86asmexe nvcc
+    target_exec x86asmexe nvcc
 enabled cross_compile || host_cc_default=$cc
 set_default host_cc
 
-- 
1.7.10.4