diff mbox

[FFmpeg-devel] lavfi/signalstats: Cast AV_RN16() output to int.

Message ID CAB0OVGowO=ncSy6904GSMuhKsx7_ztQ7n0NC7FTpcAN9bh=jMg@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Dec. 11, 2018, 2:16 a.m. UTC 
Hi!

I suspect attached patch fixes a bug on some platforms, silences a warning.

Please comment, Carl Eugen

Comments

Carl Eugen Hoyos Dec. 12, 2018, 10:44 p.m. UTC | #1 
2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:

> I suspect attached patch fixes a bug on some platforms, silences a warning.
>
> Please comment, Carl Eugen

Ping.

Carl Eugen
Paul B Mahol Dec. 12, 2018, 10:45 p.m. UTC | #2 
On 12/12/18, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>
>> I suspect attached patch fixes a bug on some platforms, silences a
>> warning.
>>
>> Please comment, Carl Eugen
>
> Ping.

lgtm
Carl Eugen Hoyos Dec. 12, 2018, 10:55 p.m. UTC | #3 
2018-12-12 23:45 GMT+01:00, Paul B Mahol <onemda@gmail.com>:
> On 12/12/18, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>> 2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>>
>>> I suspect attached patch fixes a bug on some platforms, silences a
>>> warning.
>>>
>>> Please comment, Carl Eugen
>>
>> Ping.
>
> lgtm

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

From cfc9e3fd1e24d108581bad096a4de987069b2c49 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Tue, 11 Dec 2018 03:12:49 +0100
Subject: [PATCH] lavfi/signalstats: Cast the return value of AV_RN16() to
 int.

It is unsigned at least on arm, fixes the following warnings:
libavfilter/vf_signalstats.c:833:21: warning: taking the absolute value of unsigned type 'unsigned int' has no effect
            dify += abs(yuv - AV_RN16(prev->data[0] + pw + i * 2));
---
 libavfilter/vf_signalstats.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c
index 298881b..2b8c0de 100644
--- a/libavfilter/vf_signalstats.c
+++ b/libavfilter/vf_signalstats.c
@@ -830,7 +830,7 @@  static int filter_frame16(AVFilterLink *link, AVFrame *in)
 
             masky |= yuv;
             histy[yuv]++;
-            dify += abs(yuv - AV_RN16(prev->data[0] + pw + i * 2));
+            dify += abs(yuv - (int)AV_RN16(prev->data[0] + pw + i * 2));
         }
         w  += in->linesize[0];
         pw += prev->linesize[0];
@@ -848,9 +848,9 @@  static int filter_frame16(AVFilterLink *link, AVFrame *in)
             masku |= yuvu;
             maskv |= yuvv;
             histu[yuvu]++;
-            difu += abs(yuvu - AV_RN16(prev->data[1] + cpw + i * 2));
+            difu += abs(yuvu - (int)AV_RN16(prev->data[1] + cpw + i * 2));
             histv[yuvv]++;
-            difv += abs(yuvv - AV_RN16(prev->data[2] + cpw + i * 2));
+            difv += abs(yuvv - (int)AV_RN16(prev->data[2] + cpw + i * 2));
 
             histsat[p_sat[i]]++;
             histhue[((int16_t*)p_hue)[i]]++;
-- 
1.7.10.4