diff mbox

[FFmpeg-devel] tests/fate/filter-video: increase fuzz for fate-filter-refcmp-psnr-rgb

Message ID CAB0OVGq0qzQSGHG3ibmEkchXCoV+xe8jDUQHcQNqm5jg8R0oDg@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Carl Eugen Hoyos Dec. 6, 2018, 9:41 p.m. UTC 
2018-12-06 22:19 GMT+01:00, Michael Niedermayer <michael@niedermayer.cc>:
> Fixes: test failure on powerpc
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  tests/fate/filter-video.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 8bbdc04896..1042e96e54 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -782,7 +782,7 @@ fate-filter-meta-4560-rotate0: CMD = framecrc -flags
> +bitexact -c:a aac_fixed -i
>  REFCMP_DEPS = FFMPEG LAVFI_INDEV TESTSRC2_FILTER AVGBLUR_FILTER
> METADATA_FILTER
>
>  FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) +=
> fate-filter-refcmp-psnr-rgb
> -fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.001
> +fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.002

This is not needed on any ppc system where I tested recently including
Power7 Linux BE and Power8 Linux LE and aix BE.
I cannot test Apple G3 Linux atm.

The aix systems all only fail with afade:

Carl Eugen

Comments

Carl Eugen Hoyos Dec. 6, 2018, 9:42 p.m. UTC | #1 
2018-12-06 22:41 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> 2018-12-06 22:19 GMT+01:00, Michael Niedermayer <michael@niedermayer.cc>:
>> Fixes: test failure on powerpc
>>
>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>> ---
>>  tests/fate/filter-video.mak | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
>> index 8bbdc04896..1042e96e54 100644
>> --- a/tests/fate/filter-video.mak
>> +++ b/tests/fate/filter-video.mak
>> @@ -782,7 +782,7 @@ fate-filter-meta-4560-rotate0: CMD = framecrc -flags
>> +bitexact -c:a aac_fixed -i
>>  REFCMP_DEPS = FFMPEG LAVFI_INDEV TESTSRC2_FILTER AVGBLUR_FILTER
>> METADATA_FILTER
>>
>>  FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) +=
>> fate-filter-refcmp-psnr-rgb
>> -fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.001
>> +fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.002
>
> This is not needed on any ppc system where I tested recently including
> Power7 Linux BE and Power8 Linux LE and aix BE.

This is of course not meant to stop this patch, I am just wondering how
to reproduce.

Carl Eugen
Michael Niedermayer Dec. 7, 2018, 12:01 a.m. UTC | #2 
On Thu, Dec 06, 2018 at 10:42:24PM +0100, Carl Eugen Hoyos wrote:
> 2018-12-06 22:41 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> > 2018-12-06 22:19 GMT+01:00, Michael Niedermayer <michael@niedermayer.cc>:
> >> Fixes: test failure on powerpc
> >>
> >> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> >> ---
> >>  tests/fate/filter-video.mak | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> >> index 8bbdc04896..1042e96e54 100644
> >> --- a/tests/fate/filter-video.mak
> >> +++ b/tests/fate/filter-video.mak
> >> @@ -782,7 +782,7 @@ fate-filter-meta-4560-rotate0: CMD = framecrc -flags
> >> +bitexact -c:a aac_fixed -i
> >>  REFCMP_DEPS = FFMPEG LAVFI_INDEV TESTSRC2_FILTER AVGBLUR_FILTER
> >> METADATA_FILTER
> >>
> >>  FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) +=
> >> fate-filter-refcmp-psnr-rgb
> >> -fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.001
> >> +fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.002
> >
> > This is not needed on any ppc system where I tested recently including
> > Power7 Linux BE and Power8 Linux LE and aix BE.
> 
> This is of course not meant to stop this patch, I am just wondering how
> to reproduce.

Yes, let me start from mostly the begin

configure --assert-level=2 --target-exec='qemu-201812/build/ppc64abi32-linux-user/qemu-ppc64abi32 -L /usr/powerpc-linux-gnu/' --cpu=power8 --samples=fate-suite/ --enable-gpl --cross-prefix=/usr/powerpc-linux-gnu/bin/ --cc='ccache powerpc-linux-gnu-gcc-4.8' --arch=ppc --target-os=linux --enable-cross-compile --disable-iconv --disable-pthreads

make -k  -j12  fate-filter-pp2 fate-filter-pp3 fate-wavpack-cuesheet  fate-lossless-monkeysaudio-399 fate-eval fate-parseutils 
make: *** [fate-parseutils] Error 1
make: *** [fate-eval] Error 1
make: *** [fate-wavpack-cuesheet] Error 1
make: *** [fate-filter-pp3] Error 1
make: *** [fate-filter-pp2] Error 1

(fate-lossless-monkeysaudio-399 seems to have stoped failing, maybe because 
 --cpu is different than when i tested this previously)

Oddly adding --extra-cflags=-funsafe-math-optimizations
fixes 3 of these, only these remain
make: *** [fate-parseutils] Error 1
make: *** [fate-eval] Error 1
And not just that but the failures in fate-eval are significantly fewer

but it added these failures:
make: *** [fate-filter-tremolo] Error 1
make: *** [fate-filter-refcmp-psnr-rgb] Error 1

and slightly increasing the fuzz factor eliminated the second which is
what the patch does
I think the patch makes sense independant of this long story as it allows
one fate test to pass with some compiler flags

thx
Michael Niedermayer Dec. 19, 2018, 10:20 a.m. UTC | #3 
On Fri, Dec 07, 2018 at 01:01:09AM +0100, Michael Niedermayer wrote:
> On Thu, Dec 06, 2018 at 10:42:24PM +0100, Carl Eugen Hoyos wrote:
> > 2018-12-06 22:41 GMT+01:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> > > 2018-12-06 22:19 GMT+01:00, Michael Niedermayer <michael@niedermayer.cc>:
> > >> Fixes: test failure on powerpc
> > >>
> > >> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > >> ---
> > >>  tests/fate/filter-video.mak | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > >> index 8bbdc04896..1042e96e54 100644
> > >> --- a/tests/fate/filter-video.mak
> > >> +++ b/tests/fate/filter-video.mak
> > >> @@ -782,7 +782,7 @@ fate-filter-meta-4560-rotate0: CMD = framecrc -flags
> > >> +bitexact -c:a aac_fixed -i
> > >>  REFCMP_DEPS = FFMPEG LAVFI_INDEV TESTSRC2_FILTER AVGBLUR_FILTER
> > >> METADATA_FILTER
> > >>
> > >>  FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) +=
> > >> fate-filter-refcmp-psnr-rgb
> > >> -fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.001
> > >> +fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.002
> > >
> > > This is not needed on any ppc system where I tested recently including
> > > Power7 Linux BE and Power8 Linux LE and aix BE.
> > 
> > This is of course not meant to stop this patch, I am just wondering how
> > to reproduce.
> 
> Yes, let me start from mostly the begin
> 
> configure --assert-level=2 --target-exec='qemu-201812/build/ppc64abi32-linux-user/qemu-ppc64abi32 -L /usr/powerpc-linux-gnu/' --cpu=power8 --samples=fate-suite/ --enable-gpl --cross-prefix=/usr/powerpc-linux-gnu/bin/ --cc='ccache powerpc-linux-gnu-gcc-4.8' --arch=ppc --target-os=linux --enable-cross-compile --disable-iconv --disable-pthreads
> 
> make -k  -j12  fate-filter-pp2 fate-filter-pp3 fate-wavpack-cuesheet  fate-lossless-monkeysaudio-399 fate-eval fate-parseutils 
> make: *** [fate-parseutils] Error 1
> make: *** [fate-eval] Error 1
> make: *** [fate-wavpack-cuesheet] Error 1
> make: *** [fate-filter-pp3] Error 1
> make: *** [fate-filter-pp2] Error 1
> 
> (fate-lossless-monkeysaudio-399 seems to have stoped failing, maybe because 
>  --cpu is different than when i tested this previously)
> 
> Oddly adding --extra-cflags=-funsafe-math-optimizations
> fixes 3 of these, only these remain
> make: *** [fate-parseutils] Error 1
> make: *** [fate-eval] Error 1
> And not just that but the failures in fate-eval are significantly fewer
> 
> but it added these failures:
> make: *** [fate-filter-tremolo] Error 1
> make: *** [fate-filter-refcmp-psnr-rgb] Error 1
> 
> and slightly increasing the fuzz factor eliminated the second which is
> what the patch does
> I think the patch makes sense independant of this long story as it allows
> one fate test to pass with some compiler flags

will apply

[...]
diff mbox

Patch

--- tests/ref/fate/filter-afade-qsin	2018-11-21 11:34:44.481910412 +0000
+++ tests/data/fate/filter-afade-qsin	2018-12-04 17:21:25.941910623 +0000
@@ -32,7 +32,7 @@ 
 0,      25600,      25600,     1024,     4096, 0x0c991178
 0,      26624,      26624,     1024,     4096, 0x7e69f3db
 0,      27648,      27648,     1024,     4096, 0x1c72f871
-0,      28672,      28672,     1024,     4096, 0xb51af385
+0,      28672,      28672,     1024,     4096, 0xabdcf383
 0,      29696,      29696,     1024,     4096, 0xc8cb0038
 0,      30720,      30720,     1024,     4096, 0xc3760a10
 0,      31744,      31744,     1024,     4096, 0x77baef51