| Message ID | 1472603168-3871-3-git-send-email-qyot27@gmail.com |
|---|---|
| State | Accepted |
| Commit | bf14393635559640f10001fa6af46130cb35fa31 |
| Delegated to: | Stephen Hutchinson |
| Headers | show |
On 8/30/2016 8:26 PM, Stephen Hutchinson wrote: > --- > libavformat/avisynth.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c > index 1fe8e08..1acc44f 100644 > --- a/libavformat/avisynth.c > +++ b/libavformat/avisynth.c > @@ -690,8 +690,10 @@ static int avisynth_read_packet_video(AVFormatContext *s, AVPacket *pkt, > #ifdef USING_AVISYNTH > /* Flip Planar RGB video. */ > if (avsplus && (avs_library.avs_is_planar_rgb(avs->vi) || > - avs_library.avs_is_planar_rgba(avs->vi))) > + avs_library.avs_is_planar_rgba(avs->vi))) { > + src_p = src_p + (planeheight - 1) * pitch; > pitch = -pitch; > + } > #endif > > avs_library.avs_bit_blt(avs->env, dst_p, rowsize, src_p, pitch, > Ping.
2016-09-27 6:45 GMT+02:00 Stephen Hutchinson <qyot27@gmail.com>:
> Ping.
Consider sending your public key to Michael, you maintain this code.
Carl Eugen
On 8/30/2016 8:26 PM, Stephen Hutchinson wrote: > --- > libavformat/avisynth.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c > index 1fe8e08..1acc44f 100644 > --- a/libavformat/avisynth.c > +++ b/libavformat/avisynth.c > @@ -690,8 +690,10 @@ static int avisynth_read_packet_video(AVFormatContext *s, AVPacket *pkt, > #ifdef USING_AVISYNTH > /* Flip Planar RGB video. */ > if (avsplus && (avs_library.avs_is_planar_rgb(avs->vi) || > - avs_library.avs_is_planar_rgba(avs->vi))) > + avs_library.avs_is_planar_rgba(avs->vi))) { > + src_p = src_p + (planeheight - 1) * pitch; > pitch = -pitch; > + } > #endif > > avs_library.avs_bit_blt(avs->env, dst_p, rowsize, src_p, pitch, > Ping attempt #2. As I mentioned, this needs to go in before 3.2 is split off, and there haven't been any objections raised in the three weeks since the patchwork stuff was suggested.
2016-09-27 9:15 GMT+02:00 Carl Eugen Hoyos <ceffmpeg@gmail.com>: > 2016-09-27 6:45 GMT+02:00 Stephen Hutchinson <qyot27@gmail.com>: > >> Ping. > > Consider sending your public key to Michael, you maintain this code. Ping. Carl Eugen
On 10/21/2016 10:30 PM, Carl Eugen Hoyos wrote: > 2016-09-27 9:15 GMT+02:00 Carl Eugen Hoyos <ceffmpeg@gmail.com>: >> 2016-09-27 6:45 GMT+02:00 Stephen Hutchinson <qyot27@gmail.com>: >> >>> Ping. >> >> Consider sending your public key to Michael, you maintain this code. > > Ping. > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Okay, we're getting into a discussion about public keys. The only thing mentioned to me concerning this when being made maintainer was that it was for push rights. I don't need or want push rights because any future patches to the AviSynth demuxer will be on the smaller side - if not smallest, like the patch in question here - and very few and far between (months or even years at the level of maturity the demuxer has now*), making it pointless for me to have that ability. And while it may be more likely for me to submit patches to things I don't maintain in that span of time, I would be even stricter about it than the docs are and refuse to push patches I submit to areas I don't maintain. *I can prognosticate a little here: the only two conceivable changes that may be needed in the future are in the event of AviSynth+ gaining Linux/OSX support and finally displacing AvxSynth (requires getting rid of some ifdefs and changing the lib name AVISYNTH_LIB points to) and the off chance that the Windows builds of AviSynth+ might eventually do something useful with UTF-8, in which case the ifdef for that would need to be altered or removed. Other than some hypothetical grand API shift on our side (the fixing of which is not in my wheelhouse; I'd merely be testing and approving the patch(es) which update(s) the demuxer to use said newer APIs), that's all. The use of a public key to verify individual commits reads to me, again, as though it only applies to being able to verify commits pushed to a repository by those with push rights.
diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 1fe8e08..1acc44f 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -690,8 +690,10 @@ static int avisynth_read_packet_video(AVFormatContext *s, AVPacket *pkt, #ifdef USING_AVISYNTH /* Flip Planar RGB video. */ if (avsplus && (avs_library.avs_is_planar_rgb(avs->vi) || - avs_library.avs_is_planar_rgba(avs->vi))) + avs_library.avs_is_planar_rgba(avs->vi))) { + src_p = src_p + (planeheight - 1) * pitch; pitch = -pitch; + } #endif avs_library.avs_bit_blt(avs->env, dst_p, rowsize, src_p, pitch,