| Message ID | 201610251258.23644.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Commit | 134233972e7961d9a41c67d27da505e459d5edfa |
| Headers | show |
On 10/25/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: > Hi! > > Attached patch may fix an issue reported on the gusari forum. > > Please comment, Carl Eugen > Please clearly explain what is actual problem and what this patch actually solves. I do not have time of all existence to search forums on internet.
2016-10-25 13:01 GMT+02:00 Paul B Mahol <onemda@gmail.com>: > On 10/25/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >> Hi! >> >> Attached patch may fix an issue reported on the gusari forum. > Please clearly explain what is actual problem and what this patch > actually solves. I do not have time of all existence to search forums > on internet. Currently, ff_put_bmp_header() always writes "24" as biBitCount for utvideo because bits_per_coded_sample is never set by the encoder. Attached patch fixes the value of bits_per_coded_sample for rgba utvideo. (I do not know if the patch fixes an actual issue reported by a user and I cannot test.) Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 10/25/16, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > 2016-10-25 13:01 GMT+02:00 Paul B Mahol <onemda@gmail.com>: >> On 10/25/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >>> Hi! >>> >>> Attached patch may fix an issue reported on the gusari forum. > >> Please clearly explain what is actual problem and what this patch >> actually solves. I do not have time of all existence to search forums >> on internet. > > Currently, ff_put_bmp_header() always writes "24" as biBitCount > for utvideo because bits_per_coded_sample is never set by the > encoder. Attached patch fixes the value of bits_per_coded_sample > for rgba utvideo. > (I do not know if the patch fixes an actual issue reported by a > user and I cannot test.) > > Carl Eugen > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Please put above explanation in commit log. Patch lgtm. Have a nice day.
2016-10-25 13:42 GMT+02:00 Paul B Mahol <onemda@gmail.com>: > On 10/25/16, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: >> 2016-10-25 13:01 GMT+02:00 Paul B Mahol <onemda@gmail.com>: >>> On 10/25/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >>>> Attached patch may fix an issue reported on the gusari forum. >> >>> Please clearly explain what is actual problem and what this patch >>> actually solves. I do not have time of all existence to search forums >>> on internet. >> >> Currently, ff_put_bmp_header() always writes "24" as biBitCount >> for utvideo because bits_per_coded_sample is never set by the >> encoder. Attached patch fixes the value of bits_per_coded_sample >> for rgba utvideo. >> (I do not know if the patch fixes an actual issue reported by a >> user and I cannot test.) > Please put above explanation in commit log. Patch lgtm. Done and applied. > Have a nice day. You too! Thank you, Carl Eugen
diff --git a/libavcodec/utvideoenc.c b/libavcodec/utvideoenc.c index 8ffc263..6082943 100644 --- a/libavcodec/utvideoenc.c +++ b/libavcodec/utvideoenc.c @@ -77,6 +77,7 @@ static av_cold int utvideo_encode_init(AVCodecContext *avctx) c->planes = 4; avctx->codec_tag = MKTAG('U', 'L', 'R', 'A'); original_format = UTVIDEO_RGBA; + avctx->bits_per_coded_sample = 32; break; case AV_PIX_FMT_YUV420P: if (avctx->width & 1 || avctx->height & 1) {
Hi! Attached patch may fix an issue reported on the gusari forum. Please comment, Carl Eugen From 20d2713bc1d4997a03bde52afd4192bbb48d3bb8 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Tue, 25 Oct 2016 12:55:54 +0200 Subject: [PATCH] lavc/utvideoenc: Set bits_per_coded_sample for rgba input. Allow to write correct biBitCount into the BITMAPINFOHEADER. --- libavcodec/utvideoenc.c | 1 + 1 file changed, 1 insertion(+)