diff mbox

[FFmpeg-devel,V1,2/2] lavf: bump version/add Changelog entry when cleanup applehttp

Message ID 1555394232-29837-2-git-send-email-mypopydev@gmail.com
State New
Headers show

Commit Message

Jun Zhao April 16, 2019, 5:57 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
the version bump and Changelog entry.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 Changelog             |    1 +
 libavformat/version.h |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

Comments

Paul B Mahol April 16, 2019, 8:10 a.m. UTC | #1 
On 4/16/19, Jun Zhao <mypopydev@gmail.com> wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
>
> commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
> the version bump and Changelog entry.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  Changelog             |    1 +
>  libavformat/version.h |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Changelog b/Changelog
> index 5b2b1e5..2930471 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -24,6 +24,7 @@ version <next>:
>  - KUX demuxer
>  - AV1 frame split bitstream filter
>  - lscr decoder
> +- cleanup applehttp in hls demuxer


No.


>
>
>  version 4.1:
> diff --git a/libavformat/version.h b/libavformat/version.h
> index d57c151..150a72e 100644
> --- a/libavformat/version.h
> +++ b/libavformat/version.h
> @@ -33,7 +33,7 @@
>  // Also please add any ticket numbers that you believe might be affected
> here
>  #define LIBAVFORMAT_VERSION_MAJOR  58
>  #define LIBAVFORMAT_VERSION_MINOR  27
> -#define LIBAVFORMAT_VERSION_MICRO 102
> +#define LIBAVFORMAT_VERSION_MICRO 103
>
>  #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \
>                                                 LIBAVFORMAT_VERSION_MINOR, \
> --
> 1.7.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Hendrik Leppkes April 16, 2019, 8:35 a.m. UTC | #2 
On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev@gmail.com> wrote:
>
> From: Jun Zhao <barryjzhao@tencent.com>
>
> commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
> the version bump and Changelog entry.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  Changelog             |    1 +
>  libavformat/version.h |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Changelog b/Changelog
> index 5b2b1e5..2930471 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -24,6 +24,7 @@ version <next>:
>  - KUX demuxer
>  - AV1 frame split bitstream filter
>  - lscr decoder
> +- cleanup applehttp in hls demuxer
>

If you read the other changelog entries, does this seem like matching
the pattern in there? :)
ChangeLog is for end-users, for changes that developers should care
about, there is APIchanges.

- Hendrik
Jun Zhao April 16, 2019, 8:52 a.m. UTC | #3 
On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>
> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev@gmail.com> wrote:
> >
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
> > the version bump and Changelog entry.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  Changelog             |    1 +
> >  libavformat/version.h |    2 +-
> >  2 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/Changelog b/Changelog
> > index 5b2b1e5..2930471 100644
> > --- a/Changelog
> > +++ b/Changelog
> > @@ -24,6 +24,7 @@ version <next>:
> >  - KUX demuxer
> >  - AV1 frame split bitstream filter
> >  - lscr decoder
> > +- cleanup applehttp in hls demuxer
> >
>
> If you read the other changelog entries, does this seem like matching
> the pattern in there? :)
> ChangeLog is for end-users, for changes that developers should care
> about, there is APIchanges.
>
> - Hendrik
Thanks the comments, Hendrik, will update APIChanges
Carl Eugen Hoyos April 16, 2019, 8:58 a.m. UTC | #4 
2019-04-16 10:52 GMT+02:00, mypopy@gmail.com <mypopy@gmail.com>:
> On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>>
>> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev@gmail.com> wrote:
>> >
>> > From: Jun Zhao <barryjzhao@tencent.com>
>> >
>> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
>> > the version bump and Changelog entry.
>> >
>> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
>> > ---
>> >  Changelog             |    1 +
>> >  libavformat/version.h |    2 +-
>> >  2 files changed, 2 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/Changelog b/Changelog
>> > index 5b2b1e5..2930471 100644
>> > --- a/Changelog
>> > +++ b/Changelog
>> > @@ -24,6 +24,7 @@ version <next>:
>> >  - KUX demuxer
>> >  - AV1 frame split bitstream filter
>> >  - lscr decoder
>> > +- cleanup applehttp in hls demuxer
>> >
>>
>> If you read the other changelog entries, does this seem like matching
>> the pattern in there? :)
>> ChangeLog is for end-users, for changes that developers should care
>> about, there is APIchanges.

Without a version bump?

> Thanks the comments, Hendrik, will update APIChanges

Please make "clean up" "rename applehts demuxer".

Carl Eugen
Hendrik Leppkes April 16, 2019, 9:32 a.m. UTC | #5 
On Tue, Apr 16, 2019 at 10:58 AM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
> 2019-04-16 10:52 GMT+02:00, mypopy@gmail.com <mypopy@gmail.com>:
> > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
> >>
> >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev@gmail.com> wrote:
> >> >
> >> > From: Jun Zhao <barryjzhao@tencent.com>
> >> >
> >> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
> >> > the version bump and Changelog entry.
> >> >
> >> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> >> > ---
> >> >  Changelog             |    1 +
> >> >  libavformat/version.h |    2 +-
> >> >  2 files changed, 2 insertions(+), 1 deletions(-)
> >> >
> >> > diff --git a/Changelog b/Changelog
> >> > index 5b2b1e5..2930471 100644
> >> > --- a/Changelog
> >> > +++ b/Changelog
> >> > @@ -24,6 +24,7 @@ version <next>:
> >> >  - KUX demuxer
> >> >  - AV1 frame split bitstream filter
> >> >  - lscr decoder
> >> > +- cleanup applehttp in hls demuxer
> >> >
> >>
> >> If you read the other changelog entries, does this seem like matching
> >> the pattern in there? :)
> >> ChangeLog is for end-users, for changes that developers should care
> >> about, there is APIchanges.
>
> Without a version bump?
>

Well thats no reason to put it into ChangeLog regardless, because it
just doesn't belong in there.
This is runtime API, not compile-time API anyway, so someone needing
this string for some reason and wanting to support all versions will
have to check both strings regardless of version information,

- Hendrik
Carl Eugen Hoyos April 16, 2019, 9:59 a.m. UTC | #6 
2019-04-16 11:32 GMT+02:00, Hendrik Leppkes <h.leppkes@gmail.com>:
> On Tue, Apr 16, 2019 at 10:58 AM Carl Eugen Hoyos <ceffmpeg@gmail.com>
> wrote:
>>
>> 2019-04-16 10:52 GMT+02:00, mypopy@gmail.com <mypopy@gmail.com>:
>> > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes <h.leppkes@gmail.com>
>> > wrote:
>> >>
>> >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev@gmail.com> wrote:
>> >> >
>> >> > From: Jun Zhao <barryjzhao@tencent.com>
>> >> >
>> >> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
>> >> > the version bump and Changelog entry.
>> >> >
>> >> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
>> >> > ---
>> >> >  Changelog             |    1 +
>> >> >  libavformat/version.h |    2 +-
>> >> >  2 files changed, 2 insertions(+), 1 deletions(-)
>> >> >
>> >> > diff --git a/Changelog b/Changelog
>> >> > index 5b2b1e5..2930471 100644
>> >> > --- a/Changelog
>> >> > +++ b/Changelog
>> >> > @@ -24,6 +24,7 @@ version <next>:
>> >> >  - KUX demuxer
>> >> >  - AV1 frame split bitstream filter
>> >> >  - lscr decoder
>> >> > +- cleanup applehttp in hls demuxer
>> >> >
>> >>
>> >> If you read the other changelog entries, does this seem like matching
>> >> the pattern in there? :)
>> >> ChangeLog is for end-users, for changes that developers should care
>> >> about, there is APIchanges.
>>
>> Without a version bump?
>>
>
> Well thats no reason to put it into ChangeLog regardless, because it
> just doesn't belong in there.
> This is runtime API, not compile-time API anyway, so someone needing
> this string for some reason and wanting to support all versions will
> have to check both strings regardless of version information,

All true!

Carl Eugen
diff mbox

Patch

diff --git a/Changelog b/Changelog
index 5b2b1e5..2930471 100644
--- a/Changelog
+++ b/Changelog
@@ -24,6 +24,7 @@  version <next>:
 - KUX demuxer
 - AV1 frame split bitstream filter
 - lscr decoder
+- cleanup applehttp in hls demuxer
 
 
 version 4.1:
diff --git a/libavformat/version.h b/libavformat/version.h
index d57c151..150a72e 100644
--- a/libavformat/version.h
+++ b/libavformat/version.h
@@ -33,7 +33,7 @@ 
 // Also please add any ticket numbers that you believe might be affected here
 #define LIBAVFORMAT_VERSION_MAJOR  58
 #define LIBAVFORMAT_VERSION_MINOR  27
-#define LIBAVFORMAT_VERSION_MICRO 102
+#define LIBAVFORMAT_VERSION_MICRO 103
 
 #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \
                                                LIBAVFORMAT_VERSION_MINOR, \