diff mbox

[FFmpeg-devel,MSVC,toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

Message ID CAB0OVGpjLV=FVJgyEJOrRx87Twz-vwr-hk95c4_BWEEY6QWQ5g@mail.gmail.com
State New
Headers show

Commit Message

Carl Eugen Hoyos April 23, 2019, 11:38 p.m. UTC 
2017-12-29 13:16 GMT+01:00, Cyber Sinh <cyber.sinh@free.fr>:
> Sorry for the diff instead of regular git patch. Here is the patch.

Only saw this today after wondering
why nobody tried using wsl before...

How can I test this part of the patch?
In which situation is it supposed to make a difference?


Carl Eugen


>
>
> -----Message d'origine-----
> De : ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] De la part de
> wm4
> Envoyé : vendredi 29 décembre 2017 12:54
> À : ffmpeg-devel@ffmpeg.org
> Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg
> with Linux bash on Windows (WSL)
>
> On Fri, 29 Dec 2017 10:44:21 +0100
> Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>
>> On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh <cyber.sinh@free.fr> wrote:
>> > The attached patch changes the configure script for FFmpeg (and
>> > associated shell scripts) to call MSVC tools including their
>> > extensions (cl.exe instead of cl for example). This is necessary,
>> > because WSL can automatically launch Windows processes from the
>> > Linux side but only if the process is in the path and includes the
>> > full name. Linux doesn't automatically append .exe and such to invoke a
>> > file.
>> >
>> >
>>
>> The attached file is corrupted. Please ensure its in git format-patch
>> format. As it is, I can't even read it at all.
>
> It's in UTF-16, and just a diff. Yeah, nobody can comfortably read it.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Comments

Timo Rothenpieler April 24, 2019, 10:20 a.m. UTC | #1 
On 24/04/2019 01:38, Carl Eugen Hoyos wrote:
> 2017-12-29 13:16 GMT+01:00, Cyber Sinh <cyber.sinh@free.fr>:
>> Sorry for the diff instead of regular git patch. Here is the patch.
> 
> Only saw this today after wondering
> why nobody tried using wsl before...

I'm using WSL since a while, but never bothered trying to setup MSVC 
with it.
Thomas Volkert April 24, 2019, 4:28 p.m. UTC | #2 
On 24.04.2019 12:20, Timo Rothenpieler wrote:
> On 24/04/2019 01:38, Carl Eugen Hoyos wrote:
>> 2017-12-29 13:16 GMT+01:00, Cyber Sinh <cyber.sinh@free.fr>:
>>> Sorry for the diff instead of regular git patch. Here is the patch.
>>
>> Only saw this today after wondering
>> why nobody tried using wsl before...
>
> I'm using WSL since a while, but never bothered trying to setup MSVC
> with it.

I'm also using WSL, but I don't use MSVC to compile FFmpeg, instead I
use mingw-w64. But this isn't a show stopper to have support for NVidia
CUDA, IntelQSV, AMD, libSRT, libmp3lame, openH264 or other features
under Windows.

Best regards,
Thomas.
diff mbox

Patch

diff --git a/compat/windows/mslink b/compat/windows/mslink
index 07b2b3e378..9b6b83c4ed 100755
--- a/compat/windows/mslink
+++ b/compat/windows/mslink
@@ -1,9 +1,9 @@ 
 #!/bin/sh

-LINK_EXE_PATH=$(dirname "$(command -v cl)")/link
+LINK_EXE_PATH=$(dirname "$(command -v cl.exe)")/link.exe
 if [ -x "$LINK_EXE_PATH" ]; then
     "$LINK_EXE_PATH" $@
 else


I will apply the makedef part that I just tested successfully.