| Message ID | 20190324202933.7288-1-qyot27@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 25-03-2019 01:59 AM, Stephen Hutchinson wrote: > It's been fixed both AviSynth+-side and locally. > --- > doc/general.texi | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/doc/general.texi b/doc/general.texi > index fe94c40386..6ec52962ff 100644 > --- a/doc/general.texi > +++ b/doc/general.texi > @@ -51,19 +51,6 @@ For Windows, supported AviSynth variants are > For Linux and OS X, the supported AviSynth variant is > @url{https://github.com/avxsynth/avxsynth, AvxSynth}. > > -@float NOTE > -There is currently a regression in AviSynth+'s @code{capi.h} header as of > -October 2016, which interferes with the ability for builds of FFmpeg to use > -MSVC-built binaries of AviSynth. Until this is resolved, you can make sure > -a known good version is installed by checking out a version from before > -the regression occurred: This would still be an issue for older versions. Maybe keep the note, but add a date and revision range for the affected versions. Gyan
On 3/28/2019 1:03 AM, Gyan wrote: > > > On 25-03-2019 01:59 AM, Stephen Hutchinson wrote: >> It's been fixed both AviSynth+-side and locally. >> --- >> doc/general.texi | 13 ------------- >> 1 file changed, 13 deletions(-) >> >> diff --git a/doc/general.texi b/doc/general.texi >> index fe94c40386..6ec52962ff 100644 >> --- a/doc/general.texi >> +++ b/doc/general.texi >> @@ -51,19 +51,6 @@ For Windows, supported AviSynth variants are >> For Linux and OS X, the supported AviSynth variant is >> @url{https://github.com/avxsynth/avxsynth, AvxSynth}. >> -@float NOTE >> -There is currently a regression in AviSynth+'s @code{capi.h} header >> as of >> -October 2016, which interferes with the ability for builds of FFmpeg >> to use >> -MSVC-built binaries of AviSynth. Until this is resolved, you can >> make sure >> -a known good version is installed by checking out a version from before >> -the regression occurred: > > This would still be an issue for older versions. Maybe keep the note, > but add a date and revision range for the affected versions. Older versions of what? FFmpeg relies only on the copies of the headers in compat/avisynth, and with the patch to update the headers¹, we move directly from unaffected version to unaffected version. The problem in the header doesn't actually affect AviSynth itself, it affects client programs that talk to it; the difference in behavior due to Windows' 32-bit calling conventions is explained in a new note in the patchset². That note about checking out the correct version of the header never actually mattered to FFmpeg, it was brought in from merging commits from Libav (which is still affected by this situation, because they don't provide copies of the right headers in compat/). ¹http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241503.html ²http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html
On 28-03-2019 05:19 PM, Stephen Hutchinson wrote: > On 3/28/2019 1:03 AM, Gyan wrote: >> >> >> On 25-03-2019 01:59 AM, Stephen Hutchinson wrote: >>> It's been fixed both AviSynth+-side and locally. >>> --- >>> doc/general.texi | 13 ------------- >>> 1 file changed, 13 deletions(-) >>> >>> diff --git a/doc/general.texi b/doc/general.texi >>> index fe94c40386..6ec52962ff 100644 >>> --- a/doc/general.texi >>> +++ b/doc/general.texi >>> @@ -51,19 +51,6 @@ For Windows, supported AviSynth variants are >>> For Linux and OS X, the supported AviSynth variant is >>> @url{https://github.com/avxsynth/avxsynth, AvxSynth}. >>> -@float NOTE >>> -There is currently a regression in AviSynth+'s @code{capi.h} header >>> as of >>> -October 2016, which interferes with the ability for builds of >>> FFmpeg to use >>> -MSVC-built binaries of AviSynth. Until this is resolved, you can >>> make sure >>> -a known good version is installed by checking out a version from >>> before >>> -the regression occurred: >> >> This would still be an issue for older versions. Maybe keep the note, >> but add a date and revision range for the affected versions. > > Older versions of what? FFmpeg relies only on the copies of the > headers in compat/avisynth, and with the patch to update the headers¹, > we move directly from unaffected version to unaffected version. Sorry, I assumed, based on the first line, that the validity of the note was dependent on AviSynth+ code, and hence its version. So, there is no permutation of ffmpeg master & avisynth+ that can lead to issues with MSVC builds? If so, LGTM. Gyan
On 3/28/2019 8:29 AM, Gyan wrote: > So, there is no permutation of ffmpeg master & avisynth+ that can lead > to issues with MSVC builds? If so, LGTM. > As a test, I tried building FFmpeg with MSVC (which I never do since I always cross-compile from Linux) and --enable-avisynth, and spotted a couple things in the patches I'll need to address, one of which might be better to squash into the header update patch.
On 3/28/2019 11:41 PM, Stephen Hutchinson wrote: > On 3/28/2019 8:29 AM, Gyan wrote: >> So, there is no permutation of ffmpeg master & avisynth+ that can >> lead to issues with MSVC builds? If so, LGTM. >> > As a test, I tried building FFmpeg with MSVC (which I never do since I > always cross-compile from Linux) and --enable-avisynth, and spotted a > couple things in the patches I'll need to address, one of which might > be better to squash into the header update patch. I've uploaded the amended 1st patch and added a 6th to deal with the issues I encountered when testing the 'build FFmpeg with MSVC' route. Since git send-email (or Gmail) screwed up the threading when I sent these the first time, this is the proper order: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241922.html <-fixed header update patch http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241502.html <-enabling the additional pix_fmts; nothing has changed on this one http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241507.html <-removing the header warning in the docs; nothing has changed on this one http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241504.html <-updating the project link to point to the AviSynth wiki page on AviSynth+; nothing has changed on this one http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html <-usage note about 32-bit GCC builds of AviSynth+ and the AVSC_WIN32_GCC32 switch; nothing has changed on this one http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241923.html <-new (well, technically old) patch to fix FARPROC warnings/build errors
On 3/30/2019 7:39 PM, Stephen Hutchinson wrote: > I've uploaded the amended 1st patch and added a 6th to deal with the > issues I encountered when testing the 'build FFmpeg with MSVC' route. > Since git send-email (or Gmail) screwed up the threading when I sent > these the first time, this is the proper order: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241922.html > <-fixed header update patch > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241502.html > <-enabling the additional pix_fmts; nothing has changed on this one > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241507.html > <-removing the header warning in the docs; nothing has changed on this > one > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241504.html > <-updating the project link to point to the AviSynth wiki page on > AviSynth+; nothing has changed on this one > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html > <-usage note about 32-bit GCC builds of AviSynth+ and the > AVSC_WIN32_GCC32 switch; nothing has changed on this one > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241923.html <-new > (well, technically old) patch to fix FARPROC warnings/build errors Ping #1 for five of the six patches.
On 02-05-2019 09:58 PM, Stephen Hutchinson wrote: > On 3/30/2019 7:39 PM, Stephen Hutchinson wrote: >> I've uploaded the amended 1st patch and added a 6th to deal with the >> issues I encountered when testing the 'build FFmpeg with MSVC' >> route. Since git send-email (or Gmail) screwed up the threading when >> I sent these the first time, this is the proper order: >> >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241922.html >> <-fixed header update patch >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241502.html >> <-enabling the additional pix_fmts; nothing has changed on this one >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241507.html >> <-removing the header warning in the docs; nothing has changed on >> this one >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241504.html >> <-updating the project link to point to the AviSynth wiki page on >> AviSynth+; nothing has changed on this one >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html >> <-usage note about 32-bit GCC builds of AviSynth+ and the >> AVSC_WIN32_GCC32 switch; nothing has changed on this one >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241923.html <-new >> (well, technically old) patch to fix FARPROC warnings/build errors > > Ping #1 for five of the six patches. Will apply #3, 4 and 5 with #6. #2 looks okay to me, but I'm not acquainted enowith Avisynth to ok it. But since you're the maintainer for avisynth.c, do you want me to push them? Gyan
On 5/3/2019 12:45 PM, Gyan wrote: > On 3/30/2019 7:39 PM, Stephen Hutchinson wrote: >>> I've uploaded the amended 1st patch and added a 6th to deal with the >>> issues I encountered when testing the 'build FFmpeg with MSVC' >>> route. Since git send-email (or Gmail) screwed up the threading >>> when I sent these the first time, this is the proper order: >>> >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241922.html >>> <-fixed header update patch >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241502.html >>> <-enabling the additional pix_fmts; nothing has changed on this one >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241507.html >>> <-removing the header warning in the docs; nothing has changed on >>> this one >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241504.html >>> <-updating the project link to point to the AviSynth wiki page on >>> AviSynth+; nothing has changed on this one >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html >>> <-usage note about 32-bit GCC builds of AviSynth+ and the >>> AVSC_WIN32_GCC32 switch; nothing has changed on this one >>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241923.html >>> <-new (well, technically old) patch to fix FARPROC warnings/build >>> errors > Will apply #3, 4 and 5 with #6. > > #2 looks okay to me, but I'm not acquainted enowith Avisynth to ok it. > But since you're the maintainer for avisynth.c, do you want me to push > them? > > Gyan Yes, go ahead and push all six patches. #2 is just a simple, direct mapping of those pix_fmts in AviSynth+ to the equivalent ones provided by FFmpeg/libavutil. The longer explanation about #2 is here: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241520.html You didn't mention #1, but #5 (and to a far, far, far lesser extent, #3) don't make much sense without #1 getting applied.
On 04-05-2019 06:17 AM, Stephen Hutchinson wrote: > On 5/3/2019 12:45 PM, Gyan wrote: >> On 3/30/2019 7:39 PM, Stephen Hutchinson wrote: >>>> I've uploaded the amended 1st patch and added a 6th to deal with >>>> the issues I encountered when testing the 'build FFmpeg with MSVC' >>>> route. Since git send-email (or Gmail) screwed up the threading >>>> when I sent these the first time, this is the proper order: >>>> >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241922.html >>>> <-fixed header update patch >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241502.html >>>> <-enabling the additional pix_fmts; nothing has changed on this one >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241507.html >>>> <-removing the header warning in the docs; nothing has changed on >>>> this one >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241504.html >>>> <-updating the project link to point to the AviSynth wiki page on >>>> AviSynth+; nothing has changed on this one >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241505.html >>>> <-usage note about 32-bit GCC builds of AviSynth+ and the >>>> AVSC_WIN32_GCC32 switch; nothing has changed on this one >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241923.html >>>> <-new (well, technically old) patch to fix FARPROC warnings/build >>>> errors >> Will apply #3, 4 and 5 with #6. >> >> #2 looks okay to me, but I'm not acquainted enowith Avisynth to ok >> it. But since you're the maintainer for avisynth.c, do you want me to >> push them? >> >> Gyan > Yes, go ahead and push all six patches. #2 is just a simple, direct > mapping of those pix_fmts in AviSynth+ to the equivalent ones > provided by FFmpeg/libavutil. The longer explanation about > #2 is here: > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241520.html > > You didn't mention #1, but #5 (and to a far, far, far lesser extent, #3) > don't make much sense without #1 getting applied. Sorry, the email was responded you was a draft saved mid-edit. When I sent my final mail, my net was down. When back up, I sent the saved draft but didn't realize my MUA hadn't updated the draft with the revised copy. Anyway, all pushed. Mentioning refs to help search: 18bbb2dd01f25cf1b36106588a3699c0741bba19 b1681bad33581bc8a018bc9b6ec02761162240e4 224aad3026276064eac77be6a9eae1d85f13f36f 55895df4c8bf0ed9cdaa3b8c638e51ac920180ae d19f8e711c06287006e680c1bd417ffe52074a6b a5387f983dcfd01cb74ab33e34d714a1d882184b Gyan
diff --git a/doc/general.texi b/doc/general.texi index fe94c40386..6ec52962ff 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -51,19 +51,6 @@ For Windows, supported AviSynth variants are For Linux and OS X, the supported AviSynth variant is @url{https://github.com/avxsynth/avxsynth, AvxSynth}. -@float NOTE -There is currently a regression in AviSynth+'s @code{capi.h} header as of -October 2016, which interferes with the ability for builds of FFmpeg to use -MSVC-built binaries of AviSynth. Until this is resolved, you can make sure -a known good version is installed by checking out a version from before -the regression occurred: - -@code{git clone -b MT git://github.com/AviSynth/AviSynthPlus.git @* -cd AviSynthPlus @* -git checkout -b oldheader b4f292b4dbfad149697fb65c6a037bb3810813f9 @* -make install PREFIX=/install/prefix} -@end float - @float NOTE AviSynth and AvxSynth are loaded dynamically. Distributors can build FFmpeg with @code{--enable-avisynth}, and the binaries will work regardless of the