diff mbox

[FFmpeg-devel,v1] avformat/flvdec: add debug message to list keyframes index metadata

Message ID 20161104115448.14590-1-lq@chinaffmpeg.org
State Accepted
Commit 4696f7639b22c9205792d2e3d5e8e07b3cadbb63
Headers show

Commit Message

Liu Steven Nov. 4, 2016, 11:54 a.m. UTC
when parsing keyframe index metadata, list the message by trace log

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/flvdec.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Michael Niedermayer Nov. 4, 2016, 3:02 p.m. UTC | #1
On Fri, Nov 04, 2016 at 07:54:48PM +0800, Steven Liu wrote:
> when parsing keyframe index metadata, list the message by trace log
> 
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavformat/flvdec.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

LGTM

thx

[...]
Steven Liu Nov. 14, 2016, 7:02 a.m. UTC | #2
2016-11-04 23:02 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>:

> On Fri, Nov 04, 2016 at 07:54:48PM +0800, Steven Liu wrote:
> > when parsing keyframe index metadata, list the message by trace log
> >
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  libavformat/flvdec.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
>
> LGTM
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If you fake or manipulate statistics in a paper in physics you will never
> get a job again.
> If you fake or manipulate statistics in a paper in medicin you will get
> a job for life at the pharma industry.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Applied?
Michael Niedermayer Nov. 19, 2016, 12:26 a.m. UTC | #3
On Mon, Nov 14, 2016 at 03:02:27PM +0800, Steven Liu wrote:
> 2016-11-04 23:02 GMT+08:00 Michael Niedermayer <michael@niedermayer.cc>:
> 
> > On Fri, Nov 04, 2016 at 07:54:48PM +0800, Steven Liu wrote:
> > > when parsing keyframe index metadata, list the message by trace log
> > >
> > > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > > ---
> > >  libavformat/flvdec.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > LGTM
> >
> > thx
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > If you fake or manipulate statistics in a paper in physics you will never
> > get a job again.
> > If you fake or manipulate statistics in a paper in medicin you will get
> > a job for life at the pharma industry.
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >
> Applied?

applied in a moment, but you could have applied it yourself too ;)

[...]
diff mbox

Patch

diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index e53c345..3812994 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -114,6 +114,8 @@  static void add_keyframes_index(AVFormatContext *s)
 
     if (stream->nb_index_entries == 0) {
         for (i = 0; i < flv->keyframe_count; i++) {
+            av_log(s, AV_LOG_TRACE, "keyframe filepositions = %"PRId64" times = %"PRId64"\n",
+                   flv->keyframe_filepositions[i], flv->keyframe_times[i] * 1000);
             av_add_index_entry(stream, flv->keyframe_filepositions[i],
                 flv->keyframe_times[i] * 1000, 0, 0, AVINDEX_KEYFRAME);
         }