Message ID | 20190604134105.23365-1-andreas.rheinhardt@gmail.com |
---|---|
State | Accepted |
Commit | d81913e680177bc46c482406fd257ac659c03899 |
Headers | show |
On 04-06-2019 07:11 PM, Andreas Rheinhardt wrote: > The default is to dump extradata to keyframes, not all frames. > Also improve the description of the relevant AVOption. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > doc/bitstream_filters.texi | 2 +- > libavcodec/dump_extradata_bsf.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 25bbf8372b..40e8adad0f 100644 > --- a/doc/bitstream_filters.texi > +++ b/doc/bitstream_filters.texi > @@ -120,7 +120,7 @@ add extradata to all packets > @end table > @end table > > -If not specified it is assumed @samp{e}. > +If not specified it is assumed @samp{k}. > > For example the following @command{ffmpeg} command forces a global > header (thus disabling individual packet headers) in the H.264 packets > diff --git a/libavcodec/dump_extradata_bsf.c b/libavcodec/dump_extradata_bsf.c > index 188a1c619b..7112cd6bd4 100644 > --- a/libavcodec/dump_extradata_bsf.c > +++ b/libavcodec/dump_extradata_bsf.c > @@ -81,7 +81,7 @@ fail: > #define OFFSET(x) offsetof(DumpExtradataContext, x) > #define FLAGS (AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_BSF_PARAM) > static const AVOption options[] = { > - { "freq", "When do dump extradata", OFFSET(freq), AV_OPT_TYPE_INT, > + { "freq", "When to dump extradata", OFFSET(freq), AV_OPT_TYPE_INT, > { .i64 = DUMP_FREQ_KEYFRAME }, DUMP_FREQ_KEYFRAME, DUMP_FREQ_ALL, FLAGS, "freq" }, > { "k", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" }, > { "keyframe", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" }, Will apply. Gyan
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 25bbf8372b..40e8adad0f 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -120,7 +120,7 @@ add extradata to all packets @end table @end table -If not specified it is assumed @samp{e}. +If not specified it is assumed @samp{k}. For example the following @command{ffmpeg} command forces a global header (thus disabling individual packet headers) in the H.264 packets diff --git a/libavcodec/dump_extradata_bsf.c b/libavcodec/dump_extradata_bsf.c index 188a1c619b..7112cd6bd4 100644 --- a/libavcodec/dump_extradata_bsf.c +++ b/libavcodec/dump_extradata_bsf.c @@ -81,7 +81,7 @@ fail: #define OFFSET(x) offsetof(DumpExtradataContext, x) #define FLAGS (AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_BSF_PARAM) static const AVOption options[] = { - { "freq", "When do dump extradata", OFFSET(freq), AV_OPT_TYPE_INT, + { "freq", "When to dump extradata", OFFSET(freq), AV_OPT_TYPE_INT, { .i64 = DUMP_FREQ_KEYFRAME }, DUMP_FREQ_KEYFRAME, DUMP_FREQ_ALL, FLAGS, "freq" }, { "k", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" }, { "keyframe", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = DUMP_FREQ_KEYFRAME }, .flags = FLAGS, .unit = "freq" },
The default is to dump extradata to keyframes, not all frames. Also improve the description of the relevant AVOption. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- doc/bitstream_filters.texi | 2 +- libavcodec/dump_extradata_bsf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)