diff mbox

[FFmpeg-devel,v3,3/3] doc/filters.texi: Don't need to be yuv420 format for cover image

Message ID 20190611053844.21321-3-lance.lmwang@gmail.com
State Superseded
Headers show

Commit Message

Lance Wang June 11, 2019, 5:38 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 doc/filters.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Moritz Barsnick June 12, 2019, 9:45 a.m. UTC | #1 
On Tue, Jun 11, 2019 at 13:38:44 +0800, lance.lmwang@gmail.com wrote:
>  doc/filters.texi | 2 +-

While you're at it, could you kindly add another patch to fix the
descriptions of the examples for find_rect and cover_rect? They are
copy pasted from pallettegen, and are totally misleading:

> Generate a representative palette of a given video using @command{ffmpeg}:

Thanks,
Moritz
Lance Wang June 12, 2019, 10:50 a.m. UTC | #2 
On Wed, Jun 12, 2019 at 5:46 PM Moritz Barsnick <barsnick@gmx.net> wrote:

> On Tue, Jun 11, 2019 at 13:38:44 +0800, lance.lmwang@gmail.com wrote:
> >  doc/filters.texi | 2 +-
>
> While you're at it, could you kindly add another patch to fix the
> descriptions of the examples for find_rect and cover_rect? They are
> copy pasted from pallettegen, and are totally misleading:
>
> > Generate a representative palette of a given video using
> @command{ffmpeg}:
>
>
OK, I'll update the patch with the description also. Please help to review
it.



> Thanks,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index ec1c7c7591..948d7e8423 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -10180,7 +10180,7 @@  It accepts the following options:
 
 @table @option
 @item cover
-Filepath of the optional cover image, needs to be in yuv420.
+Filepath of the optional cover image.
 
 @item mode
 Set covering mode.