diff mbox

[FFmpeg-devel,v4,2/2] doc/filters.texi: don't need to be in gray8 for find image

Message ID 20190611060730.21868-1-lance.lmwang@gmail.com
State Superseded
Headers show

Commit Message

Lance Wang June 11, 2019, 6:07 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 doc/filters.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer June 11, 2019, 9:23 p.m. UTC | #1
On Tue, Jun 11, 2019 at 02:07:30PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  doc/filters.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index ec1c7c7591..90c57430a6 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -10150,7 +10150,7 @@ It accepts the following options:
>  
>  @table @option
>  @item object
> -Filepath of the object image, needs to be in gray8.
> +Filepath of the object image.

this belongs in the same patch which changes the code accordingly

thx

[...]
Lance Wang June 12, 2019, 1:27 a.m. UTC | #2
On Wed, Jun 12, 2019 at 5:23 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Tue, Jun 11, 2019 at 02:07:30PM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  doc/filters.texi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index ec1c7c7591..90c57430a6 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -10150,7 +10150,7 @@ It accepts the following options:
> >
> >  @table @option
> >  @item object
> > -Filepath of the object image, needs to be in gray8.
> > +Filepath of the object image.
>
> this belongs in the same patch which changes the code accordingly
>
> thx
>
>
OK, I'll put into one patch and send update version.


> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No snowflake in an avalanche ever feels responsible. -- Voltaire
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Lance Wang June 12, 2019, 11:08 a.m. UTC | #3
On Wed, Jun 12, 2019 at 5:23 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Tue, Jun 11, 2019 at 02:07:30PM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  doc/filters.texi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index ec1c7c7591..90c57430a6 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -10150,7 +10150,7 @@ It accepts the following options:
> >
> >  @table @option
> >  @item object
> > -Filepath of the object image, needs to be in gray8.
> > +Filepath of the object image.
>
> this belongs in the same patch which changes the code accordingly
>
> Have update the patch below:
https://patchwork.ffmpeg.org/patch/13513/

Also I have add more patch to improve the performance, please help to
review and give comments:
https://patchwork.ffmpeg.org/patch/13511/
https://patchwork.ffmpeg.org/patch/13512/

Thx.

thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No snowflake in an avalanche ever feels responsible. -- Voltaire
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index ec1c7c7591..90c57430a6 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -10150,7 +10150,7 @@  It accepts the following options:
 
 @table @option
 @item object
-Filepath of the object image, needs to be in gray8.
+Filepath of the object image.
 
 @item threshold
 Detection threshold, default is 0.5.