| Message ID | 1564395639-27142-1-git-send-email-zhong.li@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Jul 29, 2019 at 06:20:39PM +0800, Zhong Li wrote: > Signed-off-by: Zhong Li <zhong.li@intel.com> > --- > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it. > Test clip produced by: > ffmpeg -i tickets/3229/bad.avi -vframes 6 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi > > tests/fate/video.mak | 3 +++ > tests/ref/fate/mjpeg-ticket3229 | 11 +++++++++++ > 2 files changed, 14 insertions(+) > create mode 100644 tests/ref/fate/mjpeg-ticket3229 LGTM & passed on mingw32/64 arm/mips qemu and linux32 thx [...]
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Tuesday, July 30, 2019 4:28 AM > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2] fate: add a case for ticket #3229 > > On Mon, Jul 29, 2019 at 06:20:39PM +0800, Zhong Li wrote: > > Signed-off-by: Zhong Li <zhong.li@intel.com> > > --- > > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but > not found by fate, so add it. > > Test clip produced by: > > ffmpeg -i tickets/3229/bad.avi -vframes 6 -c:v copy > > /fate-suite/mjpeg/mjpeg_field_order.avi > > > > tests/fate/video.mak | 3 +++ > > tests/ref/fate/mjpeg-ticket3229 | 11 +++++++++++ > > 2 files changed, 14 insertions(+) > > create mode 100644 tests/ref/fate/mjpeg-ticket3229 > > LGTM & passed on mingw32/64 arm/mips qemu and linux32 > > thx Thanks for review and testing. May I search your help to produce/upload the clip to fate server and then apply this patch?
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Tuesday, July 30, 2019 9:53 AM > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2] fate: add a case for ticket #3229 > > > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On > Behalf > > Of Michael Niedermayer > > Sent: Tuesday, July 30, 2019 4:28 AM > > To: FFmpeg development discussions and patches > > <ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH V2] fate: add a case for ticket > > #3229 > > > > On Mon, Jul 29, 2019 at 06:20:39PM +0800, Zhong Li wrote: > > > Signed-off-by: Zhong Li <zhong.li@intel.com> > > > --- > > > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression > > > but > > not found by fate, so add it. > > > Test clip produced by: > > > ffmpeg -i tickets/3229/bad.avi -vframes 6 -c:v copy > > > /fate-suite/mjpeg/mjpeg_field_order.avi > > > > > > tests/fate/video.mak | 3 +++ > > > tests/ref/fate/mjpeg-ticket3229 | 11 +++++++++++ > > > 2 files changed, 14 insertions(+) > > > create mode 100644 tests/ref/fate/mjpeg-ticket3229 > > > > LGTM & passed on mingw32/64 arm/mips qemu and linux32 > > > > thx > > Thanks for review and testing. > May I search your help to produce/upload the clip to fate server and then > apply this patch? Ping?
diff --git a/tests/fate/video.mak b/tests/fate/video.mak index be1458c..d2d43e5 100644 --- a/tests/fate/video.mak +++ b/tests/fate/video.mak @@ -232,6 +232,9 @@ fate-mimic: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/mimic/mimic2-womanl FATE_VIDEO-$(call DEMDEC, MOV, MJPEGB) += fate-mjpegb fate-mjpegb: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpegb/mjpegb_part.mov -an +FATE_VIDEO-$(call DEMDEC, AVI, MJPEG) += fate-mjpeg-ticket3229 +fate-mjpeg-ticket3229: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpeg/mjpeg_field_order.avi -an + FATE_VIDEO-$(call DEMDEC, MVI, MOTIONPIXELS) += fate-motionpixels fate-motionpixels: CMD = framecrc -i $(TARGET_SAMPLES)/motion-pixels/INTRO-partial.MVI -an -pix_fmt rgb24 -frames:v 111 diff --git a/tests/ref/fate/mjpeg-ticket3229 b/tests/ref/fate/mjpeg-ticket3229 new file mode 100644 index 0000000..d3068b2 --- /dev/null +++ b/tests/ref/fate/mjpeg-ticket3229 @@ -0,0 +1,11 @@ +#tb 0: 1/30 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 468x312 +#sar 0: 0/1 +0, 0, 0, 1, 292032, 0x3af3a5f7 +0, 6, 6, 1, 292032, 0xe97fb504 +0, 8, 8, 1, 292032, 0xd448db04 +0, 9, 9, 1, 292032, 0xd448db04 +0, 10, 10, 1, 292032, 0xd448db04 +0, 11, 11, 1, 292032, 0xd448db04
Signed-off-by: Zhong Li <zhong.li@intel.com> --- https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it. Test clip produced by: ffmpeg -i tickets/3229/bad.avi -vframes 6 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi tests/fate/video.mak | 3 +++ tests/ref/fate/mjpeg-ticket3229 | 11 +++++++++++ 2 files changed, 14 insertions(+) create mode 100644 tests/ref/fate/mjpeg-ticket3229