Message ID | 20190824161800.15365-3-lance.lmwang@gmail.com |
---|---|
State | New |
Headers | show |
The API is deprecated, do not use it. On Sat, Aug 24, 2019 at 6:25 PM <lance.lmwang@gmail.com> wrote: > From: Limin Wang <lance.lmwang@gmail.com> > > Below is the final displaying format for the QP table data and properties, > timecode: > [Parsed_showinfo_0 @ 0x364fdc0] side data - pan/scan > [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table data (1350 bytes) > [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table properties (8 bytes) > [Parsed_showinfo_0 @ 0x364fdc0] side data - GOP start timecode - > 00:00:00:00 > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > --- > libavfilter/vf_showinfo.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index 31f6b32..5d38783 100644 > --- a/libavfilter/vf_showinfo.c > +++ b/libavfilter/vf_showinfo.c > @@ -319,6 +319,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame > *frame) > av_log(ctx, AV_LOG_INFO, "GOP timecode - %s", tcbuf); > break; > } > +#if FF_API_FRAME_QP > + case AV_FRAME_DATA_QP_TABLE_PROPERTIES: > + av_log(ctx, AV_LOG_INFO, "QP table properties (%d bytes)", > sd->size); > + break; > + case AV_FRAME_DATA_QP_TABLE_DATA: > + av_log(ctx, AV_LOG_INFO, "QP table data (%d bytes)", > sd->size); > + break; > +#endif > default: > av_log(ctx, AV_LOG_WARNING, "unknown side data type %d (%d > bytes)", > sd->type, sd->size); > -- > 2.9.5 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Sat, Aug 24, 2019 at 06:27:13PM +0200, Paul B Mahol wrote: > The API is deprecated, do not use it. > Yes, I have notice it's deprecated so I make it two patch. However there're three place to create the side data anyway, so I add FF_API_FRAME_QP to mark it's deprecated and haven't do more information dump. If the side data type will be removed soon, then ignore the patch for qp table.. > On Sat, Aug 24, 2019 at 6:25 PM <lance.lmwang@gmail.com> wrote: > > > From: Limin Wang <lance.lmwang@gmail.com> > > > > Below is the final displaying format for the QP table data and properties, > > timecode: > > [Parsed_showinfo_0 @ 0x364fdc0] side data - pan/scan > > [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table data (1350 bytes) > > [Parsed_showinfo_0 @ 0x364fdc0] side data - QP table properties (8 bytes) > > [Parsed_showinfo_0 @ 0x364fdc0] side data - GOP start timecode - > > 00:00:00:00 > > > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > > --- > > libavfilter/vf_showinfo.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > > index 31f6b32..5d38783 100644 > > --- a/libavfilter/vf_showinfo.c > > +++ b/libavfilter/vf_showinfo.c > > @@ -319,6 +319,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame > > *frame) > > av_log(ctx, AV_LOG_INFO, "GOP timecode - %s", tcbuf); > > break; > > } > > +#if FF_API_FRAME_QP > > + case AV_FRAME_DATA_QP_TABLE_PROPERTIES: > > + av_log(ctx, AV_LOG_INFO, "QP table properties (%d bytes)", > > sd->size); > > + break; > > + case AV_FRAME_DATA_QP_TABLE_DATA: > > + av_log(ctx, AV_LOG_INFO, "QP table data (%d bytes)", > > sd->size); > > + break; > > +#endif > > default: > > av_log(ctx, AV_LOG_WARNING, "unknown side data type %d (%d > > bytes)", > > sd->type, sd->size); > > -- > > 2.9.5 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 31f6b32..5d38783 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -319,6 +319,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) av_log(ctx, AV_LOG_INFO, "GOP timecode - %s", tcbuf); break; } +#if FF_API_FRAME_QP + case AV_FRAME_DATA_QP_TABLE_PROPERTIES: + av_log(ctx, AV_LOG_INFO, "QP table properties (%d bytes)", sd->size); + break; + case AV_FRAME_DATA_QP_TABLE_DATA: + av_log(ctx, AV_LOG_INFO, "QP table data (%d bytes)", sd->size); + break; +#endif default: av_log(ctx, AV_LOG_WARNING, "unknown side data type %d (%d bytes)", sd->type, sd->size);