diff mbox

[FFmpeg-devel,1/5] avcodec/vaapi_encode: Simplify code with av_clip_int8()

Message ID 20190828172653.20031-1-michael@niedermayer.cc
State Accepted
Commit 9b57b90c4c2752426c6552a87a96821ff9708fac
Headers show

Commit Message

Michael Niedermayer Aug. 28, 2019, 5:26 p.m. UTC
Only build tested

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/vaapi_encode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhong Li Aug. 29, 2019, 12:18 a.m. UTC | #1
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael

> Niedermayer

> Sent: Thursday, August 29, 2019 1:27 AM

> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>

> Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/vaapi_encode: Simplify code with

> av_clip_int8()

> 

> Only build tested

> 

> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

> ---

>  libavcodec/vaapi_encode.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index

> 2fb43cf1a4..3be9159d37 100644

> --- a/libavcodec/vaapi_encode.c

> +++ b/libavcodec/vaapi_encode.c

> @@ -480,7 +480,7 @@ static int vaapi_encode_issue(AVCodecContext *avctx,

>                      .width  = roi->right  - roi->left,

>                      .height = roi->bottom - roi->top,

>                  },

> -                .roi_value = av_clip_c(v, INT8_MIN, INT8_MAX),

> +                .roi_value = av_clip_int8(v),

>              };

>          }

> 

> --

> 2.23.0


LGTM
Michael Niedermayer Aug. 30, 2019, 6:24 p.m. UTC | #2
On Thu, Aug 29, 2019 at 12:18:03AM +0000, Li, Zhong wrote:
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> > Niedermayer
> > Sent: Thursday, August 29, 2019 1:27 AM
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/vaapi_encode: Simplify code with
> > av_clip_int8()
> > 
> > Only build tested
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/vaapi_encode.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index
> > 2fb43cf1a4..3be9159d37 100644
> > --- a/libavcodec/vaapi_encode.c
> > +++ b/libavcodec/vaapi_encode.c
> > @@ -480,7 +480,7 @@ static int vaapi_encode_issue(AVCodecContext *avctx,
> >                      .width  = roi->right  - roi->left,
> >                      .height = roi->bottom - roi->top,
> >                  },
> > -                .roi_value = av_clip_c(v, INT8_MIN, INT8_MAX),
> > +                .roi_value = av_clip_int8(v),
> >              };
> >          }
> > 
> > --
> > 2.23.0
> 
> LGTM

will apply

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index 2fb43cf1a4..3be9159d37 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@ -480,7 +480,7 @@  static int vaapi_encode_issue(AVCodecContext *avctx,
                     .width  = roi->right  - roi->left,
                     .height = roi->bottom - roi->top,
                 },
-                .roi_value = av_clip_c(v, INT8_MIN, INT8_MAX),
+                .roi_value = av_clip_int8(v),
             };
         }