diff mbox

[FFmpeg-devel] avformat/aiffdec: parse replaygain metadata

Message ID 20190313091740.32543-1-barsnick@gmx.net
State Accepted
Commit 6390f52ac79932ed53a96619aa9cf2efd0a0fd19
Headers show

Commit Message

Moritz Barsnick March 13, 2019, 9:17 a.m. UTC 
Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
---
Tested against sample provided here:
https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html

 libavformat/aiffdec.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Moritz Barsnick March 18, 2019, 8:28 a.m. UTC | #1 
On Wed, Mar 13, 2019 at 10:17:40 +0100, Moritz Barsnick wrote:
> Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
> ---
> Tested against sample provided here:
> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> 
>  libavformat/aiffdec.c | 5 +++++
>  1 file changed, 5 insertions(+)

Friendly ping.

Cheers,
Moritz
Paul B Mahol March 18, 2019, 10:01 a.m. UTC | #2 
On 3/18/19, Moritz Barsnick <barsnick@gmx.net> wrote:
> On Wed, Mar 13, 2019 at 10:17:40 +0100, Moritz Barsnick wrote:
>> Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
>> ---
>> Tested against sample provided here:
>> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
>>
>>  libavformat/aiffdec.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>
> Friendly ping.

LGTM
Moritz Barsnick Sept. 19, 2019, 2:17 p.m. UTC | #3 
On Mon, Mar 18, 2019 at 11:01:21 +0100, Paul B Mahol wrote:
> On 3/18/19, Moritz Barsnick <barsnick@gmx.net> wrote:
> >> Tested against sample provided here:
> >> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> >>
> >>  libavformat/aiffdec.c | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >
> > Friendly ping.
>
> LGTM

Another ping for push of patch. (Still applies cleanly to HEAD of
master.)

Moritz

https://patchwork.ffmpeg.org/patch/12302/
in case it got out of view...
Michael Niedermayer Sept. 20, 2019, 9:14 p.m. UTC | #4 
On Thu, Sep 19, 2019 at 04:17:20PM +0200, Moritz Barsnick wrote:
> On Mon, Mar 18, 2019 at 11:01:21 +0100, Paul B Mahol wrote:
> > On 3/18/19, Moritz Barsnick <barsnick@gmx.net> wrote:
> > >> Tested against sample provided here:
> > >> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> > >>
> > >>  libavformat/aiffdec.c | 5 +++++
> > >>  1 file changed, 5 insertions(+)
> > >
> > > Friendly ping.
> >
> > LGTM
> 
> Another ping for push of patch. (Still applies cleanly to HEAD of
> master.)

will apply

thx

[...]
diff mbox

Patch

diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index 7c701e0c70..ea2955816a 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
@@ -29,6 +29,7 @@ 
 #include "isom.h"
 #include "id3v2.h"
 #include "mov_chan.h"
+#include "replaygain.h"
 
 #define AIFF                    0
 #define AIFF_C_VERSION1         0xA2805140
@@ -348,6 +349,10 @@  static int aiff_read_header(AVFormatContext *s)
         }
     }
 
+    ret = ff_replaygain_export(st, s->metadata);
+    if (ret < 0)
+        return ret;
+
 got_sound:
     if (!st->codecpar->block_align && st->codecpar->codec_id == AV_CODEC_ID_QCELP) {
         av_log(s, AV_LOG_WARNING, "qcelp without wave chunk, assuming full rate\n");