diff mbox

[FFmpeg-devel,v2,3/3] FATE: add fate test for minterpolate filter

Message ID 20190914033731.19613-3-lance.lmwang@gmail.com
State Superseded
Headers show

Commit Message

Lance Wang Sept. 14, 2019, 3:37 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 tests/fate/filter-video.mak             |  4 ++++
 tests/ref/fate/filter-minterpolate-down |  6 ++++++
 tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 tests/ref/fate/filter-minterpolate-down
 create mode 100644 tests/ref/fate/filter-minterpolate-up

Comments

Michael Niedermayer Sept. 15, 2019, 5:05 p.m. UTC | #1 
On Sat, Sep 14, 2019 at 11:37:31AM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  tests/fate/filter-video.mak             |  4 ++++
>  tests/ref/fate/filter-minterpolate-down |  6 ++++++
>  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 tests/ref/fate/filter-minterpolate-down
>  create mode 100644 tests/ref/fate/filter-minterpolate-up
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 0c6ee72..ab7b624 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
>  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
>  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
>  
> +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down

> +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1

tested on linux x86_32/64, mingw32/64 arm & mips qemu

[...]
Lance Wang Sept. 20, 2019, 3:11 a.m. UTC | #2 
On Sun, Sep 15, 2019 at 07:05:35PM +0200, Michael Niedermayer wrote:
> On Sat, Sep 14, 2019 at 11:37:31AM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  tests/fate/filter-video.mak             |  4 ++++
> >  tests/ref/fate/filter-minterpolate-down |  6 ++++++
> >  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-minterpolate-down
> >  create mode 100644 tests/ref/fate/filter-minterpolate-up
> > 
> > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > index 0c6ee72..ab7b624 100644
> > --- a/tests/fate/filter-video.mak
> > +++ b/tests/fate/filter-video.mak
> > @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
> >  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
> >  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
> >  
> > +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down
> 
> > +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> > +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1
> 
> tested on linux x86_32/64, mingw32/64 arm & mips qemu

Michael, thanks for the testing, I update the commit message to include
the testing result.


> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> When you are offended at any man's fault, turn to yourself and study your
> own failings. Then you will forget your anger. -- Epictetus



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Lance Wang Sept. 24, 2019, 10:28 a.m. UTC | #3 
ping, please help to push it or comments.

On Sun, Sep 15, 2019 at 07:05:35PM +0200, Michael Niedermayer wrote:
> On Sat, Sep 14, 2019 at 11:37:31AM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  tests/fate/filter-video.mak             |  4 ++++
> >  tests/ref/fate/filter-minterpolate-down |  6 ++++++
> >  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-minterpolate-down
> >  create mode 100644 tests/ref/fate/filter-minterpolate-up
> > 
> > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > index 0c6ee72..ab7b624 100644
> > --- a/tests/fate/filter-video.mak
> > +++ b/tests/fate/filter-video.mak
> > @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
> >  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
> >  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
> >  
> > +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down
> 
> > +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> > +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1
> 
> tested on linux x86_32/64, mingw32/64 arm & mips qemu
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> When you are offended at any man's fault, turn to yourself and study your
> own failings. Then you will forget your anger. -- Epictetus



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Nicolas George Aug. 13, 2020, 8:55 p.m. UTC | #4 
Hi. Replying to a very old patch already applied.

lance.lmwang@gmail.com (12019-09-14):
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  tests/fate/filter-video.mak             |  4 ++++
>  tests/ref/fate/filter-minterpolate-down |  6 ++++++
>  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 tests/ref/fate/filter-minterpolate-down
>  create mode 100644 tests/ref/fate/filter-minterpolate-up
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 0c6ee72..ab7b624 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
>  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
>  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
>  
> +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down

> +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1

The patch says minterpolate, but the test is an exact copy of the
framerate test, and still testing framerate. Please fix.

Regards,
Lance Wang Aug. 14, 2020, 1:10 a.m. UTC | #5 
On Thu, Aug 13, 2020 at 10:55:07PM +0200, Nicolas George wrote:
> Hi. Replying to a very old patch already applied.
> 
> lance.lmwang@gmail.com (12019-09-14):
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  tests/fate/filter-video.mak             |  4 ++++
> >  tests/ref/fate/filter-minterpolate-down |  6 ++++++
> >  tests/ref/fate/filter-minterpolate-up   | 15 +++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-minterpolate-down
> >  create mode 100644 tests/ref/fate/filter-minterpolate-up
> > 
> > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > index 0c6ee72..ab7b624 100644
> > --- a/tests/fate/filter-video.mak
> > +++ b/tests/fate/filter-video.mak
> > @@ -122,6 +122,10 @@ FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
> >  fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
> >  fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
> >  
> > +FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down
> 
> > +fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
> > +fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1
> 
> The patch says minterpolate, but the test is an exact copy of the
> framerate test, and still testing framerate. Please fix.

sorry, will fix it.

> 
> Regards,
> 
> -- 
>   Nicolas George
diff mbox

Patch

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 0c6ee72..ab7b624 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -122,6 +122,10 @@  FATE_FILTER-$(call ALLYES, FRAMERATE_FILTER TESTSRC2_FILTER FORMAT_FILTER) += fa
 fate-filter-framerate-12bit-up: CMD = framecrc -lavfi testsrc2=r=50:d=1,format=pix_fmts=yuv422p12le,framerate=fps=60 -t 1 -pix_fmt yuv422p12le
 fate-filter-framerate-12bit-down: CMD = framecrc -lavfi testsrc2=r=60:d=1,format=pix_fmts=yuv422p12le,framerate=fps=50 -t 1 -pix_fmt yuv422p12le
 
+FATE_FILTER-$(call ALLYES, MINTERPOLATE_FILTER TESTSRC2_FILTER) += fate-filter-minterpolate-up fate-filter-minterpolate-down
+fate-filter-minterpolate-up: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=10 -t 1
+fate-filter-minterpolate-down: CMD = framecrc -lavfi testsrc2=r=2:d=10,framerate=fps=1 -t 1
+
 FATE_FILTER_VSYNTH-$(CONFIG_BOXBLUR_FILTER) += fate-filter-boxblur
 fate-filter-boxblur: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf boxblur=2:1
 
diff --git a/tests/ref/fate/filter-minterpolate-down b/tests/ref/fate/filter-minterpolate-down
new file mode 100644
index 0000000..4eab7aa
--- /dev/null
+++ b/tests/ref/fate/filter-minterpolate-down
@@ -0,0 +1,6 @@ 
+#tb 0: 1/1
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 320x240
+#sar 0: 1/1
+0,          0,          0,        1,   115200, 0x3744b3ed
diff --git a/tests/ref/fate/filter-minterpolate-up b/tests/ref/fate/filter-minterpolate-up
new file mode 100644
index 0000000..a276bf6
--- /dev/null
+++ b/tests/ref/fate/filter-minterpolate-up
@@ -0,0 +1,15 @@ 
+#tb 0: 1/10
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 320x240
+#sar 0: 1/1
+0,          0,          0,        1,   115200, 0x3744b3ed
+0,          1,          1,        1,   115200, 0xec1fdfa0
+0,          2,          2,        1,   115200, 0xa17f0d74
+0,          3,          3,        1,   115200, 0xd72532a9
+0,          4,          4,        1,   115200, 0x032e60f8
+0,          5,          5,        1,   115200, 0x6e318ba0
+0,          6,          6,        1,   115200, 0x76018292
+0,          7,          7,        1,   115200, 0x89e27599
+0,          8,          8,        1,   115200, 0x68536eac
+0,          9,          9,        1,   115200, 0xc3ac62a8