diff mbox

[FFmpeg-devel,1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Message ID 20191008112843.6875-1-onemda@gmail.com
State Superseded
Headers show

Commit Message

Paul B Mahol Oct. 8, 2019, 11:28 a.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavutil/opt.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul B Mahol Oct. 9, 2019, 9:24 a.m. UTC | #1 
Because this receives no comments so fat at all, will apply asap this set.

On 10/8/19, Paul B Mahol <onemda@gmail.com> wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavutil/opt.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavutil/opt.h b/libavutil/opt.h
> index 39f4a8dda0..693a170bcc 100644
> --- a/libavutil/opt.h
> +++ b/libavutil/opt.h
> @@ -288,6 +288,7 @@ typedef struct AVOption {
>   */
>  #define AV_OPT_FLAG_READONLY        128
>  #define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which
> can be set by the user for bit stream filtering
> +#define AV_OPT_FLAG_COMMAND_PARAM   (1<<15) ///< a generic parameter which
> can be set by the user via commands with filtering
>  #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which
> can be set by the user for filtering
>  #define AV_OPT_FLAG_DEPRECATED      (1<<17) ///< set if option is
> deprecated, users should refer to AVOption.help text for more information
>  //FIXME think about enc-audio, ... style flags
> --
> 2.17.1
>
>
Nicolas George Oct. 9, 2019, 9:28 a.m. UTC | #2 
Paul B Mahol (12019-10-09):
> Because this receives no comments so fat at all, will apply asap this set.

Less than 24 hours for something that changes the public API? Out of the
question.

If in one week you had no comments, you can ask again that people look
into it.

Regards,
Paul B Mahol Oct. 9, 2019, 9:30 a.m. UTC | #3 
On 10/9/19, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (12019-10-09):
>> Because this receives no comments so fat at all, will apply asap this
>> set.
>
> Less than 24 hours for something that changes the public API? Out of the
> question.

This only adds single flag.

>
> If in one week you had no comments, you can ask again that people look
> into it.

Out of question. Your reply with all due respect is ignored.

>
> Regards,
>
> --
>   Nicolas George
>
Nicolas George Oct. 9, 2019, 9:35 a.m. UTC | #4 
Paul B Mahol (12019-10-09):
> This only adds single flag.

A flag that belongs in the public API, and therefore that we will have
to support for a long time. Hence the need to make sure it is properly
designed.

> Out of question. Your reply with all due respect is ignored.

This is not respect, this is aggression. One week for important patches,
that is the common policy, and I will see it applied.

Once again, this is not your own personal project, this is a
collaborative endeavour, and rules applies to everybody.

Regards,
Paul B Mahol Oct. 9, 2019, 9:46 a.m. UTC | #5 
On 10/9/19, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (12019-10-09):
>> This only adds single flag.
>
> A flag that belongs in the public API, and therefore that we will have
> to support for a long time. Hence the need to make sure it is properly
> designed.
>
>> Out of question. Your reply with all due respect is ignored.
>
> This is not respect, this is aggression. One week for important patches,
> that is the common policy, and I will see it applied.

This is small patch, and can be applied within three days.
Nobody is attacking you, since when stating ignorance is considered
aggression?


>
> Once again, this is not your own personal project, this is a
> collaborative endeavour, and rules applies to everybody.

Except that rule does not apply to you and usual other suspects.

>
> Regards,
>
> --
>   Nicolas George
>
Nicolas George Oct. 9, 2019, 9:50 a.m. UTC | #6 
Paul B Mahol (12019-10-09):
> This is small patch

Not when it touches public API.

Anyway, I maintain lavfi, and I tell you not to commit before I
reviewed.

Break the rules and I will make sure that there are consequences.

By the way, I had some time this morning, and I had considered reviewing
precisely these patches during this time. Your aggression against me
(yes, telling somebody you will ignore their legitimate advice is an
aggression) put me in a frame of mind that prevents doing a fair review.
Good job working against your own interests.

Regards,
Paul B Mahol Oct. 9, 2019, 10 a.m. UTC | #7 
On 10/9/19, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (12019-10-09):
>> This is small patch
>
> Not when it touches public API.

Such interpretation is not in documentation.

>
> Anyway, I maintain lavfi, and I tell you not to commit before I
> reviewed.

Such line is not in MAINTAINERS.

>
> Break the rules and I will make sure that there are consequences.

This is violent attack.

>
> By the way, I had some time this morning, and I had considered reviewing
> precisely these patches during this time. Your aggression against me
> (yes, telling somebody you will ignore their legitimate advice is an
> aggression) put me in a frame of mind that prevents doing a fair review.
> Good job working against your own interests.

I do not believe in your good faith regarding me ever.

>
> Regards,
>
> --
>   Nicolas George
>
Nicolas George Oct. 9, 2019, 10:03 a.m. UTC | #8 
Paul B Mahol (12019-10-09):
> Such interpretation is not in documentation.

> Such line is not in MAINTAINERS.

> This is violent attack.

> I do not believe in your good faith regarding me ever.

I will not argue further with you. You have been warned.

Regards,
Paul B Mahol Oct. 9, 2019, 10:16 a.m. UTC | #9 
On 10/9/19, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (12019-10-09):
>> Such interpretation is not in documentation.
>
>> Such line is not in MAINTAINERS.
>
>> This is violent attack.
>
>> I do not believe in your good faith regarding me ever.
>
> I will not argue further with you. You have been warned.
>

Finally you showed your true self!


> Regards,
>
> --
>   Nicolas George
>
Michael Niedermayer Oct. 9, 2019, 2:19 p.m. UTC | #10 
On Wed, Oct 09, 2019 at 11:24:55AM +0200, Paul B Mahol wrote:
> Because this receives no comments so fat at all, will apply asap this set.

I think you should be a bit more patient, threatening to apply after only
about 24h. Just causes people who have an interrest in the code but cannot
immedeatly review it to be upset ...

I think the patchset is all fine but really i also have not had time to test
it yet nor did i fully review it just had a quick look.

What i would suggest is to give interrested developers time to review and
comment. Not threaten to apply so quickly, you can see here it just ended in
escalation. And i think this thread would have been much more 
peacefull&friendly otherwise

Thanks

[...]
diff mbox

Patch

diff --git a/libavutil/opt.h b/libavutil/opt.h
index 39f4a8dda0..693a170bcc 100644
--- a/libavutil/opt.h
+++ b/libavutil/opt.h
@@ -288,6 +288,7 @@  typedef struct AVOption {
  */
 #define AV_OPT_FLAG_READONLY        128
 #define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which can be set by the user for bit stream filtering
+#define AV_OPT_FLAG_COMMAND_PARAM   (1<<15) ///< a generic parameter which can be set by the user via commands with filtering
 #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which can be set by the user for filtering
 #define AV_OPT_FLAG_DEPRECATED      (1<<17) ///< set if option is deprecated, users should refer to AVOption.help text for more information
 //FIXME think about enc-audio, ... style flags