| Message ID | 1571814464-5013-1-git-send-email-mypopydev@gmail.com |
|---|---|
| State | Accepted |
| Commit | 0e3d5bdc0802898cb39d64c0dbfff81b77117547 |
| Headers | show |
lgtm On 10/23/19, Jun Zhao <mypopydev@gmail.com> wrote: > From: Jun Zhao <barryjzhao@tencent.com> > > Clean the option description and unused code. > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > --- > libavfilter/vf_bilateral.c | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c > index 31578a0..3c9d800 100644 > --- a/libavfilter/vf_bilateral.c > +++ b/libavfilter/vf_bilateral.c > @@ -58,18 +58,13 @@ typedef struct BilateralContext { > > static const AVOption bilateral_options[] = { > { "sigmaS", "set spatial sigma", OFFSET(sigmaS), AV_OPT_TYPE_FLOAT, > {.dbl=0.1}, 0.0, 10, FLAGS }, > - { "sigmaR", "set sigma range", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, > {.dbl=0.1}, 0.0, 1, FLAGS }, > + { "sigmaR", "set range sigma", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, > {.dbl=0.1}, 0.0, 1, FLAGS }, > { "planes", "set planes to filter", OFFSET(planes), AV_OPT_TYPE_INT, > {.i64=1}, 0, 0xF, FLAGS }, > { NULL } > }; > > AVFILTER_DEFINE_CLASS(bilateral); > > -typedef struct ThreadData { > - int height; > - int width; > -} ThreadData; > - > static int query_formats(AVFilterContext *ctx) > { > static const enum AVPixelFormat pix_fmts[] = { > -- > 1.7.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Wed, Oct 23, 2019 at 3:16 PM Paul B Mahol <onemda@gmail.com> wrote: > > lgtm Thanks the quick review, will apply > > On 10/23/19, Jun Zhao <mypopydev@gmail.com> wrote: > > From: Jun Zhao <barryjzhao@tencent.com> > > > > Clean the option description and unused code. > > > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > > --- > > libavfilter/vf_bilateral.c | 7 +------ > > 1 files changed, 1 insertions(+), 6 deletions(-) > > > > diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c > > index 31578a0..3c9d800 100644 > > --- a/libavfilter/vf_bilateral.c > > +++ b/libavfilter/vf_bilateral.c > > @@ -58,18 +58,13 @@ typedef struct BilateralContext { > > > > static const AVOption bilateral_options[] = { > > { "sigmaS", "set spatial sigma", OFFSET(sigmaS), AV_OPT_TYPE_FLOAT, > > {.dbl=0.1}, 0.0, 10, FLAGS }, > > - { "sigmaR", "set sigma range", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, > > {.dbl=0.1}, 0.0, 1, FLAGS }, > > + { "sigmaR", "set range sigma", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, > > {.dbl=0.1}, 0.0, 1, FLAGS }, > > { "planes", "set planes to filter", OFFSET(planes), AV_OPT_TYPE_INT, > > {.i64=1}, 0, 0xF, FLAGS }, > > { NULL } > > }; > > > > AVFILTER_DEFINE_CLASS(bilateral); > > > > -typedef struct ThreadData { > > - int height; > > - int width; > > -} ThreadData; > > - > > static int query_formats(AVFilterContext *ctx) > > { > > static const enum AVPixelFormat pix_fmts[] = { > > -- > > 1.7.1 > >
diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c index 31578a0..3c9d800 100644 --- a/libavfilter/vf_bilateral.c +++ b/libavfilter/vf_bilateral.c @@ -58,18 +58,13 @@ typedef struct BilateralContext { static const AVOption bilateral_options[] = { { "sigmaS", "set spatial sigma", OFFSET(sigmaS), AV_OPT_TYPE_FLOAT, {.dbl=0.1}, 0.0, 10, FLAGS }, - { "sigmaR", "set sigma range", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, {.dbl=0.1}, 0.0, 1, FLAGS }, + { "sigmaR", "set range sigma", OFFSET(sigmaR), AV_OPT_TYPE_FLOAT, {.dbl=0.1}, 0.0, 1, FLAGS }, { "planes", "set planes to filter", OFFSET(planes), AV_OPT_TYPE_INT, {.i64=1}, 0, 0xF, FLAGS }, { NULL } }; AVFILTER_DEFINE_CLASS(bilateral); -typedef struct ThreadData { - int height; - int width; -} ThreadData; - static int query_formats(AVFilterContext *ctx) { static const enum AVPixelFormat pix_fmts[] = {